534151 – [Win32] Bad looking tree in dark theme

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 534151 - [Win32] Bad looking tree in dark theme

Summary: [Win32] Bad looking tree in dark theme

Status:	CLOSED DUPLICATE of bug 562576

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	SWT (show other bugs)
Version:	4.8
Hardware:	PC Windows 10

Importance:	P3 normal with 1 vote (vote)
Target Milestone:	---
Assignee:	Platform-SWT-Inbox
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2018-04-27 09:08 EDT by Eugene Kiryakov
Modified:	2020-04-30 12:54 EDT (History)
CC List:	2 users (show)

See Also:	562576

Attachments
Picture with tree (15.55 KB, image/png) 2018-04-27 09:08 EDT, Eugene Kiryakov	no flags	Details
Project with test view (view has tree from picture on it) (7.68 KB, application/octet-stream) 2018-04-27 09:09 EDT, Eugene Kiryakov	no flags	Details
Problems view has same issues as i described (22.71 KB, image/png) 2019-01-30 02:50 EST, Eugene Kiryakov	no flags	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Eugene Kiryakov

2018-04-27 09:08:07 EDT

Created attachment 273837 [details]
Picture with tree

Tree looks bad in dark theme. 
Arrow has black background color, not tree item background color.
Hot items drawing is ugly. ("Mid Item 1" is hot (mouse over it))

Comment 1 Eugene Kiryakov

2018-04-27 09:09:35 EDT

Created attachment 273839 [details]
Project with test view (view has tree from picture on it)

Comment 2 Lars Vogel

2018-05-24 08:38:21 EDT

Is this a custom tree? We package explorer and project explorer in which the trees look ok. If this is a custom tree, you need to add styling to it, see eclipse.platform.ui repo in org.eclipse.ui.themes for our default styling.

Comment 3 Eugene Kiryakov

2018-06-06 10:52:30 EDT

(In reply to Lars Vogel from comment #2)
> Is this a custom tree? We package explorer and project explorer in which the
> trees look ok. If this is a custom tree, you need to add styling to it, see
> eclipse.platform.ui repo in org.eclipse.ui.themes for our default styling.

This is not custom tree. I'm using org.eclipse.jface.viewers.TreeViewer
Here is how i create it:

viewer = new TreeViewer(parent, SWT.MULTI | SWT.H_SCROLL | SWT.V_SCROLL | SWT.FULL_SELECTION);
viewer.setContentProvider(new ViewContentProvider());
viewer.getTree().setHeaderVisible(true);

Comment 4 Lars Vogel

2018-06-06 11:00:51 EDT

(In reply to Eugene Kiryakov from comment #3)
> This is not custom tree. 

Please upload an example project to demonstrate this.

Comment 5 Eugene Kiryakov

2018-06-07 05:14:31 EDT

(In reply to Lars Vogel from comment #4)
> (In reply to Eugene Kiryakov from comment #3)
> > This is not custom tree. 
> 
> Please upload an example project to demonstrate this.

I have already uploaded it, see comment 1

https://bugs.eclipse.org/bugs/attachment.cgi?id=273839&action=edit

Comment 6 Eugene Kiryakov

2019-01-30 02:50:25 EST

Created attachment 277368 [details]
Problems view has same issues as i described

(In reply to Lars Vogel from comment #2)
> Is this a custom tree? We package explorer and project explorer in which the
> trees look ok.

Just opened 2018-12 eclipse and tree in Problems view has same problems as i described:
- tree arrow background color not same as tree background color
- light theme tree arrow is visible under dark theme tree arrow
- hot item has different background color in text area and out of text area

Comment 7 Lars Vogel

2020-04-30 12:54:46 EDT

Will be handled via Bug 562576

*** This bug has been marked as a duplicate of bug 562576 ***