Community
Participate
Working Groups
The used heap color in the dark theme is IIRC hard-code and to light. We should make it configurable and find a better color.
Created attachment 273673 [details] Screenshot
Roland, something for you?
(In reply to Lars Vogel from comment #0) > The used heap color in the dark theme is IIRC hard-code and to light. We > should make it configurable and find a better color. ... too light ...
Created attachment 274383 [details] Existing Heap Status (Light / Dark Themed)
Created attachment 274384 [details] Proposed Heap Status (Light / Dark Themed) I actually don't think the colour is so bad on the dark theme. It could be maybe a bit darker. Relevant constant is in HeapStatus, field usedMemCol. Currently usedMemCol is rgb(162,162,161) (SWT.COLOR_WIDGET_NORMAL_SHADOW) for me on both light and dark themes. I would propose making it something like rgb(130,130,130). This should make it a bit darker on both themes. Specifically it'll improve the dark theme without affecting the light theme too much. I could propose something for review if this is deemed worth changing. diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/HeapStatus.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/HeapStatus.java index ec21f7848f..c1cbe0ff7c 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/HeapStatus.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/HeapStatus.java @@ -126,7 +126,8 @@ public class HeapStatus extends Composite { imgBounds = gcImage.getBounds(); disabledGcImage = new Image(display, gcImage, SWT.IMAGE_DISABLE); } - usedMemCol = display.getSystemColor(SWT.COLOR_WIDGET_NORMAL_SHADOW); + + usedMemCol = new Color(display, 130, 130, 130); lowMemCol = new Color(display, 255, 70, 70); // medium red freeMemCol = new Color(display, 255, 190, 125); // light orange bgCol = display.getSystemColor(SWT.COLOR_WIDGET_BACKGROUND);
Note: I have not tested this yet on Mac and Windows so if SWT.COLOR_WIDGET_NORMAL_SHADOW is a different constant (likely) then this approach fails and we'll need to find an actual constant that works better.
(In reply to Roland Grunberg from comment #6) > Note: I have not tested this yet on Mac and Windows so if > SWT.COLOR_WIDGET_NORMAL_SHADOW is a different constant (likely) then this > approach fails and we'll need to find an actual constant that works better. +1 for this. I the color would be a preference, we could style it in our CSS
The colour seems to be roughly rgb(160,160,160) for light/dark themes on Mac and Windows so this could probably work.
Ok, SWT.COLOR_TITLE_INACTIVE_FOREGROUND actually looks a bit better, but it should probably only be used in the case of GTK. Lars, I've noticed that in your screenshot (Ubuntu Ambiance ?), the colour used is rgb(169,169,168) while on mine (Fedora Adwaita), it's rgb(162,162,162). The slight theme difference is probably why it seems not so bad for me. Is there any chance you could run ControlExample from eclipse.platform.swt//examples/org.eclipse.swt.examples/src/org/eclipse/swt/examples/controlexample/ControlExample.java, and take a screenshots of the Color tab to have a rough idea of how things currently differ ?
Created attachment 274442 [details] Colors screenshot
(In reply to Roland Grunberg from comment #9) > Is there any chance you could run ControlExample from > eclipse.platform.swt//examples/org.eclipse.swt.examples/src/org/eclipse/swt/ > examples/controlexample/ControlExample.java, and take a screenshots of the > Color tab to have a rough idea of how things currently differ ? Of course, thanks for looking into this issue.
(In reply to Lars Vogel from comment #11) > Of course, thanks for looking into this issue. Roland, could you provide a Gerrit for this?
(In reply to Lars Vogel from comment #12) > (In reply to Lars Vogel from comment #11) > > Of course, thanks for looking into this issue. > > Roland, could you provide a Gerrit for this? Sure, sorry for the delay, seems I missed your screenshot attachment.
New Gerrit change created: https://git.eclipse.org/r/124898
Gerrit change https://git.eclipse.org/r/124898 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=af9dd8e2f0d1c25a6de973de8b43d80dbfe95daf
Thanks Roland.
