Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 532353 - [10] Java Version 10 of project facet java does not exist
Summary: [10] Java Version 10 of project facet java does not exist
Status: RESOLVED FIXED
Alias: None
Product: WTP Common Tools
Classification: WebTools
Component: Faceted Project Framework (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 3.10   Edit
Assignee: John Collier CLA
QA Contact: Konstantin Komissarchik CLA
URL:
Whiteboard:
Keywords:
Depends on: 522750 532727
Blocks: 532711
  Show dependency tree
 
Reported: 2018-03-12 10:57 EDT by Nick Boldt CLA
Modified: 2018-04-09 05:01 EDT (History)
9 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Boldt CLA 2018-03-12 10:57:35 EDT 
For Photon and Oxygen.3a.

NOTE: there is no 3.10 fix version for this project -- could someone add it?

See bug 522750, where facet support was added for JDK 9. Similar fix is likely needed here.
Comment 1 Nitin Dahyabhai CLA 2018-03-12 11:16:22 EDT 
(In reply to Nick Boldt from comment #0)
> NOTE: there is no 3.10 fix version for this project -- could someone add it?
Added, but preferably wouldn't be targeted until it's also assigned to someone.
Comment 2 Nick Boldt CLA 2018-03-12 12:04:45 EDT 
Can you also add a 3.9.3a or 3.9.4 (for Oxygen.3a) ?
Comment 3 Nick Boldt CLA 2018-03-19 16:32:30 EDT 
(per discussion on wtp-dev@)

>      There are two areas of WTP impacted by a new version of Java:  org.eclipse.jst.common.project.facet.core (where the Java facet is defined) and (possibly) JEM.
>   Any common committer can figure out what needs to be done for org.eclipse.jst.common.project.facet.core - see https://bugs.eclipse.org/bugs/show_bug.cgi?id=522750 . 

>  However, to my knowledge, [Carl is] the only one left with any JEM experience... let's just hope that there are no breaking changes there.

> There's only a smaller AST change, addition of a (read-only) property: org.eclipse.jdt.core.dom.SimpleType.isVar()
> From what little I know about JEM, it should not be affected by the JDK 10 change.

Note too that:

> we don't need to modify the toolchains until we have a bundle with a BREE of that level

So toolchains.xml in the webtools JIPP is unaffected by JDK 10.
Comment 4 Eclipse Genie CLA 2018-03-20 13:11:56 EDT 
New Gerrit change created: https://git.eclipse.org/r/119805
Comment 5 Rob Stryker CLA 2018-03-21 00:56:42 EDT 
I've +1'd the patch. It looks good. 

Is there a bug open for webservices to make use of this string yet? 

When Bug 522750  (java 9) was created, Bug 525337 was opened for webservices. Is there such a companion bug here for java 10?
Comment 6 Giovanni Lovato CLA 2018-03-21 05:34:44 EDT 
Given the new 6-months Java release lifecycle, it would be great to have this fixes available before new releases!
Comment 8 Eclipse Genie CLA 2018-03-21 11:05:16 EDT 
New Gerrit change created: https://git.eclipse.org/r/119877
Comment 9 Nick Boldt CLA 2018-03-21 11:09:56 EDT 
(In reply to Rob Stryker from comment #5)
> Is there a bug open for webservices to make use of this string yet? 
> When Bug 522750  (java 9) was created, Bug 525337 was opened for
> webservices. Is there such a companion bug here for java 10?

When in doubt, assume no one has created a bug, and open one yourself. :)

>> https://bugs.eclipse.org/bugs/show_bug.cgi?id=532711
Comment 10 Eclipse Genie CLA 2018-03-21 11:17:30 EDT 
New Gerrit change created: https://git.eclipse.org/r/119878