Description Roland Grunberg 2018-03-01 11:56:05 EST

This was brought about by Bug 515755.

Basically, INFORMATION_BACKGROUND improves the background of the popup mentioned above on the dark theme but it still doesn't look ideal on Linux, Mac, or win32 with the dark theme :

Before INFORMATION_BACKGROUND :

https://bugs.eclipse.org/bugs/attachment.cgi?id=268091
https://bugs.eclipse.org/bugs/attachment.cgi?id=272947

With INFORMATION_BACKGROUND :

https://bugs.eclipse.org/bugs/attachment.cgi?id=272948
https://bugs.eclipse.org/bugs/attachment.cgi?id=272642


The following change :

In bundles/org.eclipse.ui.themes/css/dark/e4-dark_preferencestyle.css

-                 'org.eclipse.ui.workbench.INFORMATION_BACKGROUND=52,57,61'
+               'org.eclipse.ui.workbench.INFORMATION_BACKGROUND=81,86,88'

makes it look like https://bugs.eclipse.org/bugs/attachment.cgi?id=272949 .

The main thing to investigate is whether this has any negative effect on all the other places that use INFORMATION_BACKGROUND. The basic assumption is that most things styled with INFORMATION_BACKGROUND should be some kind of shell or, something that may be placed on a shell. In either case they should probably have the same background colour as given to shells on the dark theme, which is defined in bundles/org.eclipse.ui.themes/css/dark/e4-dark_globalstyle.css as #515658 (rgb 81,86,88).

I wouldn't say this blocks Bug 515755 since using INFORMATION_BACKGROUND is still an improvement regardless, but it would certainly look better if this change was considered.