530397 – [Gtk] Make gdbus initialization dynamic

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 530397 - [Gtk] Make gdbus initialization dynamic

Summary: [Gtk] Make gdbus initialization dynamic

Status:	VERIFIED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	SWT (show other bugs)
Version:	4.8
Hardware:	PC Linux

Importance:	P3 normal (vote)
Target Milestone:	4.8 M6
Assignee:	Leo Ufimtsev
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2018-01-26 14:30 EST by Leo Ufimtsev
Modified:	2018-03-07 16:26 EST (History)
CC List:	2 users (show)

See Also:	swtWaylandLauncher 530324 Gerrit Change Gerrit Change Git Commit Git Commit

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Leo Ufimtsev

2018-01-26 14:30:17 EST

In the recent implementation we made it so that gdbus is started if swt.dbus.init system property was set.

But after some thought, it seems like it may be better to invoke it dynamically if there's a need for it in SWT. I.e when OpenDocument or OpenUrl are registered.

Comment 1 Eclipse Genie

2018-01-26 14:33:52 EST

New Gerrit change created: https://git.eclipse.org/r/116138

Comment 2 Eclipse Genie

2018-01-26 14:45:07 EST

New Gerrit change created: https://git.eclipse.org/r/116140

Comment 4 Eclipse Genie

2018-01-26 15:39:56 EST

Gerrit change https://git.eclipse.org/r/116138 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=e1810e11b59acc83c8b0dc376540d361c667fc82

Comment 5 Leo Ufimtsev

2018-01-26 15:40:46 EST

Awaiting equinox patch to be merged.

For verification later:
1)
./eclipse myFile

2) ./eclipse
 <wait to open>
   ./eclipse myFile

Comment 6 Leo Ufimtsev

2018-01-29 16:22:14 EST

Awaiting merge of equinox patch.

Comment 7 Eclipse Genie

2018-01-30 01:49:38 EST

Gerrit change https://git.eclipse.org/r/116140 was merged to [master].
Commit: http://git.eclipse.org/c/equinox/rt.equinox.framework.git/commit/?id=99ea6b27ab528bdc5a5158fab0b9c8f4208a359a

Comment 8 Leo Ufimtsev

2018-03-07 16:25:46 EST

Verified in lastest master.
./eclipse file 
opens files as expected and gdbus isn't initialized unless needed.