Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 528967 - [9][content assist] support content assist for module declaration name
Summary: [9][content assist] support content assist for module declaration name
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 4.8   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.7.3   Edit
Assignee: Noopur Gupta CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 528981
  Show dependency tree
 
Reported: 2017-12-19 11:30 EST by Noopur Gupta CLA
Modified: 2018-02-08 06:39 EST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Noopur Gupta CLA 2017-12-19 11:30:13 EST 
Support content assist for org.eclipse.jdt.core.CompletionProposal.MODULE_DECLARATION which provides the module declaration name.
Comment 1 Noopur Gupta CLA 2017-12-19 11:35:09 EST 
Manoj, I don't see any mention of MODULE_DECLARATION in the Javadoc of org.eclipse.jdt.core.CompletionProposal.getDeclarationSignature() or any other proposal API from JDT Core.

How should clients get the module declaration name from the proposal?
Comment 2 Manoj N Palat CLA 2017-12-22 03:28:19 EST 
(In reply to Noopur Gupta from comment #1)
> Manoj, I don't see any mention of MODULE_DECLARATION in the Javadoc of
> org.eclipse.jdt.core.CompletionProposal.getDeclarationSignature() or any
> other proposal API from JDT Core.
> 
> How should clients get the module declaration name from the proposal?

Will add the support via 529123
Comment 3 Eclipse Genie CLA 2017-12-22 05:42:29 EST 
New Gerrit change created: https://git.eclipse.org/r/114654
Comment 4 Noopur Gupta CLA 2017-12-22 05:44:42 EST 
(In reply to Eclipse Genie from comment #3)
> New Gerrit change created: https://git.eclipse.org/r/114654

JDT UI patch based on the patch in bug 529123. It uses CompletionProposal#getDeclarationSignature to get the required information for MODULE_DECLARATION.
Comment 6 Eclipse Genie CLA 2018-01-02 04:39:22 EST 
New Gerrit change created: https://git.eclipse.org/r/114856
Comment 7 Noopur Gupta CLA 2018-01-02 04:41:31 EST 
(In reply to Eclipse Genie from comment #5)
> Gerrit change https://git.eclipse.org/r/114654 was merged to [master].
> Commit:
> http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=134ad748fdf8683823fba4ce6c4bd827a0622277
Released the fix in master.

(In reply to Eclipse Genie from comment #6)
> New Gerrit change created: https://git.eclipse.org/r/114856
To be released in R4_7 after the fix in bug 529123 is backported.
Comment 8 Eclipse Genie CLA 2018-01-03 06:35:38 EST 
Gerrit change https://git.eclipse.org/r/114856 was merged to [R4_7_maintenance].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=d52d41ef8e5016d355a9780279aa91c9dafd7536
Comment 9 Noopur Gupta CLA 2018-01-25 02:08:27 EST 
Verified in I20180124-2000.
Comment 10 Noopur Gupta CLA 2018-02-08 06:39:39 EST 
Verified for 4.7.3 in M20180207-1700.