Community
Participate
Working Groups
Quick hack to support Tycho 1.0 (instead of <= 0.26.0) is to enable tycho-compiler-plugin's useProjectSettings=false [1] so that things like API restrictions that SHOULD fail the build are allowed. Ultimately, these API violation should be fixed, but if your Eclipse settings are allowing these to be ignored as warnings instead of errors, then so too should Tycho do the same. Thus we need to add this to the root pom: <build> <plugins> <plugin> <groupId>org.eclipse.tycho</groupId> <artifactId>tycho-compiler-plugin</artifactId> <version>${tycho.version}</version> <configuration> <useProjectSettings>false</useProjectSettings> </configuration> </plugin> </plugins> </build> [1] https://wiki.eclipse.org/Tycho/Release_Notes/1.0.0#Compiler
Created attachment 271133 [details] patch to support building w/ Tycho 1.0 and remove test plugin error I was running with these flags, which I realize are contradictory: tv=1.0.0; mvn clean install -V -B \ -Dmaven.test.skip=true -DskipWithIssues=false -Dmaven.test.error.ignore=true -Dmaven.test.failure.ignore=true \ -Dsurefire.timeout=1800 -Dplatform-repo.url=http://download.eclipse.org/eclipse/updates/4.8-I-builds/ -Dwebtools.buildSite=http://download.eclipse.org/webtools/downloads/drops/R3.10.0/I-3.10.0-20171004000115/ -Dtycho.version=${tv} -Dtycho-extras.version=${tv} -Pintegration -ff | tee log${tv}.txt So I removed the -DskipWithIssues=false flag and also removed the mapping in the jpa/tests/org.eclipse.jpt.jpa.core.tests/pom.xml as it was failing to build too.
BTW I would have submitted this via gerrit but alas, Dali is still gerrit-free. :(
FYI, the releng.aggregator build is still failing due to jpa not being ready to build with Tycho 1.0: [INFO] org.eclipse.jpt.jpa.core.tests ..................... FAILURE [02:39 min] https://hudson.eclipse.org/webtools/job/WTP-R3_10_Integration_tycho1.0/22/ If we could get this fixed, we could start taking advantage of Tycho 1.0 features when building Dali and the rest of the wtp stack. @Shaurn or @Neil, can I get some help getting this merged?
Created attachment 271543 [details] patch to support building w/ Tycho 1.0 and remove test plugin error (cleaned up formatting)
Hey @Brian, can you push this change into Dali? I see you helped Mickael get a change [1] pushed back in May, which seems to be the last time anyone's committed anything to Dali. [1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=492323 http://git.eclipse.org/c/dali/webtools.dali.git/ Also, would you be interested in working with me to get Gerrit enabled on the repo? (By way of introduction, I'm the new releng guy for WTP, trying to improve the way/speed WTP is built, including getting the tests running again and being able to take advantage for Tycho 1.x fixes/features.
(In reply to Nick Boldt from comment #5) > Hey @Brian, can you push this change into Dali? I see you helped Mickael get > a change [1] pushed back in May, which seems to be the last time anyone's > committed anything to Dali. > > [1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=492323 > http://git.eclipse.org/c/dali/webtools.dali.git/ > > Also, would you be interested in working with me to get Gerrit enabled on > the repo? (By way of introduction, I'm the new releng guy for WTP, trying to > improve the way/speed WTP is built, including getting the tests running > again and being able to take advantage for Tycho 1.x fixes/features. I just pushed your patch. But you should verify. :-) Also: Yes, I would be happy to work with you enabling Gerrit for Dali. Let me know what I can do.
Thanks, Brian - should have pinged you ages ago. :) As to getting Gerrit enabled, please talk to Neil Hauge as he's also agreed to get Gerrit enabled this week (in an email thread). FYI, here's the wiki on how to enable Gerrit. https://wiki.eclipse.org/Gerrit#Enabling_Gerrit_for_your_Eclipse.org_Project If you have more cycles this week than him and can tackle it sooner (or don't live in the US and aren't AFK on PTO for Black Friday / US Thanksgiving) feel free to contact him to coordinate the attack. :)
Created attachment 271565 [details] log of running dali tests with Tycho 1.0 Using: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T03:58:13-04:00) Java home: /usr/lib/jvm/java-1.8.0-openjdk-1.8.0.141-1.b16.fc24.x86_64/jre $ mvn clean install -Pintegration -fn -e -Dtycho.version=1.0.0 -Dtycho-extras.version=1.0.0 | tee log_tycho1.0.0_tests_run.txt These tests/features fail: [INFO] org.eclipse.jpt.jaxb.core.tests .................... FAILURE [ 2.801 s] [INFO] org.eclipse.jpt.jaxb.eclipselink.core.tests ........ SKIPPED [INFO] org.eclipse.jpt.jaxb.eclipselink.tests.feature ..... SKIPPED [INFO] org.eclipse.jpt.jaxb.tests.feature ................. SKIPPED [INFO] org.eclipse.jpt.jpa.core.tests ..................... FAILURE [ 3.717 s] [INFO] org.eclipse.jpt.jpa.eclipselink.core.tests ......... SKIPPED [INFO] org.eclipse.jpt.jpa.eclipselink.tests.feature ...... SKIPPED [INFO] org.eclipse.jpt.jpa.tests.feature .................. SKIPPED [INFO] org.eclipse.jpt.tests.assembly.feature ............. SKIPPED
This PR will disable the tests that don't currently work, until someone has time to update them to run with Tycho 1.0. Since they are currently BUILT but not RUN as part of the webtools.releng.aggregator job, I figure this isn't a problem. https://git.eclipse.org/r/#/c/112514/1/pom.xml
A couple more PRs to merge as part of revamping Dali to run with Tycho 1.0: https://git.eclipse.org/r/#/c/112579/ < fix tests which end too fast in Hudson? https://git.eclipse.org/r/#/c/112571/ - add update site to Dali build reactor https://git.eclipse.org/r/#/c/112515/ - disable tests and add repo refs to resolve upstream wtp.parent pom, common, servertools, etc.
More PRs for Dali: https://git.eclipse.org/r/#/c/112904/ - comment out all the 'finished a bit too early' tests since the 'reasonable guess' is turning out to be unreasonable [merged] https://git.eclipse.org/r/#/c/112906/ - disable org.eclipse.jpt.jpa.eclipselink.core.tests and org.eclipse.jpt.jpa.eclipselink.tests.feature since they require org.eclipse.jpt.jpa.core.tests, which is also disabled
All PRs merged and build is green, without the need for -Pintegration workaround flag. https://hudson.eclipse.org/webtools/view/webtools_R3_10/job/webtools-dali_R3_10/ Resolving.
