Community
Participate
Working Groups
Quick hack to support Tycho 1.0 (instead of <= 0.26.0) is to enable tycho-compiler-plugin's useProjectSettings=false [1] so that things like API restrictions that SHOULD fail the build are allowed. Ultimately, these API violation should be fixed, but if your Eclipse settings are allowing these to be ignored as warnings instead of errors, then so too should Tycho do the same. Thus we need to add this to the root pom: <build> <plugins> <plugin> <groupId>org.eclipse.tycho</groupId> <artifactId>tycho-compiler-plugin</artifactId> <version>${tycho.version}</version> <configuration> <useProjectSettings>false</useProjectSettings> </configuration> </plugin> </plugins> </build> [1] https://wiki.eclipse.org/Tycho/Release_Notes/1.0.0#Compiler BTW, the Version here should be 3.10, but bugzilla needs to be updated to add that fixversion.
New Gerrit change created: https://git.eclipse.org/r/110479
To build locally with this change: cd webtools.webservices tv=1.0.0 here=$(pwd);here=${here##*/}; echo $here; mvn clean install -V -B -Dmaven.test.skip=true -DskipWithIssues=false -Dmaven.test.error.ignore=true -Dmaven.test.failure.ignore=true -Dsurefire.timeout=1800 -Dplatform-repo.url=http://download.eclipse.org/eclipse/updates/4.8-I-builds/ -Dwebtools.buildSite=http://download.eclipse.org/webtools/downloads/drops/R3.10.0/I-3.10.0-20171004000115/ -Dtycho.version=${tv} -Dtycho-extras.version=${tv} -Pintegration -ff | tee log${tv}-useProjectSettings-false.txt
This compiles w/ 0.22 but with 1.0.0, at least one test fails: [INFO] org.eclipse.wst.wsi.tests .......................... FAILURE [30:02 min] [ERROR] Failed to execute goal org.eclipse.tycho:tycho-surefire-plugin:1.0.0:test (default-test) on project org.eclipse.wst.wsi.tests: An unexpected error occured while launching the test runtime (return code 143). See log for details.
(In reply to Nick Boldt from comment #3) > This compiles w/ 0.22 but with 1.0.0, at least one test fails: > > [INFO] org.eclipse.wst.wsi.tests .......................... FAILURE [30:02 > min] > > [ERROR] Failed to execute goal > org.eclipse.tycho:tycho-surefire-plugin:1.0.0:test (default-test) on project > org.eclipse.wst.wsi.tests: An unexpected error occured while launching the > test runtime (return code 143). See log for details. Hi Nick, do we need to fix this now, for the build?
eg. can we disable running the wsi tests for now, if you want to make progress. I think mvn has an option to skip tests.
Gerrit change https://git.eclipse.org/r/110479 was merged to [master]. Commit: http://git.eclipse.org/c/webservices/webtools.webservices.git/commit/?id=cfaf7f7690e0da9db276680c3a9d10db888b8179
Nick, I've merged it since you want it done before the dev call.
(In reply to Keith Chong from comment #5) > I think mvn has an option to skip tests. Yes, using -DskipTests would work. But skipping tests is no longer a viable long-term solution. The overall wtp releng.aggregator build has been skipping tests for ages now, which is why there are no longer reported test results. #underNewManagement
Suppport Tycho: WSDLParser change https://git.eclipse.org/r/#/c/110760/
New Gerrit change created: https://git.eclipse.org/r/110768
Plugin and feature version changes: https://git.eclipse.org/r/#/c/110768/
Gerrit change https://git.eclipse.org/r/110768 was merged to [master]. Commit: http://git.eclipse.org/c/webservices/webtools.webservices.git/commit/?id=86643a8cbe90af3d956ed09eac62c8ffefda4118
More PRs that I forgot to attach BZ numbers to: * clean up gitignores: https://git.eclipse.org/r/#/c/110759 * Fix compilation error: https://git.eclipse.org/r/#/c/110760/ * Fix wsi.tests: https://git.eclipse.org/r/#/c/110766/
@Keith: can you merge this last request? * Fix wsi.tests: https://git.eclipse.org/r/#/c/110766/
(In reply to Nick Boldt from comment #14) > @Keith: > > can you merge this last request? > > * Fix wsi.tests: https://git.eclipse.org/r/#/c/110766/ Hi Nick, I've merged this one.
Resolving. webservices can now build w/ Tycho 1.0 and runs tests. Once we have all its upstream projects publishing update sites, we can update the root pom to be able to build this project standalone, without having to first build common, servertools, javaee, and whatever else ws depends on.
Spoke too soon. Need another fix here to run a build w/ Tycho 1.0 and resolve the parent pom plus upstream deps: https://git.eclipse.org/r/#/c/112095/ This isn't technically part of this bug but seemed easier than opening a new one just for this simple fix. Hope that's OK. If you prefer a fresh BZ for "support running CI build of webservices in HIPP" I can open a new one.
Once merged, this job [1] should be kicked again and should be green. [1] https://hudson.eclipse.org/webtools/view/webtools_R3_10/job/webtools-webservices_R3_10
Actually, I worked around the need for the PR for now so we can see what's happening in Jenkins. [INFO] org.eclipse.jst.ws.jaxrs.core ...................... FAILURE [ 1.300 s] [ERROR] Failed to execute goal org.eclipse.tycho:tycho-compiler-plugin:1.0.0:compile (default-compile) on project org.eclipse.jst.ws.jaxrs.core: Compilation failure: Compilation failure: [ERROR] /jobs/genie.webtools/webtools-webservices_R3_10/workspace/bundles/org.eclipse.jst.ws.jaxrs.core/src/org/eclipse/jst/ws/jaxrs/core/internal/project/facet/JAXRSJEEUtils.java:[236] [ERROR] ((WebApp) webAppObj).getVersion() == WebAppVersionType._40))) [ERROR] ^^^ [ERROR] _40 cannot be resolved or is not a field [ERROR] /jobs/genie.webtools/webtools-webservices_R3_10/workspace/bundles/org.eclipse.jst.ws.jaxrs.core/src/org/eclipse/jst/ws/jaxrs/core/internal/project/facet/JAXRSJEEUtils.java:[254] [ERROR] if(w.getVersion() == WebAppVersionType._40) { [ERROR] ^^^ [ERROR] _40 cannot be resolved or is not a field [ERROR] 2 problems (2 errors) Full log here: https://hudson.eclipse.org/webtools/view/webtools_R3_10/job/webtools-webservices_R3_10/3/console
https://hudson.eclipse.org/webtools/view/webtools_R3_10/job/WTP-R3_10_Integration/168/ was successfully built with Tycho 1.0, Maven 3.3.3, and JDK 1.8.0_131. So we're good here.
