This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 526303 - Clean up code to compile with Tycho 1.0
Summary: Clean up code to compile with Tycho 1.0
Status: RESOLVED FIXED
Alias: None
Product: WTP Java EE Tools
Classification: WebTools
Component: jst.j2ee (show other bugs)
Version: 3.10   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: jst.j2ee CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 525342
  Show dependency tree
 
Reported: 2017-10-20 08:08 EDT by Nick Boldt CLA
Modified: 2017-12-12 15:14 EST (History)
2 users (show)

See Also:

Attachments
ConnectorLabelProvider Diff (253.28 KB, image/png)
2017-11-30 11:27 EST, John Collier CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Boldt CLA 2017-10-20 08:08:24 EDT 
Problems:

* missing @Overrides
* unnecessary casts
* unused imports
* missing synchronized keywords
* unnecessary null checks
* javadoc @link compilation errors
Comment 1 Eclipse Genie CLA 2017-10-20 08:09:52 EDT 
New Gerrit change created: https://git.eclipse.org/r/110446
Comment 2 Nick Boldt CLA 2017-10-20 08:10:01 EDT 
With this PR [1], I can build all of javaee with Tycho 1.0:

mvn clean install -V -B -Dmaven.test.skip=true -DskipWithIssues=false       -Dmaven.test.error.ignore=true -Dmaven.test.failure.ignore=true       -Dsurefire.timeout=1800 -ff -Dplatform-repo.url=http://download.eclipse.org/eclipse/updates/4.8-I-builds/ -Dwebtools.buildSite=http://download.eclipse.org/webtools/downloads/drops/R3.10.0/I-3.10.0-20171004000115/ -Dtycho.version=1.0.0 -Dtycho-extras.version=1.0.0 -Pintegration | tee log.txt

[1] https://git.eclipse.org/r/110446
Comment 4 Carl Anderson CLA 2017-11-03 16:07:00 EDT 
Nick, you broke org.eclipse.jst.jee/org.eclipse.jst.jee.ui.internal.navigator.ConnectorLabelProvider ... it used to concatenate a message string with the results from a ?: operation... now it takes the string and does a null check and an && operation... so no more concatenation, we lose the main message!
Comment 5 Chuck Bridgham CLA 2017-11-16 13:01:14 EST 
This should be closed
Comment 6 Nick Boldt CLA 2017-11-20 21:34:48 EST 
(In reply to Carl Anderson from comment #4)
> Nick, you broke
> org.eclipse.jst.jee/org.eclipse.jst.jee.ui.internal.navigator.
> ConnectorLabelProvider ... it used to concatenate a message string with the
> results from a ?: operation... now it takes the string and does a null check
> and an && operation... so no more concatenation, we lose the main message!

Did this get fixed, or did this issue get closed too soon?
Comment 7 Nick Boldt CLA 2017-11-20 21:37:08 EST 
I don't see any commits in https://git.eclipse.org/c/jeetools/webtools.javaee.git/log/ after my merge/commit. So I'm reopening this. 

Not sure how to fix it -- can someone suggest a fix?
Comment 8 Nick Boldt CLA 2017-11-29 09:20:20 EST 
@Carl, can you provide more details on what was broken and how to fix it? Or provide a PR? or just merge in a fix? Thanks!
Comment 9 John Collier CLA 2017-11-30 11:27:10 EST 
Created attachment 271717 [details]
ConnectorLabelProvider Diff

@Nick

Lines 24, 26, and 28 in ConnectorLabelProvider were changed from concatenating two strings and returning the restult, to checking if the strings are null and only returning the second half of the concatenated string.

See the attached diff for details
Comment 10 Eclipse Genie CLA 2017-12-07 15:32:58 EST 
New Gerrit change created: https://git.eclipse.org/r/113032
Comment 12 John Collier CLA 2017-12-12 15:14:52 EST 
Closing since the error message concatenation issue has been resolved