Community
Participate
Working Groups
The changes for https://bugs.eclipse.org/bugs/show_bug.cgi?id=512215 have removed the highlighting of the days in the CDateTime widget. When clicking on a day button, it should become highlighted to show that it's been "selected". And, of course, when the CDateTime date picker is first shown, the current date should be displayed as "selected", or highlighted. The change was made with the comment that the use of 'theme' only worked on Windows and GTK versions. Well, that's rather large segment. I think a better fix would be to include code that works with current SWT releases, and put a more permanent fix on a "to do" list.
We will not resurrect the code that SWT has dropped. The path forward is to remove our dependency on that code. Are you able to work on this Glenn?
New Gerrit change created: https://git.eclipse.org/r/106539
We can't bild project which use org.eclipse.nebula.cwt under Eclipse 4.7. Are there any workarounds?
(In reply to Vladimir Borkovkin from comment #3) > We can't bild project which use org.eclipse.nebula.cwt under Eclipse 4.7. > Are there any workarounds? Is this related to this bug?
Vladimir Borkovkin - you can pick up the changes I propose from the Gerrit review posted 2017-10-10 16:52:52 EDT. But it is unofficial at this point in time. It works with Eclipse 4.7, and we are using it in production. I believe that the 1.3.0 release of Nebula does not depend on org.eclipse.swt.internal or org.eclipse.swt.internal.win32. It should work with Eclipse 4.7, but there are limitations.
(In reply to Glenn Burkhardt from comment #5) > Vladimir Borkovkin - you can pick up the changes I propose from the Gerrit > review posted 2017-10-10 16:52:52 EDT. But it is unofficial at this point > in time. It works with Eclipse 4.7, and we are using it in production. > > I believe that the 1.3.0 release of Nebula does not depend on > org.eclipse.swt.internal or org.eclipse.swt.internal.win32. It should work > with Eclipse 4.7, but there are limitations. Also those patches only work on Windows. Changes will be required to work on other platforms.
(In reply to Wim Jongman from comment #1) > We will not resurrect the code that SWT has dropped. The path forward is to > remove our dependency on that code. > > Are you able to work on this Glenn? Possibly, but not this week.
(In reply to Vladimir Borkovkin from comment #3) > We can't bild project which use org.eclipse.nebula.cwt under Eclipse 4.7. > Are there any workarounds? You should be able to build if you pull the 1.3.0 release. But some things will not work.
1.3.0 release still has imports from org.eclipse.swt.internal.theme and project can't be compiled under eclipse 4.7/4.7.1. Strange things happens, there are handerts of tests, but obvious bugs stays for months.
(In reply to Vladimir Borkovkin from comment #9) > 1.3.0 release still has imports from org.eclipse.swt.internal.theme and > project can't be compiled under eclipse 4.7/4.7.1. > Strange things happens, there are handerts of tests, but obvious bugs stays > for months. We are compiling fine against 4.7.1. Make sure that you have 1.3.0 installed. See this commit [1] In case you run into this bug [2] make sure you get the latest snapshot. [1] http://git.eclipse.org/c/nebula/org.eclipse.nebula.git/diff/widgets/cwt/org.eclipse.nebula.cwt/META-INF/MANIFEST.MF?id=125e7af7b11e32cf10569c3e56c082e5e2111caf [2] https://bugs.eclipse.org/bugs/show_bug.cgi?id=525717
(In reply to Vladimir Borkovkin from comment #9) > 1.3.0 release still has imports from org.eclipse.swt.internal.theme and > project can't be compiled under eclipse 4.7/4.7.1. > Strange things happens, there are handerts of tests, but obvious bugs stays > for months. Please identify the files from 1.3.0 that don't compile correctly.
New Gerrit change created: https://git.eclipse.org/r/111866
Created attachment 271549 [details] New selection background
Gerrit change https://git.eclipse.org/r/111866 was merged to [master]. Commit: http://git.eclipse.org/c/nebula/org.eclipse.nebula.git/commit/?id=859d7fa882bbdf317ae3c90a480e7d85c852ab88
I think this is fixed, Glenn. Please take a look and reopen if you still find problems.
Created attachment 271559 [details] Calendar showing two different button styles
Thanks for the nudge. I should have tried working on this, and I should get some time over our holiday this week. As I noted in the review, the background change you made is an improvement, but doesn't look nearly as nice as it did before. Please see the attachment. The '16' is displayed using the button style for 'SELECTED'. The '25' is displayed using the button style for 'ACTIVE'. The button is colored 'ACTIVE' as the mouse moves over the calendar. The 'ACTIVE' button is not quite as dark as the 'SELECTED' button, and button boundary is outlined, with the corners rounded. The focus rectangle drawn on my Win7 system has dotted lines for the right and bottom sides only. Also, somehow the shaded background you added isn't centered over the text. My guess is that the text isn't centered in the control. But changing that could be tricky, since currently all the text aligns correctly under the day headings for the columns.
(In reply to Glenn Burkhardt from comment #17) > Thanks for the nudge. I should have tried working on this, and I should get > some time over our holiday this week. > > As I noted in the review, the background change you made is an improvement, > but doesn't look nearly as nice as it did before. Please see the attachment. I agree. I will reopen this so that we can make it better.
New Gerrit change created: https://git.eclipse.org/r/112026
(In reply to Eclipse Genie from comment #19) > New Gerrit change created: https://git.eclipse.org/r/112026 Glenn, I will probably abandon this change because there are too many collateral changes but you can take a look at it. It follows your suggestion. Basically we have to get rid of the theming thing and draw the backgrounds ourselves. I have made some changes already and it looks very doable. The changes start at line 25 of VButtonPainter where I have negated the paintnative check to enter the code block: if(!button.paintNative) { if(!button.paintInactive And then creating a paintBackGround method that will do the magic. For now, I have made some test code that we can extend. Please take a look.
Gerrit change https://git.eclipse.org/r/112026 was merged to [master]. Commit: http://git.eclipse.org/c/nebula/org.eclipse.nebula.git/commit/?id=87659b01a2f2fe1aa5126d6868fbc7f17d8b75cc
(In reply to Eclipse Genie from comment #21) > Gerrit change https://git.eclipse.org/r/112026 was merged to [master]. > Commit: > http://git.eclipse.org/c/nebula/org.eclipse.nebula.git/commit/ > ?id=87659b01a2f2fe1aa5126d6868fbc7f17d8b75cc Glenn, I have released this basic code. It will be easier for you to start working from head.
Created attachment 271660 [details] different renderings for CDateTime buttons
Created attachment 271661 [details] Mark I button rendering mimicing Win7 theme
I spent some time coming up with revised backgrounds for the buttons in SELECTED and ACTIVE states. I managed to get one with a gradient that matched what came up on Win7, but then noticed that Win10 has a different theme that's a lot easier to mimic. So I'd like to seek your advice on how to proceed. In the attachment "different renderings for CDateTime buttons", the first example of SELECTED and ACTIVE is what it used to look like on Win7. That example is smaller than the others because of the screen resolution on the system I made the screen shot from. The second one is what I came up with (and is generated by the attached "Mark I button rendering mimicing Win7 theme"). The third is what I committed this evening that pretty much matches the Win10 Theme based code (https://git.eclipse.org/r/#/c/112302/). I'm happy to leave it using the Win10 look alike going forward. It matches the rest of the CDateTime rendering pretty well, and it's more like to work on other platforms (like Linux, which I haven't tried). I also noticed that the business about VButton.FOCUSED was never used anywhere, and that the mapping of VControl STATE_xxxx onto VButton.HOT, etc., was only to use the SWT internal Theme paint code. So it has been stripped out. All the VButton states (VButton.HOT, etc.) are not referenced anywhere and can be removed as part of the removal of Theme... So what do you think? CDTSnippet02 is a good one to use for testing and making changes.
(In reply to Glenn Burkhardt from comment #25) > So what do you think? CDTSnippet02 is a good one to use for testing and > making changes. Looks great Glenn. Thank you for the patch. I have updated it a little bit for housekeeping. Can you take a look at it? https://git.eclipse.org/r/112303
That's quite a bit of cleanup. It all looks OK. Thanks.
Gerrit change https://git.eclipse.org/r/112302 was merged to [master]. Commit: http://git.eclipse.org/c/nebula/org.eclipse.nebula.git/commit/?id=d748cc59e6ee94db8b2b28d016b0f6a03de0d756
Gerrit change https://git.eclipse.org/r/112303 was merged to [master]. Commit: http://git.eclipse.org/c/nebula/org.eclipse.nebula.git/commit/?id=8cefa63ffa992d983f96ac37ff52acb7aeb2d554
Assigned to you Glenn. Thanks a lot! Please set the status to Resolved/Fixed and to Verified/Fixed once verified. https://wiki.eclipse.org/Nebula/Releases/1.5.0/NaN#CDateTime
