This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 525337 - Update Web Services to support Java 9
Summary: Update Web Services to support Java 9
Status: CLOSED FIXED
Alias: None
Product: WTP Webservices
Classification: WebTools
Component: jst.ws (show other bugs)
Version: unspecified   Edit
Hardware: PC Mac OS X
: P3 normal (vote)
Target Milestone: 3.9.1a   Edit
Assignee: Keith Chong CLA
QA Contact: Keith Chong CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 532711
  Show dependency tree
 
Reported: 2017-09-28 14:32 EDT by Keith Chong CLA
Modified: 2018-03-21 13:37 EDT (History)
4 users (show)

See Also:


Attachments
Apply to org.eclipse.jst.ws.consumption (2.67 KB, patch)
2017-09-28 14:51 EDT, Keith Chong CLA
no flags Details | Diff
Apply to org.eclipse.jst.enterprise_ui.feature (12.82 KB, patch)
2017-09-28 15:45 EDT, Keith Chong CLA
keith.chong.ca: review-
Details | Diff
Apply to org.eclipse.jst.enterprise_ui.featuret (1.17 KB, patch)
2017-09-28 15:46 EDT, Keith Chong CLA
no flags Details | Diff
Apply to org.eclipse.jst.ws.consumption (2.24 KB, patch)
2017-09-28 16:44 EDT, Keith Chong CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Chong CLA 2017-09-28 14:32:48 EDT
Depends on https://bugs.eclipse.org/bugs/show_bug.cgi?id=522750

Just need to update one class in org.eclipse.jst.ws.consumption

If this change isn't made, then Java 9 projects will not show up in the client wizard.
Comment 1 Keith Chong CLA 2017-09-28 14:51:49 EDT
Created attachment 270743 [details]
Apply to org.eclipse.jst.ws.consumption
Comment 2 Jonathan West CLA 2017-09-28 14:57:13 EDT
Patch looks good.
Comment 3 Keith Chong CLA 2017-09-28 15:45:09 EDT
Created attachment 270745 [details]
Apply to org.eclipse.jst.enterprise_ui.feature
Comment 4 Keith Chong CLA 2017-09-28 15:46:53 EDT
Created attachment 270746 [details]
Apply to org.eclipse.jst.enterprise_ui.featuret
Comment 5 Keith Chong CLA 2017-09-28 15:48:04 EDT
Comment on attachment 270745 [details]
Apply to org.eclipse.jst.enterprise_ui.feature

Ignore the first one because it includes formatting changes
Comment 6 Eclipse Genie CLA 2017-09-28 16:19:08 EDT
New Gerrit change created: https://git.eclipse.org/r/105976
Comment 8 Keith Chong CLA 2017-09-28 16:44:19 EDT
Created attachment 270747 [details]
Apply to org.eclipse.jst.ws.consumption
Comment 9 Keith Chong CLA 2017-09-28 16:45:48 EDT
Web service patch committed to master.  Carl, please merge the feature change.
Comment 10 Carl Anderson CLA 2017-09-29 11:48:23 EDT
org.eclipse.jst.enterprise_ui.feature change committed to master for WTP 3.9.1a
Comment 11 Eclipse Genie CLA 2017-10-02 11:59:34 EDT
New Gerrit change created: https://git.eclipse.org/r/106106
Comment 13 Keith Chong CLA 2017-10-02 12:02:58 EDT
Change to use JavaFacet.VERSION_9 pushed to master
Comment 14 Rob Stryker CLA 2018-03-21 00:57:49 EDT
@kchong if this bug is completed it should be closed. This was java 9. 

Also, it's worth asking, do you have a similar bug opened for java 10? Bug 532353 has been opened to add a java 10 facet.
Comment 15 Nick Boldt CLA 2018-03-21 09:39:11 EDT
This was done for 3.9.1a which was released, like, months ago.
Comment 16 Keith Chong CLA 2018-03-21 13:37:15 EDT
Rob/Nick, thanks for opening the bug.   Yes, this Java 9 change was for the 3.9.1a release last year.  I will have the Java 10 changes all delivered soon in 532717 (for 393a) and 532711 (already merged for Photon).