Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 522633 - [9] Disable bootstrap entries in PDE launcher for Execution env JavaSe-9 and runtime JRE - jdk-9
Summary: [9] Disable bootstrap entries in PDE launcher for Execution env JavaSe-9 and ...
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.7   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 4.7.2   Edit
Assignee: Vikas Chandra CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 521843
Blocks: 458235
  Show dependency tree
 
Reported: 2017-09-22 05:22 EDT by Sarika Sinha CLA
Modified: 2017-11-08 23:25 EST (History)
4 users (show)

See Also:
sarika.sinha: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sarika Sinha CLA 2017-09-22 05:22:23 EDT 
Taking details out of Bug 521843 -

PDE should set the required jars on classpath or modulepath instead of bootpath.
Comment 1 Vikas Chandra CLA 2017-09-22 13:17:08 EDT 
Will track the task on subject line via this bug.
Comment 2 Eclipse Genie CLA 2017-09-23 04:01:06 EDT 
New Gerrit change created: https://git.eclipse.org/r/105649
Comment 4 Sarika Sinha CLA 2017-09-24 23:42:36 EDT 
Vikas, You want to have a different bug to handle users ability to specify entries on Modulepath ?
Comment 5 Till Brychcy CLA 2017-09-25 02:44:28 EDT 
I saw the patch contains hardcoded checks for "9".

Note that the next java version will already be released in March 2018 as "18.3", so checking for "9 or later" would probably be a good idea.

http://www.oracle.com/technetwork/java/javase/eol-135779.html
Comment 6 Vikas Chandra CLA 2017-09-25 04:46:59 EDT 
Nice point, Till !

I will fix that issue via this bug before marking this verified. There are some other important things that is keeping me busy. But I should be able to fix this in the next few days.
Comment 7 Vikas Chandra CLA 2017-09-27 06:43:01 EDT 
Verified on

Version: Oxygen.1a (4.7.1a)
Build id: M20170926-1700


Although verified, I will keep this bug in resolved state to address issue of comment#5 immediately after 4.7.1a GA/release.

I think only blocker issues should be addressed in this week.
Comment 8 Eclipse Genie CLA 2017-09-28 05:25:01 EDT 
New Gerrit change created: https://git.eclipse.org/r/105905
Comment 10 Eclipse Genie CLA 2017-09-28 05:26:36 EDT 
New Gerrit change created: https://git.eclipse.org/r/105906
Comment 12 Vikas Chandra CLA 2017-09-29 01:52:02 EDT 
Also verified on
Version: Photon (4.8)
Build id: I20170928-2000
Comment 13 Vikas Chandra CLA 2017-10-12 05:04:15 EDT 
After fix of bug Bug 525583, this is open.

I will look at it for 4.7.2
Comment 14 Vikas Chandra CLA 2017-10-12 05:06:13 EDT 
The disable of "bootstrap entries" should be based on actual JRE used and not on execution environment JavaSe-9. I will look at this for 4.7.2.
Comment 15 Eclipse Genie CLA 2017-11-02 10:49:29 EDT 
New Gerrit change created: https://git.eclipse.org/r/110924
Comment 17 Vikas Chandra CLA 2017-11-03 02:11:23 EDT 
Now, the disable of "bootstrap entries" should be based on actual JRE used and not on execution environment JavaSe-9. Keeping this bug open for backport.
Comment 18 Vikas Chandra CLA 2017-11-03 04:29:21 EDT 
Requesting review for backport to 4.7.2RC1
Comment 19 Eclipse Genie CLA 2017-11-07 09:30:24 EST 
New Gerrit change created: https://git.eclipse.org/r/111117
Comment 20 Eclipse Genie CLA 2017-11-07 09:35:16 EST 
Gerrit change https://git.eclipse.org/r/111117 was merged to [R4_7_maintenance].
Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=3b3b5d579b63e78addc2dfa0d725f292a46f9635
Comment 21 Vikas Chandra CLA 2017-11-08 23:25:08 EST 
verified on

Version: Photon (4.8)
Build id: I20171106-2000

and


Version: Oxygen.2 (4.7.2)
Build id: M20171108-0500