522605 – [9] Target module in Add-reads configuration

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 522605 - [9] Target module in Add-reads configuration

Summary: [9] Target module in Add-reads configuration

Status:	RESOLVED FIXED

Alias:	None

Product:	JDT
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	4.7
Hardware:	All All

Importance:	P3 normal (vote)
Target Milestone:	4.7.1a
Assignee:	Stephan Herrmann
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:	521666
Blocks:
	Show dependency tree

Reported:	2017-09-21 13:42 EDT by Noopur Gupta
Modified:	2017-09-24 18:12 EDT (History)
CC List:	1 user (show)

See Also:	Git Commit Git Commit

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Noopur Gupta

2017-09-21 13:42:21 EDT

- Open Module properties dialog of JRE.
- In Details tab, click Add for read modules.
- Add a src module. Leave Target empty.
- Click OK.
=> Nothing is added in the table.

If target module is mandatory then OK should be disabled when it is empty.

Comment 1 Noopur Gupta

2017-09-21 13:46:22 EDT

Also, I tried adding some random entry in target module like "A         B". It is accepted.

Maybe we can use JavaConventions#validateModuleName and check for errors.

Comment 2 Stephan Herrmann

2017-09-24 18:05:06 EDT

Thanks for the suggestions.

I added validation for "Target module" to detect
- empty
- not a legal module name
While the text field has not been edited, the error is silent, i.e., not shown in the status line, but OK is disabled.

Also included: consistent quoting of names in validation messages.

Pushed to BETA_JAVA9 via http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?h=BETA_JAVA9&id=e4f8ac1575b431d519b72bb4b2ae10564cc39eea

Comment 3 Stephan Herrmann

2017-09-24 18:12:31 EDT

Pushed also to R4_7_maintenance for 4.7.1a via http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?h=R4_7_maintenance&id=b65ba779d36829e7819a98e31bdb3bb5bd6ed09d