Community
Participate
Working Groups
JUnit 5 was released on Sep 10 http://junit.org/junit5/docs/current/user-guide/#release-notes-5.0.0 and eclipse JDT/UI has added suppport for it in Oxygen and Photon https://wiki.eclipse.org/JDT_UI/JUnit_5 we depend on surefire to implement support for JUnit5 https://issues.apache.org/jira/browse/SUREFIRE-1330 As soon as JUnit 5 support in surefire is available, tycho-surefire should adopt it. Looks like several PRs are already in. Not sure what the current state is but it may make sense to start looking into this so we can get an idea how much work is expected on the Tycho side. Looks like we need to use the junit5 branch for now https://github.com/apache/maven-surefire/commits/junit5
some docs: http://junit.org/junit5/docs/current/user-guide/ and in particular https://github.com/junit-team/junit5-samples/tree/r5.0.2/junit5-maven-consumer Photon M4 provides several JUnit 5 bundles http://download.eclipse.org/eclipse/updates/4.8milestones/S-4.8M4-201712062000/plugins/?d
Because the sample project https://github.com/junit-team/junit5-samples/tree/r5.0.2/junit5-maven-consumer uses surefire 2.19.1, I believe fixing bug 495353 is a prerequisite before we can start working on JUnit 5 support I just proposed a new patchset for bug 495353 to see if we can update surefire to 2.19.1
I created a piggyback CQ for using JUnit5 artifacts in Tycho: CQ 15263
(In reply to Martin Schreiber from comment #3) > I created a piggyback CQ for using JUnit5 artifacts in Tycho: CQ 15263 https://dev.eclipse.org/ipzilla/show_bug.cgi?id=15263
depending on how we implement this, we will probably also need CQs for new surefire artifacts like https://github.com/junit-team/junit5-samples/blob/8613a50163f6fddb041c425a8a7d9971065978d2/junit5-maven-consumer/pom.xml#L51-L55
(In reply to Jan Sievers from comment #5) > depending on how we implement this, we will probably also need CQs for new > surefire artifacts like > https://github.com/junit-team/junit5-samples/blob/ > 8613a50163f6fddb041c425a8a7d9971065978d2/junit5-maven-consumer/pom.xml#L51- > L55 IHMO the surefire-provider is also included in the original CQ: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=13321 But to be sure I asked in our CQ if it's included.
Draft: https://git.eclipse.org/r/#/c/114532/
New Gerrit change created: https://git.eclipse.org/r/120281
New Gerrit change created: https://git.eclipse.org/r/120440
Gerrit change https://git.eclipse.org/r/120440 was merged to [master]. Commit: http://git.eclipse.org/c/tycho/org.eclipse.tycho.git/commit/?id=1b92727667187d880b64f0d06fb4416c47b5cce2
according to http://download.eclipse.org/tools/orbit/downloads/drops/R20180206163158/ junit-platform-launcher junit-platform-engine junit-platform-commons junit-jupiter-engine junit-vintage-engine opentest4j are covered by CQ 13321 for which I created a piggy-back CQ only CQ left to create is for junit-platform-surefire-provider
(In reply to Jan Sievers from comment #11) > only CQ left to create is for junit-platform-surefire-provider https://dev.eclipse.org/ipzilla/show_bug.cgi?id=16028
It seems that Junit5 launcher is not being added to Gradle projects: https://github.com/eclipse/buildship/issues/668#issuecomment-378133705
(In reply to Kamil from comment #13) > It seems that Junit5 launcher is not being added to Gradle projects: > https://github.com/eclipse/buildship/issues/668#issuecomment-378133705 I don't think this issue is directly related to JUnit 5 support in tycho (as opposed to JUnit 5 support in eclipse). For the record though, the proposal https://git.eclipse.org/r/120281 brings all libs required to run Junit 5 (and JUnit 4) tests: junit-platform-surefire-provider junit-platform-launcher junit-platform-engine junit-platform-commons junit-jupiter-engine junit-vintage-engine opentest4j out of the box, that means there is no need for the test project to directly require any of these libs. Only junit-jupiter-api is directly required by the test project. From what I understand these libs should be independent of junit-jupiter-api so you could even use a newer version of junit-jupiter-api with the same (older) engine version. For now we are using version 5.0/platform 1.0 as this is what is also currently shipped with eclipse. Still need to check though what happens if we use e.g. junit-jupiter-api 5.1 with unchanged engine version 5.0
New Gerrit change created: https://git.eclipse.org/r/120857
Gerrit change https://git.eclipse.org/r/120281 was merged to [master]. Commit: http://git.eclipse.org/c/tycho/org.eclipse.tycho.git/commit/?id=065ce8f0f5c4c344fc914a8eb18eae0353ead620
Jan Sievers, sorry, I focused on "support for JUnit 5" and missed the "Product" label. Please tell me, since this commit is on master now ( http://git.eclipse.org/c/tycho/org.eclipse.tycho.git/commit/?id=065ce8f0f5c4c344fc914a8eb18eae0353ead620 ) Does this affect JUnit 5 support in Eclipse as well, or I should fill separate issue?
(In reply to Kamil from comment #17) > Jan Sievers, sorry, I focused on "support for JUnit 5" and missed the > "Product" label. > Please tell me, since this commit is on master now ( > http://git.eclipse.org/c/tycho/org.eclipse.tycho.git/commit/ > ?id=065ce8f0f5c4c344fc914a8eb18eae0353ead620 ) > Does this affect JUnit 5 support in Eclipse as well, or I should fill > separate issue? support for JUnit 5 in eclipse is a separate thing. Probably best filed under jdt.ui
(In reply to Jan Sievers from comment #18) > support for JUnit 5 in eclipse is a separate thing. Probably best filed > under jdt.ui Eclipse 4.7 already supports JUnit 5. See https://www.eclipse.org/community/eclipse_newsletter/2017/october/article5.php
(In reply to Lars Vogel from comment #19) > (In reply to Jan Sievers from comment #18) > > support for JUnit 5 in eclipse is a separate thing. Probably best filed > > under jdt.ui > > Eclipse 4.7 already supports JUnit 5. See > https://www.eclipse.org/community/eclipse_newsletter/2017/october/article5.php > You need at least 4.7.1a. Best is to use 4.7.3.
Guys, I'm using 4.7.3 and as I've written in my comment: > It seems that Junit5 launcher is not being added to Gradle projects: https://github.com/eclipse/buildship/issues/668#issuecomment-378133705 Then Jan answered: > For the record though, the proposal https://git.eclipse.org/r/120281 brings all libs required to run Junit 5 (and JUnit 4) tests so my question is: does this commit affects Eclipse IDE as well, or only Tycho?
(In reply to Kamil from comment #21) > so my question is: does this commit affects Eclipse IDE as well, or only > Tycho? the commit http://git.eclipse.org/c/tycho/org.eclipse.tycho.git/commit?id=065ce8f0f5c4c344fc914a8eb18eae0353ead620 only affects Tycho
Gerrit change https://git.eclipse.org/r/120857 was merged to [master]. Commit: http://git.eclipse.org/c/tycho/org.eclipse.tycho.git/commit/?id=d7ef4d966feef95d30763ce7593f1ecafedd9f64
New Gerrit change created: https://git.eclipse.org/r/121775
Gerrit change https://git.eclipse.org/r/121775 was merged to [master]. Commit: http://git.eclipse.org/c/tycho/org.eclipse.tycho.git/commit/?id=d9ce75d316caae823be78527b7b690182b602895
