Description Pierre-Charles David 2017-08-18 05:08:15 EDT

I have a PageProvider which provides:

* A single overview page O, which is configured to REPLACE the default page:

    @Override
    public Optional<String> getLocationId() {
        return Optional.of(DefaultSessionEditorPage.PAGE_ID);
    }

    @Override
    public Optional<PositioningKind> getPositioning() {
        return Optional.of(PositioningKind.REPLACE);
    }

* Multiple additional pages P1 to Pn, each with a unique id, but which are all configured to be AFTER "O", with no specific constraint on their own relative ordering. In other words, all of P1 to Pn have:

    @Override
    public Optional<String> getLocationId() {
        return Optional.of(OVERVIEW_ID);
    }

    @Override
    public Optional<PositioningKind> getPositioning() {
        return Optional.of(PositioningKind.AFTER);
    }

Expected result: an editor with the Overview page in first position, and then all of P1 to Pn after, in no particular order.

Actual result: I get the Overview page, which correctly replaces the default one, but then only one of P1 to Pn is visible.

If I change the overview page to be PositioningKind.AFTER the default one instead of replacing it, the result is correct. Looking at the code, the problem seems to be in oes.ui.editor.internal.pages.PageOrderer.linkAllPageRoot(List<PagePositioning>, Set<PagePositioning>). Before it is called from getOrderedPages, pagePositioningElements correctly references all the pages (default, O, P1 to Pn), but after the call, the resulting newPageOrdered only contains O and one of the Px pages.