Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 520200 - Create Windows Slave to build native libraries @ eclipse.org infra
Summary: Create Windows Slave to build native libraries @ eclipse.org infra
Status: RESOLVED FIXED
Alias: None
Product: Community
Classification: Eclipse Foundation
Component: CI-Jenkins (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 2017-Q3   Edit
Assignee: CI Admin Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 521927 525392
Blocks: 476642
  Show dependency tree
 
Reported: 2017-07-26 05:32 EDT by Lakshmi P Shanmugam CLA
Modified: 2017-12-04 03:30 EST (History)
8 users (show)

See Also:


Attachments
win32.x86_64 DLLs built with VS C++ Express 2008 (226.26 KB, application/zip)
2017-08-04 09:23 EDT, Mikaël Barbero CLA
no flags Details
MICROSOFT SOFTWARE LICENSE TERMS - MICROSOFT VISUAL C++ 2008 EXPRESS EDITION, SERVICE PACK 1 (12.92 KB, text/plain)
2017-08-21 11:57 EDT, Mikaël Barbero CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Lakshmi P Shanmugam CLA 2017-07-26 05:32:20 EDT
We need a Windows slave to start building Windows SWT native libraries @ Eclipse Foundation.

Configuration:
Windows 7
Hard disk - 200GB
RAM - minimum 4GB

Software/SDK to be used:
Windows SDK and Visual Studio 
MSDN license to use Visual Studio

We are creating a wiki page with the details of required SDK & software versions and steps to create the build setup. I'll post the link here, once it is ready.
Comment 1 Eclipse Webmaster CLA 2017-07-26 10:10:35 EDT
There is already a windows slave in our build env, Is there a reason you can't use it?

-M.
Comment 2 Dani Megert CLA 2017-07-27 04:16:38 EDT
(In reply to Eclipse Webmaster from comment #1)
> There is already a windows slave in our build env, Is there a reason you
> can't use it?
> 
> -M.

Is the software mentioned in comment 0 installed?
Comment 3 Lakshmi P Shanmugam CLA 2017-07-27 04:59:16 EDT
(In reply to Eclipse Webmaster from comment #1)
> There is already a windows slave in our build env, Is there a reason you
> can't use it?
> 
> -M.

I don't know the configuration details of the Windows slave. We can use it, if it matches the required configuration.
Comment 4 Niraj Modi CLA 2017-07-28 05:05:10 EDT
Hi Mikaël,
Eclipse Foundation would need below license in order to setup the Windows native build setups:
- "MSDN Developer license"
Comment 5 Mikaël Barbero CLA 2017-07-31 06:26:51 EDT
Lakshmi, Niraj,

Let me know when the wiki page is created. Please make sure to provide the exact information (titles and versions) about the SDK/tools. I will need to check the license requirements for each. 

Thanks.
Comment 6 Niraj Modi CLA 2017-08-01 10:21:11 EDT
(In reply to Mikaël Barbero from comment #5)
> Lakshmi, Niraj,
> 
> Let me know when the wiki page is created. Please make sure to provide the
> exact information (titles and versions) about the SDK/tools. I will need to
> check the license requirements for each. 
> 
> Thanks.

Hi Mikaël,
Please find the wiki page, which list the required SDK/tools needed.
Also the lists the steps to setup Windows native build on below wiki:
https://www.eclipse.org/swt/swt_win_native.php
Comment 7 Mikaël Barbero CLA 2017-08-04 09:23:31 EDT
Created attachment 269688 [details]
win32.x86_64 DLLs built with VS C++ Express 2008

Thanks for the documentation.

I've managed to setup a private build environment. I've tried to use only software which do not require MSDN license and I think I've been successful with it. 

AFAICT, "Windows Server 2003 SP1 Platform SDK" (https://www.microsoft.com/en-us/download/details.aspx?id=12261) does not require it.

You were mentioning that "Visual Studio 2008" was required to build SWT (which require a MSDN license), but I tried instead with "Visual Studio C++ Express 2008" (https://go.microsoft.com/?linkid=7729279 which does not require MSDN license), and I've seen no errors. 

I've only built x64 versions of DLLs (attached to this bug - tag 4810a). Could you please try out these DLLs and check whether they are correct? If so, I can update the Windows slave shortly so that you can start to build SWT Windows fragment very soon.

(On a side note, you are mentioning Webkit SDK version 'r72896', it would be good to give clue how to get it. I've been only able to clone the 5Gb git://git.webkit.org/WebKit.git but without any tag or branch, I don't which commit r72896 correspond to. A link to https://developer.apple.com/opensource/internet/webkit_sptlib_agree.html for the WebKit Support Library would be helpful as well. Finally, I did not need Cygwin.)
Comment 8 Niraj Modi CLA 2017-08-08 06:30:31 EDT
(In reply to Mikaël Barbero from comment #7)
> Created attachment 269688 [details]
> win32.x86_64 DLLs built with VS C++ Express 2008
> 
> Thanks for the documentation.
> 
> I've managed to setup a private build environment. I've tried to use only
> software which do not require MSDN license and I think I've been successful
> with it. 
Yes, definitely a good start :)
Can you also give a try the swt_windows 32bit build as well ?

> AFAICT, "Windows Server 2003 SP1 Platform SDK"
> (https://www.microsoft.com/en-us/download/details.aspx?id=12261) does not
> require it.
Ok, we should be good on this, since Windows SDKs doesn't mandate MSDN license.

> You were mentioning that "Visual Studio 2008" was required to build SWT
> (which require a MSDN license), but I tried instead with "Visual Studio C++
> Express 2008" (https://go.microsoft.com/?linkid=7729279 which does not
> require MSDN license), and I've seen no errors. 
To confirm if we "Visual Studio C++ Express 2008" can be used, IMO at-least below items need to be investigated:
1. Technical side of things to evaluate if it doesn't break anything or impose any limitation in SWT/Eclipse.
2. In parallel we also need to evaluate the Legal side of things:
- Can commercial products be shipped which are built using "Visual Studio C++ Express 2008" ?
- Can you please seek an opinion from Eclipse Foundation legal team, if they are OK with this change.

> I've only built x64 versions of DLLs (attached to this bug - tag 4810a).
> Could you please try out these DLLs and check whether they are correct? If
> so, I can update the Windows slave shortly so that you can start to build
> SWT Windows fragment very soon.
I did some testing specifically around use-cases for main swt windows DLL, which seems to be working fine till now (Will keep you posted if I face any issue in my further testing)

> (On a side note, you are mentioning Webkit SDK version 'r72896', it would be
> good to give clue how to get it. I've been only able to clone the 5Gb
> git://git.webkit.org/WebKit.git but without any tag or branch, I don't which
> commit r72896 correspond to. A link to
> https://developer.apple.com/opensource/internet/webkit_sptlib_agree.html for
> the WebKit Support Library would be helpful as well. Finally, I did not need
> Cygwin.)
Yes, it looks like Web-kit SDK tools were built from of the web-kit sources.
If license permits, Is it allowed for you to copy the web-kit SDK directly from the Windows build machine ? Again it would be a good point to seek an opinion from Eclipse Foundation legal team.

Hopefully we should be ok reusing the Web-kit SDK that we already have, or else it would have to be rebuild it from Web-kit SDK sources, found below set of steps to build web-kit SDK binaries: https://webkit.org/webkit-on-windows/#installing-developer-tools
Comment 9 Mikaël Barbero CLA 2017-08-21 11:57:13 EDT
Created attachment 269919 [details]
MICROSOFT SOFTWARE LICENSE TERMS - MICROSOFT VISUAL C++ 2008 EXPRESS EDITION, SERVICE PACK 1

(In reply to Niraj Modi from comment #8)
> Yes, definitely a good start :)
> Can you also give a try the swt_windows 32bit build as well ?

It is on my todo list for this week.

 > > You were mentioning that "Visual Studio 2008" was required to build SWT
> > (which require a MSDN license), but I tried instead with "Visual Studio C++
> > Express 2008" (https://go.microsoft.com/?linkid=7729279 which does not
> > require MSDN license), and I've seen no errors. 
> To confirm if we "Visual Studio C++ Express 2008" can be used, IMO at-least
> below items need to be investigated:
> 1. Technical side of things to evaluate if it doesn't break anything or
> impose any limitation in SWT/Eclipse.

I'll leave that to your team :) Btw, VS 2008 is VS 9.0 and not VS 8.0 (I suppose you've installed it at the same location as VS 2005 which was v8.0 but did not change the path in build scripts at that time ;)).

> 2. In parallel we also need to evaluate the Legal side of things:
> - Can commercial products be shipped which are built using "Visual Studio
> C++ Express 2008" ?

Being an old product, it's quite hard to find a definitive answer. Here is my best finding on this topic (from http://web.archive.org/web/20081210012126/http://www.microsoft.com/express/support/faq/)

Q. Can I use Express Editions for commercial use?

Yes, there are no licensing restrictions for applications built using Visual Studio Express Editions.

> - Can you please seek an opinion from Eclipse Foundation legal team, if they
> are OK with this change.

I'm attaching the license agreement from VS C++ Express 2008. Cc'ing Mike for legal check.

IMO, part 1 is pretty clear:

1. INSTALLATION AND USE RIGHTS.  
  a. Installation and Use.  One user may install and use any number of copies of the software on your devices to design, develop and test your programs.
  b. Included Microsoft Programs.  The software contains other Microsoft programs.  These license terms apply to your use of those programs.

> I did some testing specifically around use-cases for main swt windows DLL,
> which seems to be working fine till now (Will keep you posted if I face any
> issue in my further testing)

Did you find any issue?

> > (On a side note, you are mentioning Webkit SDK version 'r72896', it would be
> > good to give clue how to get it. I've been only able to clone the 5Gb
> > git://git.webkit.org/WebKit.git but without any tag or branch, I don't which
> > commit r72896 correspond to. A link to
> > https://developer.apple.com/opensource/internet/webkit_sptlib_agree.html for
> > the WebKit Support Library would be helpful as well. Finally, I did not need
> > Cygwin.)
> Yes, it looks like Web-kit SDK tools were built from of the web-kit sources.
> If license permits, Is it allowed for you to copy the web-kit SDK directly
> from the Windows build machine ? Again it would be a good point to seek an
> opinion from Eclipse Foundation legal team.
> 
> Hopefully we should be ok reusing the Web-kit SDK that we already have, or
> else it would have to be rebuild it from Web-kit SDK sources, found below
> set of steps to build web-kit SDK binaries:
> https://webkit.org/webkit-on-windows/#installing-developer-tools

I'm not sure to understand. Is "WebKit Support Library" a build version of the "Webkit SDK"? From your documentation (https://www.eclipse.org/swt/swt_win_native.php), it seems that both are required, and thus different. I did not build what I got from git://git.webkit.org/WebKit.git and the swt build did not fail. Moreover, I did not find any other resource than https://developer.apple.com/opensource/internet/webkit_sptlib_agree.html under the name "WebKit Support Library" that you seem to require. Could you please describe a bit more these parts please?

From my understanding, you require the revision "r72896" of sources of "Webkit SDK" at git://git.webkit.org/WebKit.git and the "WebKit Support Library" downloadable from https://developer.apple.com/opensource/internet/webkit_sptlib_agree.html. AFAICT, no build of Webkit is required.
Comment 10 Niraj Modi CLA 2017-09-08 06:12:22 EDT
(In reply to Mikaël Barbero from comment #9)
> Created attachment 269919 [details]
> MICROSOFT SOFTWARE LICENSE TERMS - MICROSOFT VISUAL C++ 2008 EXPRESS
> EDITION, SERVICE PACK 1
> 
> (In reply to Niraj Modi from comment #8)
> > Yes, definitely a good start :)
> > Can you also give a try the swt_windows 32bit build as well ?
> 
> It is on my todo list for this week.
> 
>  > > You were mentioning that "Visual Studio 2008" was required to build SWT
> > > (which require a MSDN license), but I tried instead with "Visual Studio C++
> > > Express 2008" (https://go.microsoft.com/?linkid=7729279 which does not
> > > require MSDN license), and I've seen no errors. 
> > To confirm if we "Visual Studio C++ Express 2008" can be used, IMO at-least
> > below items need to be investigated:
> > 1. Technical side of things to evaluate if it doesn't break anything or
> > impose any limitation in SWT/Eclipse.
> 
> I'll leave that to your team :) Btw, VS 2008 is VS 9.0 and not VS 8.0 (I
> suppose you've installed it at the same location as VS 2005 which was v8.0
> but did not change the path in build scripts at that time ;)).

Hi Mikaël,
Investigated the technical side of things regarding usage of "Visual Studio C++ Express 2008" instead of "Visual Studio 2008" via bug 521927.
Below Eclipse I-Build is built using "Visual Studio C++ Express 2008" for windows native builds(both 32bit and 64bit builds):
http://download.eclipse.org/eclipse/downloads/drops4/I20170906-2000/ 

Also the Windows JUnits tests ran successfully:
http://download.eclipse.org/eclipse/downloads/drops4/I20170906-2000/testResults.php

So, technically we are good with moving to "Visual Studio C++ Express 2008" for SWT windows native builds.

So, once we have legal side of things verified/approved for "Visual Studio C++ Express 2008" by Eclipse Foundation, we can plan a move to "Visual Studio C++ Express 2008". Thanks!
Comment 11 Mikaël Barbero CLA 2017-09-08 11:20:17 EDT
(In reply to Niraj Modi from comment #10)
> So, technically we are good with moving to "Visual Studio C++ Express 2008"
> for SWT windows native builds.

Terrific! Thanks for the investigation.

> So, once we have legal side of things verified/approved for "Visual Studio
> C++ Express 2008" by Eclipse Foundation, we can plan a move to "Visual
> Studio C++ Express 2008". Thanks!

I got clearance from the Foundation's legal team. I will install the environment as described in https://www.eclipse.org/swt/swt_win_native.php. I plan to do it sometime next week (the mac issues are still top priority to prevent any delaying of the Oxygen.1 release).

In the meantime, could you please provide more details about WebKit, especially my questions from comment #9.
Comment 12 Niraj Modi CLA 2017-09-11 07:39:55 EDT
(In reply to Mikaël Barbero from comment #9)
> I'm not sure to understand. Is "WebKit Support Library" a build version of
> the "Webkit SDK"? From your documentation
> (https://www.eclipse.org/swt/swt_win_native.php), it seems that both are
> required, and thus different. I did not build what I got from
> git://git.webkit.org/WebKit.git and the swt build did not fail. Moreover, I
> did not find any other resource than
> https://developer.apple.com/opensource/internet/webkit_sptlib_agree.html
> under the name "WebKit Support Library" that you seem to require. Could you
> please describe a bit more these parts please?
> 
> From my understanding, you require the revision "r72896" of sources of
> "Webkit SDK" at git://git.webkit.org/WebKit.git and the "WebKit Support
> Library" downloadable from
> https://developer.apple.com/opensource/internet/webkit_sptlib_agree.html.
> AFAICT, no build of Webkit is required.
Hi Mikaël,
As you mentioned that SWT 64bit native build worked for you without need for Webkit libraries. Reason being, Webkit is supported only 32bit and not 64bit.

Can you try the SWT 32bit native build, it should fail to build swt-webkit-win32-<version>.dll ?
 
For building SWT Webkit libraries(32bit), you need both of below directories:
1. <webkit>\WebKitSupportLibrary
Download link: https://developer.apple.com/opensource/internet/webkit_sptlib_agree.html
2. <webkit>\WebKit-r72896
We don't have the public download link handy for this, ideally 'r72896' should have been present on https://webkit.org/downloads/, but we don't see any Windows archive site for the same.
Comment 13 Niraj Modi CLA 2017-09-22 03:19:43 EDT
Hi Mikaël,
As discussed regarding Webkit SDK, we will be sharing both the Windows Webkit SDKs(which are an older version being consumed by SWT and  are no more available for download on public Webkit download page: https://webkit.org/downloads/)

Will be updating the Windows SWT native build setup page, shortly:
https://www.eclipse.org/swt/swt_win_native.php
Comment 14 Eclipse Genie CLA 2017-09-22 03:35:39 EDT
New Gerrit change created: https://git.eclipse.org/r/105594
Comment 15 Niraj Modi CLA 2017-09-22 07:07:08 EDT
(In reply to Niraj Modi from comment #8)
> (In reply to Mikaël Barbero from comment #7)
> > (On a side note, you are mentioning Webkit SDK version 'r72896', it would be
> > good to give clue how to get it. I've been only able to clone the 5Gb
> > git://git.webkit.org/WebKit.git but without any tag or branch, I don't which
> > commit r72896 correspond to. A link to
> > https://developer.apple.com/opensource/internet/webkit_sptlib_agree.html for
> > the WebKit Support Library would be helpful as well. Finally, I did not need
> > Cygwin.)
> Yes, it looks like Web-kit SDK tools were built from of the web-kit sources.
> If license permits, Is it allowed for you to copy the web-kit SDK directly
> from the Windows build machine ? Again it would be a good point to seek an
> opinion from Eclipse Foundation legal team.

Hi Mikaël,
Before we could put webkit SDKs on public(Eclipse SWT wiki/download page), did you got a confirmation from Eclipse Foundation Legal/IP team, regarding sharing for these Webkit SDKs ?
Sharing the webkit license link which I have:
https://webkit.org/licensing-webkit/

Also note, we are using WebKit SDK version '72896' in SWT native build process.
Tried searching for this version on https://archive.org/web/, nearest I could find a reference is '72866' version listed on below link:
https://web.archive.org/web/20110928082937/http://nightly.webkit.org:80/builds/trunk/win/12
Comment 16 Mikaël Barbero CLA 2017-09-22 09:11:34 EDT
(In reply to Niraj Modi from comment #15)
> Before we could put webkit SDKs on public(Eclipse SWT wiki/download page),
> did you got a confirmation from Eclipse Foundation Legal/IP team, regarding
> sharing for these Webkit SDKs ?
> Sharing the webkit license link which I have:
> https://webkit.org/licensing-webkit/

Yep, no problem to host it. See my comments on your gerrit patchset.

> Also note, we are using WebKit SDK version '72896' in SWT native build
> process.
> Tried searching for this version on https://archive.org/web/, nearest I
> could find a reference is '72866' version listed on below link:
> https://web.archive.org/web/20110928082937/http://nightly.webkit.org:80/
> builds/trunk/win/12

Great. Could you add this link to the Windows SWT native build setup page (via https://git.eclipse.org/r/105594)?

Thanks!
Comment 17 Mikaël Barbero CLA 2017-09-25 12:02:07 EDT
I found the sources of r72896 https://builds-nightly.webkit.org/files/trunk/src/WebKit-r72896.tar.bz2. I will try to build them with instructions on https://webkit.org/webkit-on-windows/
Comment 18 Niraj Modi CLA 2017-09-26 04:12:10 EDT
(In reply to Mikaël Barbero from comment #16)
> (In reply to Niraj Modi from comment #15)
> > Before we could put webkit SDKs on public(Eclipse SWT wiki/download page),
> > did you got a confirmation from Eclipse Foundation Legal/IP team, regarding
> > sharing for these Webkit SDKs ?
> > Sharing the webkit license link which I have:
> > https://webkit.org/licensing-webkit/
> 
> Yep, no problem to host it. See my comments on your gerrit patchset.
Thanks Mikaël for the confirmation on the legal side of things.

(In reply to Mikaël Barbero from comment #17)
> I found the sources of r72896
> https://builds-nightly.webkit.org/files/trunk/src/WebKit-r72896.tar.bz2. I
> will try to build them with instructions on
> https://webkit.org/webkit-on-windows/

Sure, let us know once it works for your.

Sravan suggested below location for Windows webkit build SDKs sharing:
http://build.eclipse.org/eclipse/temp/
Comment 19 Mikaël Barbero CLA 2017-09-26 04:15:27 EDT
(In reply to Niraj Modi from comment #18) 
> Sravan suggested below location for Windows webkit build SDKs sharing:
> http://build.eclipse.org/eclipse/temp/

As I said in the review, I would prefer a more definitive location. The binary will eventually be available to anyone who want to build the SWT Windows fragment on their own machine. There are no issues with hosting GPL-licenses code on our servers. Eventually, links to all tools and frameworks required to build the Windows fragment should be available from the document https://www.eclipse.org/swt/swt_win_native.php
Comment 20 Niraj Modi CLA 2017-09-26 08:19:24 EDT
(In reply to Niraj Modi from comment #18)
> (In reply to Mikaël Barbero from comment #16)
> (In reply to Mikaël Barbero from comment #17)
> > I found the sources of r72896
> > https://builds-nightly.webkit.org/files/trunk/src/WebKit-r72896.tar.bz2. I
> > will try to build them with instructions on
> > https://webkit.org/webkit-on-windows/
> 
> Sure, let us know once it works for your.
Had a discussion regarding this in our team meeting.
Rebuilding the Webkit SDK from sources is not required, for two reasons:
- We don't expect to support Webkit in SWT for long, hence not worth putting time into.
- Latest web-kit build instructions may or may not allow to old sources, approach can be error prone and will require verification(for possible breakages) 

Anyways since it's legally OK to share these Webkit SDKs, lets prefer using these Webkit build SDKs as-is from current build machine.

(In reply to Mikaël Barbero from comment #19)
> (In reply to Niraj Modi from comment #18) 
> > Sravan suggested below location for Windows webkit build SDKs sharing:
> > http://build.eclipse.org/eclipse/temp/
> 
> As I said in the review, I would prefer a more definitive location. The
> binary will eventually be available to anyone who want to build the SWT
> Windows fragment on their own machine. There are no issues with hosting
> GPL-licenses code on our servers. Eventually, links to all tools and
> frameworks required to build the Windows fragment should be available from
> the document https://www.eclipse.org/swt/swt_win_native.php
Sure, we will share at: http://build.eclipse.org/eclipse/swt/ and update the https://www.eclipse.org/swt/swt_win_native.php documentation.
Comment 21 Mikaël Barbero CLA 2017-09-27 09:23:22 EDT
Agreed about wbekit build. IMO, sources of the binary should be made available for the sake of transparency. So please also include a link to https://builds-nightly.webkit.org/files/trunk/src/WebKit-r72896.tar.bz2 (which should be also available from the http://build.eclipse.org/eclipse/swt/ folder as the previous link could go down anytime).

FYI, I've started to setup the build env on the windows machine, just to find that it's a 32 bits setup. So we need to setup a new one with a 64 bits Windows. I'm currently working on it. Will keep you posted.
Comment 22 Niraj Modi CLA 2017-09-28 06:25:25 EDT
(In reply to Mikaël Barbero from comment #21)
> Agreed about wbekit build. IMO, sources of the binary should be made
> available for the sake of transparency. So please also include a link to
> https://builds-nightly.webkit.org/files/trunk/src/WebKit-r72896.tar.bz2
> (which should be also available from the
> http://build.eclipse.org/eclipse/swt/ folder as the previous link could go
> down anytime).
It's doesn't seem necessary to share webkit sources.. but am adding it anyways.

> FYI, I've started to setup the build env on the windows machine, just to
> find that it's a 32 bits setup. So we need to setup a new one with a 64 bits
> Windows. I'm currently working on it. Will keep you posted.
Sure, Thanks!
Comment 24 Eclipse Genie CLA 2017-09-28 12:07:36 EDT
New Gerrit change created: https://git.eclipse.org/r/105956
Comment 25 Eclipse Genie CLA 2017-09-28 12:14:46 EDT
New Gerrit change created: https://git.eclipse.org/r/105957
Comment 26 Mikaël Barbero CLA 2017-09-29 09:36:54 EDT
I've managed to setup the build on a new windows box of ours. See the console log here https://ci.eclipse.org/cbi/job/swt-windows-fragment/28/console 

I will now setup a new slave on the shared instance using this machine and we can start iterating on building SWT on it.
Comment 27 Eclipse Genie CLA 2017-10-02 12:24:40 EDT
New Gerrit change created: https://git.eclipse.org/r/106108
Comment 28 Mikaël Barbero CLA 2017-10-02 16:45:07 EDT
I've setup two jobs on shared hipp:

https://hudson.eclipse.org/shared/job/swt-win32-x86_64/
https://hudson.eclipse.org/shared/job/swt-win32-x86/

x86_64 build is passing, but I'm still struggling with x86. VS C++ 2008 lacks some headers required by WebKitSupportLibrary. I had to add stdint.h, inttypes.h and stdbool.h. Now I still have errors because of missing "dispatch/dispatch.h". I suspect you have special settings for this library. Could you provide more information.

Note that I've opened bug 525392 (with patches) to improve a bit the build scripts and also https://git.eclipse.org/r/106108 to help using the VM I've setup.
Comment 29 Niraj Modi CLA 2017-10-04 09:30:06 EDT
(In reply to Mikaël Barbero from comment #28)
> I've setup two jobs on shared hipp:
> 
> https://hudson.eclipse.org/shared/job/swt-win32-x86_64/
> https://hudson.eclipse.org/shared/job/swt-win32-x86/
> 
> x86_64 build is passing, but I'm still struggling with x86. VS C++ 2008
> lacks some headers required by WebKitSupportLibrary. I had to add stdint.h,
> inttypes.h and stdbool.h. Now I still have errors because of missing
> "dispatch/dispatch.h". I suspect you have special settings for this library.
> Could you provide more information.
No special setting for this library.

Just quickly scanned the console logs for x86, noticed you are using Oracle Java:
https://hudson.eclipse.org/shared/job/swt-win32-x86/10/console

Not sure if it's causing the difference, can you try with IBM Java8 32bit here ?
Comment 30 Mikaël Barbero CLA 2017-10-04 09:33:55 EDT
The error does not come from the linking to Java headers, it's all about the webkit support library requiring C99 headers while VS2008 does not support it. My best guess is that the version of WebKitSupportLibrary that can be downloaded from https://developer.apple.com/opensource/internet/webkit_sptlib_agree.html is different from the one you have on your build server. Could you make a quick diff between the two? Thanks.
Comment 31 Niraj Modi CLA 2017-10-05 05:37:53 EDT
(In reply to Mikaël Barbero from comment #30)
> The error does not come from the linking to Java headers, it's all about the
> webkit support library requiring C99 headers while VS2008 does not support
> it. My best guess is that the version of WebKitSupportLibrary that can be
> downloaded from
> https://developer.apple.com/opensource/internet/webkit_sptlib_agree.html is
> different from the one you have on your build server. Could you make a quick
> diff between the two? Thanks.
Hi Mikaël,
The WebKitSupportLibrary available for downloaded from https://developer.apple.com/opensource/internet/webkit_sptlib_agree.html is latest and corresponds to latest WebKit build SDK, which we don't consume in SWT.
- It's almost double the size of WebKitSupportLibrary that we have.
- Our WebKitSupportLibrary is compatible with WebKit-r72896 version.
- Right WebKitSupportLibrary is shared:
  http://build.eclipse.org/eclipse/swt/WebKitSupportLibrary.zip
- Same link is also specified on the Windows native build setup page:
  https://www.eclipse.org/swt/swt_win_native.php Thanks!
Comment 32 Mikaël Barbero CLA 2017-10-05 10:58:56 EDT
Thanks. Both builds are green. How do you want to proceed next?

https://hudson.eclipse.org/shared/job/swt-win32-x86_64/
https://hudson.eclipse.org/shared/job/swt-win32-x86/
Comment 33 Niraj Modi CLA 2017-10-06 03:57:27 EDT
(In reply to Mikaël Barbero from comment #32)
> Thanks. Both builds are green. How do you want to proceed next?
> 
> https://hudson.eclipse.org/shared/job/swt-win32-x86_64/
> https://hudson.eclipse.org/shared/job/swt-win32-x86/

Great, Thanks!

We are in process of seeking CQ approval for the "Visual C++ 2008 Express" tool, we will get back to you once done with this via below CQ request:
https://dev.eclipse.org/ipzilla/show_bug.cgi?id=14341

BTW, what's the machine configuration of this 64-bits Windows:
- I assume it Win7 OS
- VM or physical machine
- RAM size ?
Comment 34 Mikaël Barbero CLA 2017-10-06 04:08:37 EDT
(In reply to Niraj Modi from comment #33)
> (In reply to Mikaël Barbero from comment #32)
> > Thanks. Both builds are green. How do you want to proceed next?
> > 
> > https://hudson.eclipse.org/shared/job/swt-win32-x86_64/
> > https://hudson.eclipse.org/shared/job/swt-win32-x86/
> 
> Great, Thanks!
> 
> We are in process of seeking CQ approval for the "Visual C++ 2008 Express"
> tool, we will get back to you once done with this via below CQ request:
> https://dev.eclipse.org/ipzilla/show_bug.cgi?id=14341

Ok

> BTW, what's the machine configuration of this 64-bits Windows:
> - I assume it Win7 OS
> - VM or physical machine
> - RAM size ?

It is a VM with 1vCPU (~2.5Ghz), 3.75GB RAM, 50GB disk. It runs Windows Server 2016 (~ Windows 10). It does not run a GUI, so don't expect to be able to run UI tests on this one, this is for headless build only.
Comment 36 Lakshmi P Shanmugam CLA 2017-11-17 05:18:52 EST
Hi Mikael,
Can you please configure the Windows slave to be used from releng HIPP?
Comment 37 Mikaël Barbero CLA 2017-11-17 10:16:01 EST
Done. I've also copied the swt-win32-* jjobs from the shared instance (see https://ci.eclipse.org/releng/view/SWT%20Natives/)
Comment 38 Lakshmi P Shanmugam CLA 2017-11-20 05:13:03 EST
(In reply to Mikaël Barbero from comment #37)
> Done. I've also copied the swt-win32-* jjobs from the shared instance (see
> https://ci.eclipse.org/releng/view/SWT%20Natives/)

Is the slave called - windows or windows-server-2016-1? windows-server-2016-1 seems to be offline.
Comment 39 Mikaël Barbero CLA 2017-11-20 05:40:11 EST
https://ci.eclipse.org/releng/computer/windows-server-2016-1/ is back online. There were issues with file permissions which have been fixed.
Comment 40 Lakshmi P Shanmugam CLA 2017-11-22 07:59:22 EST
We need to run these commands on windows machine:
Either curl or wget
zip, unzip, unix2dos
Can you please install them?
Comment 41 Mikaël Barbero CLA 2017-11-22 14:51:53 EST
(In reply to Lakshmi Shanmugam from comment #40)
> We need to run these commands on windows machine:
> Either curl or wget
> zip, unzip, unix2dos
> Can you please install them?

curl, wget, zip, unzip and unix2dos are installed (via cygwin).
Comment 42 Lakshmi P Shanmugam CLA 2017-12-04 03:30:25 EST
Thanks Mikael. Closing bug as fixed.