Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 518653 - Remote Server Explorer does not reuse SSH session and does not attempt to re-connect on SSH connection failure
Summary: Remote Server Explorer does not reuse SSH session and does not attempt to re-...
Status: CLOSED FIXED
Alias: None
Product: CFT
Classification: ECD
Component: General (show other bugs)
Version: 1.0.3   Edit
Hardware: PC Windows 7
: P3 normal
Target Milestone: 1.1.1   Edit
Assignee: Jonathan West CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-22 13:17 EDT by Jonathan West CLA
Modified: 2017-08-22 16:03 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan West CLA 2017-06-22 13:17:09 EDT
Currently, when acquiring files/file list from a CF app, RSE does not reuse the SSH session, and does not attempt to re-connect on SSH connection failure. 

This is not a regression, rather a limitation of the current implementation of the getFile()/RSE code.

Behind the scenes, CF uses CloudFoundryServerBehaviour.getFile(...) to populate what is shown in the Remote Systems Explorer view.

This ultimately calls DiegoRequestFactory.getFile(...).

The purpose of DRF.getFile(...) is to return either file contents, or a directory listing, using SSH.

However, as per the current implementation of DRF.getFile(...), _every_ call causes a new SSH connection to be opened. Which is to say, there is no SSH connection reuse, and each invocation does the equivalent to: cf ssh-code, then, cf ssh (app_name). This takes about 5 seconds, and intermittently fails on Bluemix between 5-10% of the time (due to being unable to establish SSH connection).

Solution would be one or both of the following:
- Reuse SSH session between calls
- Attempt to re-establish SSH connection on initial connection failure.
Comment 1 Eclipse Genie CLA 2017-08-17 12:49:05 EDT
GitHub Pull Request 68 created by [jgwest]
https://github.com/eclipse/cft/pull/68
Comment 2 Jonathan West CLA 2017-08-22 16:03:21 EDT
Verified as fixed in latest driver.