This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 517659 - com.google.javascript and com.google.guava plugins not added to org.eclipse.wst.jsdt.feature
Summary: com.google.javascript and com.google.guava plugins not added to org.eclipse.w...
Status: RESOLVED FIXED
Alias: None
Product: JSDT
Classification: WebTools
Component: General (show other bugs)
Version: unspecified   Edit
Hardware: PC All
: P3 major (vote)
Target Milestone: 3.9 RC3   Edit
Assignee: Victor Rubezhny CLA
QA Contact: Victor Rubezhny CLA
URL:
Whiteboard: RHT PMC_Approved
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-01 13:45 EDT by Kit Lo CLA
Modified: 2017-06-08 15:43 EDT (History)
7 users (show)

See Also:
vrubezhny: pmc_approved? (david_williams)
vrubezhny: pmc_approved? (raghunathan.srinivasan)
vrubezhny: pmc_approved? (naci.dai)
vrubezhny: pmc_approved? (neil.hauge)
cbridgha: pmc_approved+
ccc: pmc_approved+
vrubezhny: pmc_approved+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kit Lo CLA 2017-06-01 13:45:27 EDT 
com.google.javascript and com.google.guava plugins are required by org.eclipse.wst.jsdt.core plugin but not added to org.eclipse.wst.jsdt.feature.

The unsatisfied p2 requirements result in p2 install error. This should be fixed in WTP 3.9.0.
Comment 1 Eclipse Genie CLA 2017-06-01 15:39:28 EDT 
New Gerrit change created: https://git.eclipse.org/r/98469
Comment 2 Victor Rubezhny CLA 2017-06-01 17:07:52 EDT 
Requesting PMC approval in order to to add the required plug-ins to org.eclipse.wst.jsdt.feature. 
See: https://git.eclipse.org/r/98469

* Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug"
(requested by an adopter) please document it as such.

This is necessary to reference the required dependencies to satisfy p2 requirements during the installation.

* Is there a work-around? If so, why do you believe the work-around is
insufficient?

No work-around.

* How has the fix been tested? Is there a test case attached to the bugzilla
record? Has a JUnit Test been added?

The contribution is tested manually (by running the maven build and executing the existing JUnit tests). 

* Give a brief technical overview. Who has reviewed this fix?

The contribution adds the references to com.google.guava and com.google.javascript to org.eclipse.wst.jsdt.feature, thus 
making it to satisfy p2 requirements during the installation process.

* What is the risk associated with this fix?

Very low or no risk at all as the plug-ins are really required and used by JSDT Core.
Comment 3 Chuck Bridgham CLA 2017-06-08 14:12:41 EDT 
Looks good