Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 517437 - Bug during edge label location computation
Summary: Bug during edge label location computation
Status: CLOSED FIXED
Alias: None
Product: Sirius
Classification: Modeling
Component: Diagram (show other bugs)
Version: 3.1.0   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: 4.1.6   Edit
Assignee: Laurent Redor CLA
QA Contact: Guillaume Doux CLA
URL:
Whiteboard:
Keywords:
Depends on: 518073 518441 518871
Blocks: 518440 518870
  Show dependency tree
 
Reported: 2017-05-30 09:58 EDT by Laurent Redor CLA
Modified: 2017-07-07 07:25 EDT (History)
1 user (show)

See Also:


Attachments
edgeLabelsMoveTest.zip (69.20 KB, application/x-zip-compressed)
2017-05-30 09:58 EDT, Laurent Redor CLA
no flags Details
Diagram with invisible labels very far from their edges.png (14.31 KB, image/png)
2017-05-30 09:59 EDT, Laurent Redor CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Laurent Redor CLA 2017-05-30 09:58:10 EDT
Created attachment 268636 [details]
edgeLabelsMoveTest.zip

Since bug 465328, there are some labels computation problems. When moving an edge the label is sometimes moved very far from its edge. Currently 2 scenarios have been identified. The label is potentially not visible but the diagram has strange scrollbar without any visible reason.

I completed the extisting data for automatic tests of 465328 for the below scenarios.

Scenario 1:
* Import project "edgeLabelsMoveTest" from "edgeLabelsMoveTest.zip"
* Open the diagram "DiagramWithSmallObliqueEdge"
* Move class "L" to the bottom right corner of the diagram
* KO: The center label of the edge, "toMCenter", is moved around {-5700, -1900}; far from its edge.

Scenario 2:
* Import project "edgeLabelsMoveTest" from "edgeLabelsMoveTest.zip"
* Open the diagram "DiagWithNodeAndTreeLayout"
* Set the zoom level to 25% (to see all green logical functions)
* Select all the green logical functions
* Move them under the blue logical functions (you can you the scroll mouse to zoom out, to facilitate the move)
* Everything is OK.
* Open the diagram "DiagWithNodeAndTreeLayoutAndIconOnEdgeLabel"
* Set the zoom level to 25% (to see all green logical functions)
* Select all the green logical functions
* Move them under the blue logical functions (you can you the scroll mouse to zoom out, to facilitate the move)
* KO: A big horizontal scroll appears. This reveals that some edge labels, not visible in this kind of diagram, have "big" coordinates.
Comment 1 Laurent Redor CLA 2017-05-30 09:59:11 EDT
Created attachment 268637 [details]
Diagram with invisible labels very far from their edges.png
Comment 2 Laurent Redor CLA 2017-05-30 10:02:26 EDT
For this bugzilla:
* A fix must be added to avoid the computation problem
* A migration participant must be added to fix the corrupted diagram.
Comment 3 Eclipse Genie CLA 2017-06-09 17:00:59 EDT
New Gerrit change created: https://git.eclipse.org/r/99052
Comment 4 Eclipse Genie CLA 2017-06-09 17:01:00 EDT
New Gerrit change created: https://git.eclipse.org/r/99053
Comment 5 Eclipse Genie CLA 2017-06-09 17:01:14 EDT
New Gerrit change created: https://git.eclipse.org/r/99056
Comment 6 Eclipse Genie CLA 2017-06-09 17:01:15 EDT
New Gerrit change created: https://git.eclipse.org/r/99051
Comment 7 Eclipse Genie CLA 2017-06-12 11:49:46 EDT
New Gerrit change created: https://git.eclipse.org/r/99153
Comment 13 Eclipse Genie CLA 2017-06-20 05:46:03 EDT
New Gerrit change created: https://git.eclipse.org/r/99645
Comment 15 Laurent Redor CLA 2017-06-26 09:13:07 EDT
This bug can cause other problems concerning layout of diagram. Indeed, the very huge coordinates of label can lead to computing error caused by limit (MIN or MAX) of INTEGER that is reached.
The migration participant must at least moved the corrupted nodes to a more readable layout.
Comment 16 Eclipse Genie CLA 2017-06-26 09:47:46 EDT
New Gerrit change created: https://git.eclipse.org/r/100049
Comment 18 Guillaume Doux CLA 2017-06-30 10:21:13 EDT
Validated with Sirius 4.1.6-S20170628-064814
Comment 19 Pierre-Charles David CLA 2017-07-07 07:25:18 EDT
Available in Sirius 4.1.6, see https://wiki.eclipse.org/Sirius/4.1.6 for details.