Community
Participate
Working Groups
JDT bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=488566 CQ for JDT project: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=12549 Orbit CQ: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=13321
New Gerrit change created: https://git.eclipse.org/r/97765
(In reply to Eclipse Genie from comment #1) > New Gerrit change created: https://git.eclipse.org/r/97765 This adds JUnit 5.0.0-M4 bundles to Orbit. I have followed the steps from https://wiki.eclipse.org/Orbit/Adding_Bundles_To_Orbit_In_5_Minutes. No changes are made to osgi.bnd files yet. I have tested the binary bundles generated by the local build and they work fine. Please let me know if further changes are required.
Any update on this?
Gerrit change https://git.eclipse.org/r/97765 was merged to [master]. Commit: http://git.eclipse.org/c/orbit/orbit-recipes.git/commit/?id=d805e096318181f85e8c6cecb26f52e198652527
(In reply to Eclipse Genie from comment #4) > Gerrit change https://git.eclipse.org/r/97765 was merged to [master]. > Commit: > http://git.eclipse.org/c/orbit/orbit-recipes.git/commit/?id=d805e096318181f85e8c6cecb26f52e198652527 > Thanks, Roland. I have tested the JUnit 5 M4 JARs from http://download.eclipse.org/tools/orbit/N-builds/N20170609191750/ and they look good.
New Gerrit change created: https://git.eclipse.org/r/100747
(In reply to Eclipse Genie from comment #6) > New Gerrit change created: https://git.eclipse.org/r/100747 The JUnit 5 team released Milestone 5 on July 4, 2017. This Gerrit requests the addition of JUnit 5.0.0-M5 bundles to Orbit.
Gerrit change https://git.eclipse.org/r/100747 was merged to [master]. Commit: http://git.eclipse.org/c/orbit/orbit-recipes.git/commit/?id=0feebe6344b14ecdec0de2abc058f59ee676a260
(In reply to Eclipse Genie from comment #8) > Gerrit change https://git.eclipse.org/r/100747 was merged to [master]. > Commit: > http://git.eclipse.org/c/orbit/orbit-recipes.git/commit/?id=0feebe6344b14ecdec0de2abc058f59ee676a260 > Thanks, Roland. I have tested the JUnit 5.0.0-M5 JARs from the build and they look good.
New Gerrit change created: https://git.eclipse.org/r/101507
(In reply to Eclipse Genie from comment #10) > New Gerrit change created: https://git.eclipse.org/r/101507 JUnit 5.0.0-M6 has been released on July 18, 2017. This Gerrit requests the addition of JUnit 5.0.0-M6 bundles to Orbit after the CQs are updated and approved.
Gerrit change https://git.eclipse.org/r/101507 was merged to [master]. Commit: http://git.eclipse.org/c/orbit/orbit-recipes.git/commit/?id=a341637c61e90c8ad3ef1572ed98f86117087b74
New Gerrit change created: https://git.eclipse.org/r/102510
(In reply to Eclipse Genie from comment #13) > New Gerrit change created: https://git.eclipse.org/r/102510 JUnit 5.0.0-RC2 was released on July 30, 2017. This Gerrit requests the addition of JUnit 5.0.0-RC2 bundles to Orbit after the CQs are updated and approved.
Gerrit change https://git.eclipse.org/r/102510 was merged to [master]. Commit: http://git.eclipse.org/c/orbit/orbit-recipes.git/commit/?id=6d51add16b8d5070063ce8ab50c2a07d08cf2251
M6 is in Photon M1, and RC2 will currently be destined for M2. I'm guessing we'll have a GA of Junit 5 by then.
(In reply to Roland Grunberg from comment #16) > M6 is in Photon M1, and RC2 will currently be destined for M2. I'm guessing > we'll have a GA of Junit 5 by then. Yes, JUnit 5 GA is scheduled for September 6. So, we will have it for M2.
New Gerrit change created: https://git.eclipse.org/r/103593
(In reply to Eclipse Genie from comment #18) > New Gerrit change created: https://git.eclipse.org/r/103593 JUnit 5.0.0-RC3 has been released on August 23, 2017. This Gerrit requests the addition of JUnit 5.0.0-RC3 bundles to Orbit after the CQs are updated and approved as Type B to prepare for the GA.
Gerrit change https://git.eclipse.org/r/103593 was merged to [master]. Commit: http://git.eclipse.org/c/orbit/orbit-recipes.git/commit/?id=4db369c373c9ce398c873d4f0dece530f63c75b3
New Gerrit change created: https://git.eclipse.org/r/104814
(In reply to Eclipse Genie from comment #21) > New Gerrit change created: https://git.eclipse.org/r/104814 JUnit 5 GA release has been published on September 10, 2017. This Gerrit requests the addition of JUnit 5.0.0 bundles to Orbit after the CQs are updated and approved.
(In reply to Noopur Gupta from comment #22) > (In reply to Eclipse Genie from comment #21) > > New Gerrit change created: https://git.eclipse.org/r/104814 > > JUnit 5 GA release has been published on September 10, 2017. > > This Gerrit requests the addition of JUnit 5.0.0 bundles to Orbit after the > CQs are updated and approved. JUnit 5 GA release has the following major changes: - Adds a new bundle "org.apiguardian": https://github.com/junit-team/junit5/issues/436 - Changes the license to EPL v2.0: https://github.com/junit-team/junit5/issues/1045 The corresponding changes have been done in the Gerrit patch.
Gerrit change https://git.eclipse.org/r/104814 was merged to [master]. Commit: http://git.eclipse.org/c/orbit/orbit-recipes.git/commit/?id=198acfab8b13229390a51ad84f40713a0d28e89c
The latest build after merging JUnit 5 GA changes does not create a source JAR for the newly added "org.apiguardian" bundle. I have tried creating the build once again to see if it is resolved but we still have the same issue. Building locally on my system creates the source JAR as well. I am not sure where the problem is. Any ideas?
My guess from looking at the nightly is that org.apiguardian ends up in the final repository because it is a requirement of other bundles from the junit stack. However, because it was never explicitly added to the aggregationfeature/feature.xml , the source bundle doesn't end up in the final repository. I'll fix this.
New Gerrit change created: https://git.eclipse.org/r/104987
Gerrit change https://git.eclipse.org/r/104987 was merged to [master]. Commit: http://git.eclipse.org/c/orbit/orbit-recipes.git/commit/?id=f92a9080663cf775eda4dd382d5dda8a3e6e7f35
I've built http://download.eclipse.org/tools/orbit/downloads/drops/I20170912154950/repository ( http://download.eclipse.org/tools/orbit/downloads/drops/I20170912154950/ ) Can you confirm this resolves your issue ? I can see the apiguardian source now being detected. Is this I-build sufficient and then having the fix make it in for M3 ?
(In reply to Roland Grunberg from comment #29) > Is this I-build sufficient and then having the fix make > it in for M3 ? We want to ship JUnit 5 support with M2 (due this Friday for us), so, we need it for M2 asap.
(In reply to Roland Grunberg from comment #26) > However, because it was never explicitly added to the > aggregationfeature/feature.xml , the source bundle doesn't end up in the > final repository. I'll fix this. Thanks, Roland. This was missed. (In reply to Roland Grunberg from comment #29) > I've built > http://download.eclipse.org/tools/orbit/downloads/drops/I20170912154950/repository > ( http://download.eclipse.org/tools/orbit/downloads/drops/I20170912154950/ ) > > Can you confirm this resolves your issue ? I can see the apiguardian source > now being detected. Yes, this should resolve the issue. (In reply to Dani Megert from comment #30) > (In reply to Roland Grunberg from comment #29) > > Is this I-build sufficient and then having the fix make > > it in for M3 ? > > We want to ship JUnit 5 support with M2 (due this Friday for us), so, we > need it for M2 asap. We can use this I-build to ship it with our M2. I have one more question: To ship these JARs with Oxygen.1a, do we need to add all these changes to the R4_7 branch of Orbit (if it exists)? We are currently using the same I-build for our R4_7 branch also which works fine.
> (In reply to Dani Megert from comment #30) > > (In reply to Roland Grunberg from comment #29) > > > Is this I-build sufficient and then having the fix make > > > it in for M3 ? > > > > We want to ship JUnit 5 support with M2 (due this Friday for us), so, we > > need it for M2 asap. > > We can use this I-build to ship it with our M2. If you can use the I-build great, if not I can post to orbit-dev that I intend to update our contribution to M2 and I'll kick off an S-build to be used as the newer contribution. I don't think this should be an issue as the older build will still be around. The metadata for all bundles will still be the same with the only difference being org.apiguardian is now present. > I have one more question: To ship these JARs with Oxygen.1a, do we need to > add all these changes to the R4_7 branch of Orbit (if it exists)? We are > currently using the same I-build for our R4_7 branch also which works fine. Oxygen.1 is almost RC4 complete so I think it's too late to backport to R4_7, build and expect any projects to adopt that. We finalized this contribution around RC2. If it works then I suppose you could even refer to a Photon milestone build for that content but you would have to be careful you don't drag in any other unintended bundles.
(In reply to Roland Grunberg from comment #32) Having an S-build for Orbit M2 with these changes would be great as I'll also be able to use it right away with our R4_7 branch.
(In reply to Roland Grunberg from comment #32) > Oxygen.1 is almost RC4 complete so I think it's too late to backport to > R4_7, build and expect any projects to adopt that. We finalized this > contribution around RC2. If it works then I suppose you could even refer to > a Photon milestone build for that content but you would have to be careful > you don't drag in any other unintended bundles. Just to clarify: we don't plan to ship JUnit 5 with Oxygen 1, but with the upcoming Oxygen 1a which is reserved for Java 9 and JUnit 5 changes. Since we're done with Oxygen 1, we start to merge things into R4_7_maintenance for Oxygen 1a.
(In reply to Dani Megert from comment #34) > (In reply to Roland Grunberg from comment #32) > > Oxygen.1 is almost RC4 complete so I think it's too late to backport to > > R4_7, build and expect any projects to adopt that. We finalized this > > contribution around RC2. If it works then I suppose you could even refer to > > a Photon milestone build for that content but you would have to be careful > > you don't drag in any other unintended bundles. > > Just to clarify: we don't plan to ship JUnit 5 with Oxygen 1, but with the > upcoming Oxygen 1a which is reserved for Java 9 and JUnit 5 changes. Since > we're done with Oxygen 1, we start to merge things into R4_7_maintenance for > Oxygen 1a. So, ideally, Orbit would produce an Oxygen 1a with the updated JUnit stuff. I hope that clarified things.
(In reply to Noopur Gupta from comment #33) > (In reply to Roland Grunberg from comment #32) > > Having an S-build for Orbit M2 with these changes would be great +1. We would need that today in order to produce our RC for sign-off tomorrow. Thanks.
(In reply to Dani Megert from comment #35) > So, ideally, Orbit would produce an Oxygen 1a with the updated JUnit stuff. > > I hope that clarified things. Yes, sorry for the confusion. I just read the information on cross-project-issues. Yes, in that case, the junit changes (along with any Java 9 relevant changes) should be backported to R4_7 . We can then do a Oxygen.1a release.
New Gerrit change created: https://git.eclipse.org/r/105158
New Gerrit change created: https://git.eclipse.org/r/105171
New Gerrit change created: https://git.eclipse.org/r/105172
Gerrit change https://git.eclipse.org/r/105172 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=2b102d6e51b73fc5908391491f8c3947765a515b
Gerrit change https://git.eclipse.org/r/105171 was merged to [R4_7_maintenance]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=b0d76e0a67c8ac03f8cafd1c235cbc4e6bd14b6f
The latest S-build is now being used for our master and R4_7 branches. Roland, please let me know when Orbit R4_7 is open for contribution.
R4_7 is open for contributions targeting Oxygen.1a . I'll announce to orbit-dev in case there are others whose changes fit the "Java 9 Support" category. In particular I would look at step (3) of https://wiki.eclipse.org/Orbit/Adding_Bundles_to_Orbit#Adding_Bundles_To_A_Maintenance_Release . This is necessary for backports (for now) to ensure that the qualifier used for the change matches master. Otherwise the cherry-picked change will take a completely new qualifier and would appear to have changes newer than even master.
(In reply to Roland Grunberg from comment #44) > R4_7 is open for contributions targeting Oxygen.1a . I'll announce to > orbit-dev in case there are others whose changes fit the "Java 9 Support" > category. > > In particular I would look at step (3) of > https://wiki.eclipse.org/Orbit/Adding_Bundles_to_Orbit#Adding_Bundles_To_A_Maintenance_Release > . This is necessary for backports (for now) to ensure that the qualifier > used for the change matches master. Otherwise the cherry-picked change will > take a completely new qualifier and would appear to have changes newer than > even master. Created https://git.eclipse.org/r/#/c/105351.
Gerrit change https://git.eclipse.org/r/105351 was merged to [R4_7]. Commit: http://git.eclipse.org/c/orbit/orbit-recipes.git/commit/?id=27e9a174bb514723f64f74a76f902059a4a6d508
You could try http://download.eclipse.org/tools/orbit/downloads/drops/M20170919201930/repository ( http://download.eclipse.org/tools/orbit/downloads/drops/M20170919201930/ ). This will likely become our Oxygen.1a RC1 in Orbit.
(In reply to Roland Grunberg from comment #47) > You could try > http://download.eclipse.org/tools/orbit/downloads/drops/M20170919201930/repository > ( http://download.eclipse.org/tools/orbit/downloads/drops/M20170919201930/ > ). This will likely become our Oxygen.1a RC1 in Orbit. Thanks Roland and sorry for the delay in response. Got occupied with Java 9 release work. The bundle versions in M-build are same as in master so it looks good. I will test and update.
(In reply to Noopur Gupta from comment #48) > The bundle versions in M-build are same as in master so it > looks good. I will test and update. I have tested the bundles from the M-build and everything looks good. Roland, please let me know when the R-build is available. Also, it would be good to create a target milestone of Oxygen.1a for this bug.
I've just declared the R-build (see orbit-dev mailing list) and http://download.eclipse.org/tools/orbit/downloads/ .
New Gerrit change created: https://git.eclipse.org/r/106190
(In reply to Roland Grunberg from comment #50) > I've just declared the R-build (see orbit-dev mailing list) and > http://download.eclipse.org/tools/orbit/downloads/ . Thanks, Roland. (In reply to Eclipse Genie from comment #51) > New Gerrit change created: https://git.eclipse.org/r/106190 This uses the new R-build in eclipse-sdk-prereqs.target.
Gerrit change https://git.eclipse.org/r/106190 was merged to [R4_7_maintenance]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=4ff4b48680af08a652737430b36c6a75faa32027
