Community
Participate
Working Groups
Chris, does the context launch work with multi-selection? A found a team that requires two files to be selected in the navigator before launching. It currently works with launch shortcuts, so we need to ensure that it still works/enables for the contextual launch case.
Darin, No, it currently does not work with multi-selection, by design. What is the use-case for multi-selection? I think we can extend it to multi-selection, but there may be some issues with the filtering rules, etc. For example, do the filters need to be composed? Do the filters need to accept the multi-selection? Thanks, Chris
The use case is that the user must select an XML file and a Java file to run "together". This currently works with launch shortcuts in the top level menu. The filter should accecpt an ISelection in this case. Currently, does the filter just get the selected object? Perhaps we should just generalize this to an ISelection?
Erin, can you comment on the use case for multi-selection? Thanks.
Darin, you make good points. I have reduced the ISelection to an IResource because I did not consider the multi-selection case and it appeared to simplify (greatly) the interface for the filterClass:testAttribute() method. If we use ISelection, there are several lines of casting/instance checking that must be added to every filter method. It is also unclear how the new nameFilter attribute should function. I will need to check if there are any existing patterns in UI land that we want to be consistent with. To summarize, I agree that we should find a way to support multi-selection; I would like to make the typical case the easy one for implementors, though.
In order to run an XSL transform, both an xsl file and an xml file need to be specified. To provide a true quick launch (e.g. no dialogs) we would need to allow both these files to be selected by the user. Also, users can do batch transforms where one xsl file is applied to a list of xml files. In this case it would be nice to allow the user to select one xsl file and several xml files.
Agreed, we need to support multi-selection. This will be accomplished by the combination of fixing both bugs #51420 and #54117. Leaving this one open until the above two are resolved and verified.
Marking as FIXED since #51420 and #54117 are finished. Not sure how to proceed to verify. The multi-selection can't be shown yet since we don't have a multi-selection shortcut handy. However, code inspection of the ContextualLaunchObjectActionDelegate type in debug/ui will show that we now treat the user selection as an instance of IStructuredSelection. So, shortcut providers are free to use multi-selection in the context menu. Please inspect ContextualLaunchObjectActionDelegate to verify. Thanks.
Re-opening since the bug Jared filed makes this look incomplete.
*** This bug has been marked as a duplicate of 59729 ***
