Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 515052 - Transform Ctrl+F7 into a filtered dialog
Summary: Transform Ctrl+F7 into a filtered dialog
Status: RESOLVED INVALID
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.7   Edit
Hardware: PC Windows NT
: P3 normal (vote)
Target Milestone: 4.7 M7   Edit
Assignee: Patrik Suzzi CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 515060 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-04-10 13:17 EDT by Patrik Suzzi CLA
Modified: 2017-04-12 11:34 EDT (History)
4 users (show)

See Also:

Attachments
image: the select View Filtered dialog (63.79 KB, image/png)
2017-04-10 13:17 EDT, Patrik Suzzi CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrik Suzzi CLA 2017-04-10 13:17:23 EDT 
Created attachment 267735 [details]
image: the select View Filtered dialog

Ctrl+F6 (CycleEditorHandler) shares code with Ctrl+E (WorkbookEditorsHandler). The main difference is that the second has a filtered list. 

I would like to change the Ctrl+F7 (CycleViewHandler) to be a search dialog with a filtered list), or to add a new command that shows the filtered list.
Comment 1 Eclipse Genie CLA 2017-04-10 13:18:55 EDT 
New Gerrit change created: https://git.eclipse.org/r/94771
Comment 3 Lars Vogel CLA 2017-04-10 14:55:13 EDT 
I suggest to open a new bug to provide also a filter for Ctrl+F8.
Comment 4 Patrik Suzzi CLA 2017-04-10 14:58:33 EDT 
Good Idea! - Bug 515060
Comment 5 Markus Keller CLA 2017-04-11 09:38:33 EDT 
The commands are called Next/Previous View. Ctrl+F6/F7/F8 form a group of quick switching commands that all behave in the same way.

Please restore the original functionality. You can add new commands that work similar to Quick Switch Editor, but you can't destroy existing functionality like this.
Comment 6 Markus Keller CLA 2017-04-11 09:44:37 EDT 
*** Bug 515060 has been marked as a duplicate of this bug. ***
Comment 7 Lars Vogel CLA 2017-04-11 09:45:26 EDT 
Dani, what do you think? I find Ctrl+F7 much more usable with Patriks change. I agree that Ctrl+F6/F7/F8 should behave the same, but I would rather suggest to adjust Ctrl+F6.
Comment 8 Markus Keller CLA 2017-04-11 09:49:25 EDT 
BTW: We already have commands that open a filtered dialog for views/perspectives.
Comment 9 Lars Vogel CLA 2017-04-11 10:01:07 EDT 
I send also an email to Platform UI to get additional feedback from more committer.
Comment 10 Eclipse Genie CLA 2017-04-12 08:55:48 EDT 
New Gerrit change created: https://git.eclipse.org/r/94923
Comment 12 Dani Megert CLA 2017-04-12 08:57:01 EDT 
(In reply to Patrik Suzzi from comment #0)
> Ctrl+F6 (CycleEditorHandler) shares code with Ctrl+E
> (WorkbookEditorsHandler). The main difference is that the second has a
> filtered list. 

This is just one difference. The other difference is that Ctrl+F6 offers a very quick way (only interaction is Ctrl+F6 and then additional F6 hits) to switch between editors.


(In reply to Lars Vogel from comment #7)
> Dani, what do you think?

This broke the feature to quickly switch to another view and I have reverted it with https://git.eclipse.org/r/#/c/94923/
Comment 13 Dani Megert CLA 2017-04-12 09:05:58 EDT 
(In reply to Patrik Suzzi from comment #4)
> Good Idea! - Bug 515060

Not really. I've also reverted that change for the same reasons as explained in the previous comment.
Comment 14 Patrik Suzzi CLA 2017-04-12 11:34:21 EDT 
I like the reverted idea because it adds a filter and because it allows the user to select with a mouse click.

(In reply to Dani Megert from comment #12)
> Ctrl+F6 offers a very quick way (only interaction is Ctrl+F6 and then additional F6 hits) 

I see what you mean. Indeed in the filtered dialog, the user must press enter (or left mouse) to select an entry. 

Thanks for reverting it back.