Comment 1 Rob Stryker 2017-04-07 00:56:03 EDT

How is this class intended to function? It seems it adapts all things to IPath when it's supposed to adapt things to VirtualArchiveComponent?

public class VirtualArchiveComponentAdapterFactory implements IAdapterFactory {

        public Object getAdapter(Object adaptableObject, Class adapterType) {
                if (adapterType == VirtualArchiveComponent.ADAPTER_TYPE ) {
                        VirtualArchiveComponent component = (VirtualArchiveComponent) adaptableObject;
                        IPath path = J2EEProjectUtilities.getResolvedPathForArchiveComponent(component.getName());
                        return path;
                }
                return null;
        }


        public Class[] getAdapterList() {
                return new Class[]{VirtualArchiveComponent.class};
        }

}

Comment 2 Rob Stryker 2017-04-07 01:01:41 EDT

https://git.eclipse.org/r/#/c/90539/   - Recent patch to platform enforcing adapters behave properly
https://git.eclipse.org/r/#/c/90540/   - An added test case


One month ago, it seems the platform added explicit checks to make sure all adapters were behaving and returning an object of the same class they were requested to adapt to. 

That means VirtualArchiveComponentAdapterFactory is out of spec with the current requirements of platform, because it adapts an object to an IPath when requested to adapt to a VirtualArchiveComponent

Comment 3 Eclipse Genie 2017-04-07 01:14:21 EDT

New Gerrit change created: https://git.eclipse.org/r/94623

Comment 4 Eclipse Genie 2017-04-07 01:15:34 EDT

New Gerrit change created: https://git.eclipse.org/r/94624

Comment 5 Rob Stryker 2017-04-07 01:52:17 EDT

Sorry, I duplicated two changes by accident.   

The proper PR is https://git.eclipse.org/r/#/c/94624/

Unfortunately the build is failing because it is using java7 and requires java 8. 

Hope we can get that fixed soon.

Comment 6 Carl Anderson 2017-04-07 11:15:21 EDT

Since the fix appears to be in J2EE Tools, I am moving it there.

Comment 7 Fred Bricon 2017-04-07 11:17:40 EDT

Would be nice to have regression tests that show classpath variable-based dependencies are supported :-)

Comment 8 Rob Stryker 2017-04-07 13:58:14 EDT

It seems it's not limited to jeetools.  My patch is incomplete and also requires a change to common as well.   My patch causes an infinite loop in VirtualArchiveComponent, because it's still trying to adapt a VirtualArchiveComponent to a VirtualArchiveComponent (a strange thing to do) when it's really trying to adapt it to an IPath. 

Webtools.common doesn't seem to have gerrit?  I have a patch here:

https://github.com/robstryker/webtools.common/tree/514672


These two patches together basically serve one purpose:  the current behavior is trying to adapt a VirtualArchiveComponent to a VirtualArchiveComponent, and expecting an IPath in return. This is clearly broken. Instead, we should be trying to adapt the VirtualArchiveComponent to an IPath. 

Fred has both of these changes applied in his workspace and indicates that they seem to work. But I can't even replicate the original bug so I'm not much help :( 

Either way, these two patches need to be considered in unison, not separately. 

https://github.com/robstryker/webtools.common/commit/8b76ed44233cae9de39de45c316f8eb00c0aa12c

https://git.eclipse.org/r/#/c/94624/

Comment 9 Fred Bricon 2017-04-20 08:50:29 EDT

*** Bug 515495 has been marked as a duplicate of this bug. ***

Comment 10 Eclipse Genie 2017-04-20 13:50:37 EDT

Gerrit change https://git.eclipse.org/r/94624 was merged to [master].
Commit: http://git.eclipse.org/c/jeetools/webtools.javaee.git/commit/?id=515cf02aad551df026713512291a9d72c5d111b2

Comment 11 Carl Anderson 2017-04-20 14:28:25 EDT

I committed a version of https://github.com/robstryker/webtools.common/commit/8b76ed44233cae9de39de45c316f8eb00c0aa12c that had a capitalization fix (so that it compiled correctly).  (Note that the IP Log flag does not need to be set here, since Rob is a committer on common).

Chuck already pushed the J2EE change through Gerrit, so this should be fixed now, for Oxygen M7.

Comment 12 Filippo Rossoni 2017-06-08 06:10:09 EDT

I got this error on Eclipse 4.7 RC2

Errors occurred during the build.
Errors running builder 'Faceted Project Validation Builder' on project 'AdijedEJB.ear'.
Adapter factory org.eclipse.jst.j2ee.internal.common.VirtualArchiveComponentAdapterFactory@6baa1f57 returned org.eclipse.core.runtime.Path that is not an instance of org.eclipse.wst.common.componentcore.internal.resources.VirtualArchiveComponent

Comment 13 Filippo Rossoni 2017-06-14 08:49:45 EDT

report
https://dev.eclipse.org/recommenders/community/aeri/v2/#!/submissions/2fbkD78qdb0OOmdXikoy3Llc1sHJFocvLzJc4vcOy3iVm3kQgqi6uADHSuGkW1ec

Comment 14 Carl Anderson 2017-06-14 11:25:57 EDT

(In reply to Filippo Rossoni from comment #12)
> I got this error on Eclipse 4.7 RC2
> 
> Errors occurred during the build.
> Errors running builder 'Faceted Project Validation Builder' on project
> 'AdijedEJB.ear'.
> Adapter factory
> org.eclipse.jst.j2ee.internal.common.
> VirtualArchiveComponentAdapterFactory@6baa1f57 returned
> org.eclipse.core.runtime.Path that is not an instance of
> org.eclipse.wst.common.componentcore.internal.resources.
> VirtualArchiveComponent

Was this using an EPP?  We found an issue where BIRT was contributing an older version of WTP to the EPPs- that was fixed for RC3.

Comment 15 Filippo Rossoni 2017-06-15 04:43:53 EDT

Yes is the packaged version I'm behind a proxy and the update didn't work