Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 512946 - PopupMenu does not insert a new element when touchdisplay is enabled
Summary: PopupMenu does not insert a new element when touchdisplay is enabled
Status: RESOLVED FIXED
Alias: None
Product: GMF-Runtime
Classification: Modeling
Component: General (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows NT
: P3 normal
Target Milestone: 1.10.1   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 485619
Blocks:
  Show dependency tree
 
Reported: 2017-03-02 04:51 EST by Pierre-Charles David CLA
Modified: 2017-03-06 08:31 EST (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pierre-Charles David CLA 2017-03-02 04:51:32 EST 
+++ This bug was initially created as a clone of Bug #485619 +++

the 'create new model element' Popup does not work under windows 10 with touch display, no selection event is raised.

When I open the Windows device manager/human Interface Devices and disable HID-compliant Touch Screen, it works as expected.

the reason is a missing readAndDispatch() in org.eclipse.gmf.runtime.diagram.ui.menus.PopupMenu, for details see
bugzilla #480318

I contributed a patch for this via GitHub, it would be great if someone can merge this into master, thanks.
Comment 1 Pierre-Charles David CLA 2017-03-02 04:52:50 EST 
Cloned from bug #485619 to track the backport on the 1.10.1 maintenance version, planned for inclusion in Neon.3 (if I can get everything in place before the deadline).
Comment 2 Pierre-Charles David CLA 2017-03-02 09:01:28 EST 
Fixed by 8cf95dbbdef15f4eca5975882e4e355ef88a3407 on branch R1_10_maintenance.
Comment 3 Pierre-Charles David CLA 2017-03-03 04:54:53 EST 
I've promoted a 1.10.1rc1 at http://download.eclipse.org/modeling/gmp/gmf-runtime/updates/milestones/S201703021641 with the fix. It should normally be part of Neon.3.
Comment 4 Pierre-Charles David CLA 2017-03-06 08:31:39 EST 
After further consideration, I've decided not to contribute the 1.10.1 maintenance version in Neon.3. We're quite late in the Neon.3 release cycle (the final RC is this week), which will be the last Neon release ever. Even though the code changes for this fix is small, I have not actually tested it. More importantly, I am not 100% confident that I have not missed anything in the GMF Runtime build & release processes (as I took over the project's maintenanceship recently). GMF Runtime 1.10.1 will be released (soon), with this fix included, but not contributed in the Neon.3 release; it will need to be explicitly installed by those who need it. This single fix does not seem worth the risk (however remote) of breaking some aspects of GMF in the last ever Neon release.