Community
Participate
Working Groups
Follow up from bug 511482, we need to provide a way for users to see / or perhaps configure the computed environment information. Some ideas: 1. Provide some UI on the project explorer page to show the information 2. provide a command to write the files - for example, generate an eslintrc* file based on the env infos.
Created attachment 267144 [details] Proposed fix Here is a proposed fix - it adds a project handler for the Javascript tools to provide environment infos in the project view pane (when you select a project).
Created attachment 267147 [details] Same patch + sections remember expanded state
We took a look at the UI and there were a bunch of problems with it that I don't think we can address for Orion 14. 1) The ordering should be READ.ME, files, then project information. 2) The sections should be closed by default (otherwise it is overwhelming). 3) Any time there is an expand/collapse it has to be remembered 4) We need to look at all the information being displayed (non-tooling as well) and decide whether we want it, the styling etc. I am guessing that changing the UI in any way that is obtrusive at this point will cause consternation. Having said that, I love the feature because I can see what is happening. The only thing I can suggest is dark launch or a setting to turn it on and have it turned off by default.
... and SSQ fixed some of the things we saw. Do we need call to decide next steps?
Created attachment 267169 [details] Updated patch This patch builds on Silenios' patch, and makes all section but the nav one collapsed by default, as well as adding a general preference to show / hide the additional project information when a project.json file is not present.
Do we think we are done? If so, SSQ and I will give it a try soon.
(In reply to Steve Northover from comment #6) > Do we think we are done? If so, SSQ and I will give it a try soon. Yes, just waiting on review and / or blessing for 14.
Spoke to SSQ. We should defer to Orion 15. It's a shame but I'd also like to discuss with you more some of the things that we are showing.
(In reply to Steve Northover from comment #8) > Spoke to SSQ. We should defer to Orion 15. It's a shame but I'd also like > to discuss with you more some of the things that we are showing. No problem. I think it still needs some more refining such as: 1. how do we not show it for every project - for example if you have a Java project, you would never want to see a JavaScript info entry 2. we need to be able to tag a project (or something) like Git does to better apply our infos (this would pretty much fix point one as well). 3. what infos we show - we need to make sure paths do not show internal path names - for example the project path currently includes '/file/' when it should not. We should also try to make any path a link. 4. investigate if we can provide the functionality to create a config file that is not found - for example if we detect that you have no package.json file, rather than the UI just saying 'None', there could be a button to create one.
Fixed in: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=367b68c7258698c606dbe9d843f5cb1a1faee17b Chatting with Silenio, we opt'd to get rid of the preference since the project info sections are now always at the bottom of the preview page (past the nav section). This fix include an update for point 3 in comment #9. Points 1 and 2 were not needed with the sorting order update and point 4 is unnecessary - those types of config files take some thinking and planning to make "properly" simply allowing them to be created like that is not that helpful.
