Community
Participate
Working Groups
As the foundation build infrastructure is currently unstable, we randomly see Gerrit validation jobs failing. Currently the Gerrit validation jobs can only be re-triggered by committers of the same sub-project. This makes it harder for committers of other sub-projects to validate their contributions. I suggest to give all Eclipse top-level project members the rights to retrigger jobs within the sub-projects.
Fine with me.
@Webmaster, do we have a group for all committer from the top-level Eclipse project in Hudson? I see in https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/configure ROLE_ECLIPSE.PLATFORM ROLE_ECLIPSE.PLATFORM.UI
Fine with me too.
There is no single group for the top-level Eclipse project. We would need to add around 20 different groups. An alternative would be to allow all committers (common group) to retrigger jobs.
(In reply to Frederic Gurr from comment #4) > An alternative would be to allow all > committers (common group) to retrigger jobs. Sound good to me. Does anyone see an issue with that? I suggest we also give this group the permission to "read" the job configuration.
(In reply to Lars Vogel from comment #5) > I suggest we also give this group the permission to "read" the job > configuration. The common group already has "read" and "extended read" permissions on all HIPPs.
(In reply to Frederic Gurr from comment #6) > The common group already has "read" and "extended read" permissions on all > HIPPs. Should "read" and "extended read" allow me to see the job configuration? Because that is currently not working.
Extended read should do the trick, yes. Which job did you try it with?
(In reply to Frederic Gurr from comment #8) > Extended read should do the trick, yes. For example: https://hudson.eclipse.org/releng/job/I-build/ here I do not see the "Configure" option. The following works for me even though I am not a committer: https://hudson.eclipse.org/platform/job/eclipse.jdt.ui-Gerrit/configure
(In reply to Lars Vogel from comment #9) > For example: https://hudson.eclipse.org/releng/job/I-build/ here I do not > see the "Configure" option. Well, for whatever reason your user (was defined twice and) had conflicting permissions defined in the "job-based security" settings. I've fixed this. You should now see a "View Configuration" link on this job. > The following works for me even though I am not a committer: > https://hudson.eclipse.org/platform/job/eclipse.jdt.ui-Gerrit/configure You can view the configuration, but not edit it, right? The common group contains all Eclipse committers, regardless of which project you belong to.
(In reply to Frederic Gurr from comment #10) > (In reply to Lars Vogel from comment #9) > > For example: https://hudson.eclipse.org/releng/job/I-build/ here I do not > > see the "Configure" option. > > I've fixed this. > You should now see a "View Configuration" link on this job. Unfortunately no, I still get "Lars.Vogel@vogella.com is missing the ExtendedRead permission" for https://hudson.eclipse.org/releng/job/I-build/configure > > The following works for me even though I am not a committer: > > https://hudson.eclipse.org/platform/job/eclipse.jdt.ui-Gerrit/configure > > You can view the configuration, but not edit it, right? Correct.
(In reply to Lars Vogel from comment #11) > Unfortunately no, I still get "Lars.Vogel@vogella.com is missing the > ExtendedRead permission" for > https://hudson.eclipse.org/releng/job/I-build/configure Can you please try it with your email address in all lower-case? (your job-security permissions were actually defined twice with different capitalizations... which for me is a already a bug) P.S.: We're drifting a bit off-topic here.
(In reply to Frederic Gurr from comment #12) > Can you please try it with your email address in all lower-case? Works. Thanks. > P.S.: We're drifting a bit off-topic here. +1
The PMC approved this: https://wiki.eclipse.org/Eclipse/PMC
Ping. I'm really looking forward to not having to push dummy changes to retrigger jdt.ui jobs ...
I've added the ManualTrigger permission for the common group.
Unfortunately I still cannot retrigger e.g https://hudson.eclipse.org/platform/job/eclipse.jdt.ui-Gerrit/1164/ (I'm jdt.core committer)
I also had to add the Build permission for the common group to make this work. Hudson and the latest Gerrit trigger plugin for it don't have a separate Retrigger permission yet. This will be available with Jenkins and newer Gerrit trigger plugin versions.
Sorry to reopen this again, but it still doesn't work, same example: (In reply to Till Brychcy from comment #17) > Unfortunately I still cannot retrigger e.g > https://hudson.eclipse.org/platform/job/eclipse.jdt.ui-Gerrit/1164/ > > (I'm jdt.core committer)
(In reply to Till Brychcy from comment #19) > Sorry to reopen this again, but it still doesn't work, same example: > > (In reply to Till Brychcy from comment #17) > > Unfortunately I still cannot retrigger e.g > > https://hudson.eclipse.org/platform/job/eclipse.jdt.ui-Gerrit/1164/ > > > > (I'm jdt.core committer) In the meantime I've retriggered this build by pushing a rebased patch. Another non-deterministic failure, and I can't retrigger this either: https://hudson.eclipse.org/platform/job/eclipse.jdt.ui-Gerrit/1167/
Hmm. Weird. I've added specific permissions for you now, please try again. (Maybe also try logging out and in again on the HIPP.)
(In reply to Frederic Gurr from comment #21) > Hmm. Weird. > I've added specific permissions for you now, please try again. (Maybe also > try logging out and in again on the HIPP.) Worked, thanks!
Can another committer - that is not part of the sub-project in question - confirm that it is working?
(In reply to Frederic Gurr from comment #23) > Can another committer - that is not part of the sub-project in question - > confirm that it is working? I was able to retrigger https://hudson.eclipse.org/platform/job/eclipse.jdt.ui-Gerrit/1167/ even though I'm not a committer to JDT UI Thanks a bunch Frederic, I think this one can get marked as fixed.
(In reply to Frederic Gurr from comment #23) > Can another committer - that is not part of the sub-project in question - > confirm that it is working? Does NOT work for me. I'm not a committer in jdt, and can't retrigger build https://hudson.eclipse.org/platform/job/eclipse.jdt.core-Gerrit/2575/
(In reply to Andrey Loskutov from comment #25) > Does NOT work for me. I'm not a committer in jdt, and can't retrigger build > https://hudson.eclipse.org/platform/job/eclipse.jdt.core-Gerrit/2575/ Have you tried logging off and in again (in Hudson)?
(In reply to Frederic Gurr from comment #26) > (In reply to Andrey Loskutov from comment #25) > > Does NOT work for me. I'm not a committer in jdt, and can't retrigger build > > https://hudson.eclipse.org/platform/job/eclipse.jdt.core-Gerrit/2575/ > > Have you tried logging off and in again (in Hudson)? Just did it again to be sure, no change, no "Retrigger" button.
I can't reproduce this error. As soon as I give the anonymous user (for testing purposes) build permissions on a job (e.g. eclipse.jdt.ui-Gerrit), the retrigger link is available. Since the common group has hipp-wide build permissions and has no job specific restrictions (at least not in eclipse.jdt.core-Gerrit or eclipse.jdt.ui-Gerrit) this should work. Andrey, just to double-check: do you see the retrigger link here: https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/12259/console
(In reply to Frederic Gurr from comment #28) > I can't reproduce this error. As soon as I give the anonymous user (for > testing purposes) build permissions on a job (e.g. eclipse.jdt.ui-Gerrit), > the retrigger link is available. > Since the common group has hipp-wide build permissions and has no job > specific restrictions (at least not in eclipse.jdt.core-Gerrit or > eclipse.jdt.ui-Gerrit) this should work. > > Andrey, just to double-check: do you see the retrigger link here: > https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/12259/ > console I see "Retrigger" here, but this is a different project, may be the problem is with jdt core instance?
(In reply to Andrey Loskutov from comment #29) > > Andrey, just to double-check: do you see the retrigger link here: > > https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/12259/ > > console BTW I'm platform-ui committer, so obviously I should be able to re-trigger gerrits there :-)
(In reply to Andrey Loskutov from comment #29) > I see "Retrigger" here, but this is a different project, may be the problem > is with jdt core instance? There are no job-specific settings for the jdt core Gerrit job that should interfere with the general permissions. (In reply to Andrey Loskutov from comment #30) > BTW I'm platform-ui committer, so obviously I should be able to re-trigger > gerrits there :-) I know. I just wanted to double-check that you see the retrigger link at all. :) I'm open to suggestions, but I'm running out of ideas why it doesn't work for you (and Till). Apparently it works for Lars. :/
(In reply to Frederic Gurr from comment #31) > I'm open to suggestions, but I'm running out of ideas why it doesn't work > for you (and Till). Apparently it works for Lars. :/ Lars is in PMC, Till and me not.
(In reply to Andrey Loskutov from comment #32) > (In reply to Frederic Gurr from comment #31) > > I'm open to suggestions, but I'm running out of ideas why it doesn't work > > for you (and Till). Apparently it works for Lars. :/ > > Lars is in PMC, Till and me not. I don't think that matters. AFAIK we do not have a "PMC" group.
(In reply to Dani Megert from comment #33) > (In reply to Andrey Loskutov from comment #32) > > (In reply to Frederic Gurr from comment #31) > > > I'm open to suggestions, but I'm running out of ideas why it doesn't work > > > for you (and Till). Apparently it works for Lars. :/ > > > > Lars is in PMC, Till and me not. > > I don't think that matters. AFAIK we do not have a "PMC" group. I think I might know what's going on "An alternative would be to allow all committers (common group) to retrigger jobs." (In reply to Dani Megert from comment #33) > (In reply to Andrey Loskutov from comment #32) > > (In reply to Frederic Gurr from comment #31) > > > I'm open to suggestions, but I'm running out of ideas why it doesn't work > > > for you (and Till). Apparently it works for Lars. :/ > > > > Lars is in PMC, Till and me not. > > I don't think that matters. AFAIK we do not have a "PMC" group. Could it be that https://projects.eclipse.org/projects/eclipse.platform/who is it's own set of committers and not aggregation of all the subprojects? I have been catched by this once in the past so worth checking.
(In reply to Alexander Kurtakov from comment #34) > Could it be that https://projects.eclipse.org/projects/eclipse.platform/who > is it's own set of committers Yes. Each project you see maps to an ACL with those people. There is no aggregation.
IIRC I had issues with permissions in the past, because I used Lars.Vogel... to log in but my data was maintained for lars.vogel. Andrey, maybe you also used "name style" email to login?
(In reply to Lars Vogel from comment #36) > IIRC I had issues with permissions in the past, because I used Lars.Vogel... > to log in but my data was maintained for lars.vogel. Andrey, maybe you also > used "name style" email to login? Good idea. I always login everywhere with "loskutov@gmx.de" as user name. The "Eclipse foundation user name" I have is "aloskutov" and I can't login to Hudson with this name (but I can login with "aloskutov" at eclipse.org).
(In reply to Andrey Loskutov from comment #37) > Good idea. I always login everywhere with "loskutov@gmx.de" as user name. AFAIK our Hudson needs an email. "loskutov@gmx.de" sounds non controversial to me.
Your GMX.de address is the one associated with your Eclipse account, so that should be the right one.
Is anyone still experiencing problems or we can close this one?
(In reply to Alexander Kurtakov from comment #40) > Is anyone still experiencing problems or we can close this one? I'm still there and I can't retrigger jdt tests.
I've explicitly added permissions (read/extended read/build/workspace) for the common group for this particular job (https://hudson.eclipse.org/platform/job/eclipse.jdt.core-Gerrit/). Please try again Andrey.
(In reply to Frederic Gurr from comment #42) > I've explicitly added permissions (read/extended read/build/workspace) for > the common group for this particular job > (https://hudson.eclipse.org/platform/job/eclipse.jdt.core-Gerrit/). > > Please try again Andrey. I expect that for example if I go to some build like this: https://hudson.eclipse.org/platform/job/eclipse.jdt.core-Gerrit/2969/ I can see "Retrigger" button on the left side. Nope, still no "retrigger" button :-(
I've added explicit permissions (same as in comment 42) for your user. Please try again.
(In reply to Frederic Gurr from comment #44) > I've added explicit permissions (same as in comment 42) for your user. > Please try again. Jawohl!!! Danke! I can re-trigger JDT builds, finally, and stop them too! The biggest dream of my life came true!
I don't understand why permissions for the common group do not apply to your user. m(
(In reply to Andrey Loskutov from comment #45) > The biggest dream of my life came true! That was easy :)
I think this was solved.
