Community
Participate
Working Groups
use ppc64 and ppc64LE machines from redhat
New Gerrit change created: https://git.eclipse.org/r/91248
Gerrit change https://git.eclipse.org/r/91248 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=d31a7f005a2134fa1c690d6ec82b41a6fcbcb398
New Gerrit change created: https://git.eclipse.org/r/91272
Gerrit change https://git.eclipse.org/r/91272 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=697d67ccbde294e1ea488f55efbf6047ebce6ed9
New Gerrit change created: https://git.eclipse.org/r/91273
Gerrit change https://git.eclipse.org/r/91273 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.binaries.git/commit/?id=d1f894d23177d50465a44d09e4c15b7a8e6c3f10
No further work is expected here AFAIK. Can we close this one?
(In reply to Alexander Kurtakov from comment #7) > No further work is expected here AFAIK. Can we close this one? Launcher changes are still pending. Lets close this after launcher changes also done
The patch (697d67ccbde294e1ea488f55efbf6047ebce6ed9) that changed build.sh hard-codes a path to the java on the machine: export JAVA_HOME=" /usr/lib/jvm/java-1.8.0-openjdk-1.8.0.121-1.b14.fc24.ppc64" This will break if java is updated. Instead I suggest the javapath is found dynamically. For example something like: > # Cross-platform method of finding JAVA_HOME. > # Tested on Fedora 24 and Ubuntu 16 > JAVA_HOME=`readlink -f /usr/bin/java | sed "s:jre/bin/java::"` (See build.sh) The above works reliably. It has worked on my machine all the way from Fedora 24 up to newest Fedora 25 versions.
@Sravan, I'd be happy to submit the relevant patch, if I do, will you be able to test it?
(In reply to Leo Ufimtsev from comment #10) > @Sravan, > > I'd be happy to submit the relevant patch, if I do, will you be able to test > it? That should be good. I can do the test for you. Thanks
New Gerrit change created: https://git.eclipse.org/r/94306
(In reply to Sravan Kumar Lakkimsetti from comment #11) > (In reply to Leo Ufimtsev from comment #10) > > @Sravan, > > > > I'd be happy to submit the relevant patch, if I do, will you be able to test > > it? > > That should be good. I can do the test for you. Thanks (In reply to Eclipse Genie from comment #12) > New Gerrit change created: https://git.eclipse.org/r/94306 Here is the patch. Is it possible for you to test it before we merge it? (Or does it need to be merged to test?) Thank you.
Gerrit change https://git.eclipse.org/r/94306 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=e3b59e1813cbf211a4dde88f1528d9458ca3860b
Sravan, can we close this one and all the dependent ones?
Yes this can be closed now