Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 511917 - [Model import] update the model import tool to produce a Port_NameLabel view without an explicit set of element
Summary: [Model import] update the model import tool to produce a Port_NameLabel view ...
Status: CLOSED FIXED
Alias: None
Product: Papyrus
Classification: Modeling
Component: Others (show other bugs)
Version: 2.0.1   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 3.0.0   Edit
Assignee: smaoui asma CLA
QA Contact:
URL:
Whiteboard: blockingpapyrusrt
Keywords:
Depends on:
Blocks: 511211
  Show dependency tree
 
Reported: 2017-02-08 09:27 EST by smaoui asma CLA
Modified: 2017-06-19 06:54 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description smaoui asma CLA 2017-02-08 09:27:29 EST 

    


    


      



        
          Comment 1
        

        
          smaoui asma CLA

        

        
        

        
          2017-02-08 09:32:24 EST
        

      






Currently, the Port_NameLabel view imported from a compositestructure diagram contains an explicit set of the element that should not be there.

A port name label is a DecorationNode that refer to the parent element, an explicit set of the element is confusing mainly whith inherited port (capability added in Papyrus RT).

    


    


      



        
          Comment 2
        

        
          Eclipse Genie CLA

        

        
        

        
          2017-02-08 09:42:20 EST
        

      






New Gerrit change created: https://git.eclipse.org/r/90639

    


    


      



        
          Comment 3
        

        
          Eclipse Genie CLA

        

        
        

        
          2017-02-09 08:21:11 EST
        

      






New Gerrit change created: https://git.eclipse.org/r/90727

    


    


      



        
          Comment 4
        

        
          smaoui asma CLA

        

        
        

        
          2017-02-09 10:08:47 EST
        

      






it could be interessant to raise another bug for the Papyrus Importer inorder to avoid generating DecorationNode that refer to the element already refered by the parent shape in the other diagrams (SM, AD, etc.)

I suppose that when we will test the importer for SM with the inheritence capability we will be facing the same pb : label not displayed for inherited elements.

The fix will be the same fix that I propose here, the toLabel() mapping should inherits from the abstract toNodeLabel() mapping and not the toPapyrusNode() mapping  that set the element.

    


    


      



        
          Comment 5
        

        
          Peter Cigehn CLA

        

        
        

        
          2017-02-09 10:25:12 EST
        

      






(In reply to smaoui asma from comment #4)
> it could be interessant to raise another bug for the Papyrus Importer
> inorder to avoid generating DecorationNode that refer to the element already
> refered by the parent shape in the other diagrams (SM, AD, etc.)
> 
> I suppose that when we will test the importer for SM with the inheritence
> capability we will be facing the same pb : label not displayed for inherited
> elements.
> 
> The fix will be the same fix that I propose here, the toLabel() mapping
> should inherits from the abstract toNodeLabel() mapping and not the
> toPapyrusNode() mapping  that set the element.

Regarding the import of state-machine diagrams, I have a feeling that there is a need for some more general testing of that, not only from the perspective of inheritance (and then specifically for UML-RT and Papyrus-RT regarding the layout inheritance). I myself have seen numerous issues with imported state-machine diagrams (see for example this mail thread on the Papyrus-RT developer mailing list https://dev.eclipse.org/mhonarc/lists/papyrus-rt-dev/msg01541.html) but have not had the time (or priority/focus) on testing import of state-machine diagrams. But I guess eventually that should be done as well.

    


    


      



        
          Comment 6
        

        
          Eclipse Genie CLA

        

        
        

        
          2017-02-10 04:52:54 EST
        

      






Gerrit change https://git.eclipse.org/r/90727 was merged to [streams/2.0-maintenance].
Commit: http://git.eclipse.org/c/papyrus/org.eclipse.papyrus.git/commit/?id=61cd1a1c51a3247567f1b715b36b5e0712630fb3

    


    


      



        
          Comment 7
        

        
          Eclipse Genie CLA

        

        
        

        
          2017-02-10 07:59:04 EST
        

      






New Gerrit change created: https://git.eclipse.org/r/90829

    


    

    


      



        
          Comment 9
        

        
          Florian Noyrit CLA

        

        
        

        
          2017-02-10 09:02:09 EST
        

      






Merged on both Neon and Oxygen.

    


    


      



        
          Comment 10
        

        
          Eclipse Genie CLA

        

        
        

        
          2017-02-15 11:25:57 EST
        

      






New Gerrit change created: https://git.eclipse.org/r/91185

    


    


      



        
          Comment 11
        

        
          Eclipse Genie CLA

        

        
        

        
          2017-02-16 04:17:08 EST
        

      






New Gerrit change created: https://git.eclipse.org/r/91254

    


    


      



        
          Comment 12
        

        
          Eclipse Genie CLA

        

        
        

        
          2017-02-17 06:11:01 EST
        

      






Gerrit change https://git.eclipse.org/r/91185 was merged to [streams/2.0-maintenance].
Commit: http://git.eclipse.org/c/papyrus/org.eclipse.papyrus.git/commit/?id=464212d3f5c6e6b5a67baac34916a1cf11b34290