510765 – CloudControllerResponseErrorHandler does not include description field of 5XX errors

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 510765 - CloudControllerResponseErrorHandler does not include description field of 5XX errors

Summary: CloudControllerResponseErrorHandler does not include description field of 5XX...

Status:	CLOSED FIXED

Alias:	None

Product:	CFT
Classification:	ECD
Component:	General (show other bugs)
Version:	1.0.3
Hardware:	PC Windows 7

Importance:	P3 normal
Target Milestone:	1.0.3
Assignee:	Jonathan West
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2017-01-20 09:58 EST by Jonathan West
Modified:	2017-01-27 18:08 EST (History)
CC List:	1 user (show)

See Also:	Pull Request

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jonathan West

2017-01-20 09:58:07 EST

When an HTTP request returns an error code (4XX/5XX), it is processed by CloudControllerResponseErrorHandler (CCREH). On 4XX error codes, CCREH parses the 'description' json out of the body and returns it, whereas with 5XX it just returns the error code.  

There are some error cases where 5XX return codes do contain a description field, and these can be included in the exception message to provide information to the user.

Comment 1 Eclipse Genie

2017-01-20 11:21:13 EST

GitHub Pull Request 49 created by [jgwest]
https://github.com/eclipse/cft/pull/49

Comment 2 Nieraj Singh

2017-01-26 15:08:46 EST

I pushed a new CF Java client 1.1.4.20170126 that includes support for this fix.

I also merged the associated PR in CFT.

If possible, please verify that the new Java client and merged code in CFT master works as expected when handling 5xx server errors.

Comment 3 Jonathan West

2017-01-27 18:08:03 EST

I have verified the fix in the latest Eclipse CFT nightly build. Thanks Nieraj!