This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 510595 - Add http://www.w3.org/TR/xmldsig-core/xmldsig-core-schema.xsd to the XML Catalog
Summary: Add http://www.w3.org/TR/xmldsig-core/xmldsig-core-schema.xsd to the XML Catalog
Status: CLOSED FIXED
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: wst.xml (show other bugs)
Version: 3.8   Edit
Hardware: PC Mac OS X
: P3 normal (vote)
Target Milestone: 3.9 RC3   Edit
Assignee: Keith Chong CLA
QA Contact: Nick Sandonato CLA
URL:
Whiteboard: PMC_approved
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-17 13:26 EST by Keith Chong CLA
Modified: 2017-06-06 10:43 EDT (History)
10 users (show)

See Also:
keith.chong.ca: pmc_approved? (david_williams)
keith.chong.ca: pmc_approved? (raghunathan.srinivasan)
keith.chong.ca: pmc_approved? (naci.dai)
keith.chong.ca: pmc_approved? (neil.hauge)
keith.chong.ca: pmc_approved? (cbridgha)
keith.chong.ca: pmc_approved? (ccc)
vrubezhny: pmc_approved+
thatnitind: review+
nsand.dev: review+

Attachments
Patch applied to org.eclipse.wst.standard.schemas (11.96 KB, patch)
2017-05-24 15:21 EDT, Keith Chong CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Chong CLA 2017-01-17 13:26:47 EST 
Here's yet another referenced file contains errors XML validator issue.

Although the preference was added to ignore these types of errors (See bug 491313), I'm seeing a problem where the fix to the error is to simply add two schemas to the XML Catalog.

http://docs.oasis-open.org/wss/2004/01/oasis-200401-wss-wssecurity-secext-1.0.xsd

and

http://www.w3.org/TR/xmldsig-core/xmldsig-core-schema.xsd
Comment 1 Keith Chong CLA 2017-05-24 15:21:33 EDT 
Created attachment 268557 [details]
Patch applied to org.eclipse.wst.standard.schemas
Comment 2 Nitin Dahyabhai CLA 2017-05-24 15:53:14 EDT 
Looks good to me. Should have zero impact on code stability, and both the POM and manifest are handled in the proposed change.
Comment 3 Keith Chong CLA 2017-05-24 16:00:40 EDT 
To clarify, the patch is to add xmldsig-core-schema.xsd to the XML catalog.   The other schema is not needed.
Comment 4 Keith Chong CLA 2017-05-24 16:18:26 EDT 
1. Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such.

Adopter requested.

2. Is there a work-around? If so, why do you believe the work-around is insufficient?
There is a work-around.  Can add the schema to the catalog myself, but this is the proper place to do it.

3. How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added?
Fix has been tested with adopter product and it does work.   No JUnit test specific to adding the schema to the catalog is available.

4. Give a brief technical overview. Who has reviewed this fix?
Simply adding the schema to the XML catalog by using the catalog extension point.
Nitin just reviewed it.

5. What is the risk associated with this fix?
Low risk
Comment 5 Keith Chong CLA 2017-05-24 17:14:53 EDT 
CQ:

https://dev.eclipse.org/ipzilla/show_bug.cgi?id=13590
Comment 6 Nick Sandonato CLA 2017-05-25 14:50:11 EDT 
Looks good. +1
Comment 7 Victor Rubezhny CLA 2017-05-30 15:09:21 EDT 
The CQ #13590 is approved: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=13590

The fix looks good, +1
Comment 8 Eclipse Genie CLA 2017-06-01 14:52:46 EDT 
New Gerrit change created: https://git.eclipse.org/r/98464
Comment 10 Keith Chong CLA 2017-06-01 15:03:20 EDT 
Fix has been merged.  Verify in RC3 respin build.
Comment 11 Keith Chong CLA 2017-06-06 10:42:51 EDT 
Verified in respin build: I-3.9.0-20170606000115
Comment 12 Keith Chong CLA 2017-06-06 10:43:12 EDT 
Closing