Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 509866 - Validation of interpreted expression is not triggered on some of the properties.ecore types
Summary: Validation of interpreted expression is not triggered on some of the properti...
Status: CLOSED FIXED
Alias: None
Product: Sirius
Classification: Modeling
Component: Properties (show other bugs)
Version: 4.1.0   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 5.0.0   Edit
Assignee: Project Inbox CLA
QA Contact: Jessy Mallet CLA
URL:
Whiteboard: backport, needtest
Keywords:
Depends on:
Blocks: 509912
  Show dependency tree
 
Reported: 2017-01-03 11:13 EST by Cedric Brun CLA
Modified: 2017-06-29 03:33 EDT (History)
3 users (show)

See Also:

Attachments
Archived VSM project (6.24 KB, application/zip)
2017-01-03 11:13 EST, Cedric Brun CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cedric Brun CLA 2017-01-03 11:13:21 EST 
Created attachment 266100 [details]
Archived VSM project

Steps to reproduce: 
- import the project, validate the .odesign
=> result: validation is ok

expected result: we should get a validation error on the "Value expression" of the "Class" list widget as the expression refers to a non existing service: 

aql:self.nonExistingService(ecore::EClass)
Comment 1 Eclipse Genie CLA 2017-01-04 08:12:55 EST 
New Gerrit change created: https://git.eclipse.org/r/87992
Comment 3 Pierre-Charles David CLA 2017-01-11 16:01:12 EST 
Fixed by 0ae9613cadd1d8164666e6c4e813fb503920a760, but currently missing an automated regression test.
Comment 4 Cedric Brun CLA 2017-01-12 03:19:10 EST 
(In reply to Pierre-Charles David from comment #3)
> Fixed by 0ae9613cadd1d8164666e6c4e813fb503920a760, but currently missing an
> automated regression test.

I can't check right now but I think PropertiesVSMExpressionValidationTest would fail if you remove the one liner in SiriusUIPropertiesPlugin
Comment 5 Pierre-Charles David CLA 2017-01-12 03:35:27 EST 
(In reply to Cedric Brun from comment #4)
> (In reply to Pierre-Charles David from comment #3)
> > Fixed by 0ae9613cadd1d8164666e6c4e813fb503920a760, but currently missing an
> > automated regression test.
> 
> I can't check right now but I think PropertiesVSMExpressionValidationTest
> would fail if you remove the one liner in SiriusUIPropertiesPlugin

I'll need to analyse further, but the on my machine, the test is green with or without the "EValidator.Registry.INSTANCE.put(PropertiesPackage.eINSTANCE, new EValidatorAdapter());" line in SiriusUIPropertiesPlugin.
Comment 6 Cedric Brun CLA 2017-01-12 10:03:24 EST 
> I'll need to analyse further, but the on my machine, the test is green with
> or without the
> "EValidator.Registry.INSTANCE.put(PropertiesPackage.eINSTANCE, new
> EValidatorAdapter());" line in SiriusUIPropertiesPlugin.

I confirm this, my bad.
Comment 7 Jessy Mallet CLA 2017-05-15 12:16:57 EDT 
Validated with Sirius 5.0.0.201705121003
Comment 8 Eclipse Genie CLA 2017-05-16 05:56:53 EDT 
New Gerrit change created: https://git.eclipse.org/r/97202
Comment 10 Jessy Mallet CLA 2017-05-19 05:51:02 EDT 
Validated with Sirius 5.0.0.201705151305
Comment 11 Pierre-Charles David CLA 2017-05-19 05:52:20 EDT 
Verified by Jessy.
Comment 12 Pierre-Charles David CLA 2017-06-29 03:33:21 EDT 
Available in Sirius 5.0.0, see https://wiki.eclipse.org/Sirius/5.0.0 for details.