Community
Participate
Working Groups
The comparator errors occurred as the build was updated to use a newer version of jdt. The components with comparator errors need to be touched. --> http://download.eclipse.org/eclipse/downloads/drops4/I20161221-2000/buildlogs/comparatorlogs/buildtimeComparatorUnanticipated.log.txt
Same comparator errors in build I20161222-2000.
(In reply to comment #1) > Same comparator errors in build I20161222-2000. I'll check the diffs and confirm if the bundles just need to be touched or there's a problem in the compiler
All diffs indicate a change in the order of bridge methods generated, which is harmless, but I cannot locate a commit that could have caused this. What is the baseline used for comparison- M4 or an earlier version? Is it possible the baseline being used is not the right one, because I remember seeing similar comparator errors a while ago?
The build was using M2 before being updated to M4.
The JDT update for the build has been reverted so that the builds can continue without comparator errors. So, no action is required from components. It'll be updated again to the newer version in January.
(In reply to Lakshmi Shanmugam from comment #4) > The build was using M2 before being updated to M4. Sasi, please double-check whether there was no bridge method related change between M2 and M4.
(In reply to Dani Megert from comment #6) > Sasi, please double-check whether there was no bridge method related change > between M2 and M4. The only changes I see in that area is related to bugs 509782 and 507011. Not sure if these are causing the issue. If the SWT team can point to the concerned files, we can take a close look.
(In reply to Jay Arthanareeswaran from comment #7) > (In reply to Dani Megert from comment #6) > > Sasi, please double-check whether there was no bridge method related change > > between M2 and M4. > > The only changes I see in that area is related to bugs 509782 and 507011. > Not sure if these are causing the issue. > > If the SWT team can point to the concerned files, we can take a close look. Jay, the comparator errors are not in SWT, but affects most of the components. Sasi, can you please attach the log file which has the comparator errors (the link in comment#0 no longer works.)
The commit that is causing is: http://git.eclipse.org/c/jdt/eclipse.jdt.core.git/commit/?id=be38b3a33bed71536fe8159c751306e381671293 from bug 501283. The change was about improving our hashing methods for char[] and being used within JDT Core in several places, including code generation. I am fine with the change remaining and letting the components be touched. Sasi, can you glance and confirm too?
(In reply to comment #9) > The commit that is causing is: > > http://git.eclipse.org/c/jdt/eclipse.jdt.core.git/commit/?id=be38b3a33bed71536fe8159c751306e381671293 > > from bug 501283. The change was about improving our hashing methods for char[] > and being used within JDT Core in several places, including code generation. > > I am fine with the change remaining and letting the components be touched. > > Sasi, can you glance and confirm too? aah... I was looking for the wrong thing and hence couldn't find it. I'm ok with the change too. I went through most of the diffs and found out that the order is the only difference, so it should be ok to touch the affected bundles
Since these are expected failures I am resolving as works for me
(In reply to Sravan Kumar Lakkimsetti from comment #11) > Since these are expected failures I am resolving as works for me They are fixed via bug 509973.
