This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 509412 - Update to JSch 0.1.54 for CVE fix
Summary: Update to JSch 0.1.54 for CVE fix
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 4.6   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.6.3   Edit
Assignee: Alexander Kurtakov CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 512103
Blocks: 512186
  Show dependency tree
 
Reported: 2016-12-19 03:39 EST by Alexander Kurtakov CLA
Modified: 2017-02-16 08:34 EST (History)
7 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Kurtakov CLA 2016-12-19 03:39:58 EST
Release 0.1.54 contains fix for CVE CVS-2016-5725 (jsch recursive sftp get client-side windows path traversal). See http://www.jcraft.com/jsch/ChangeLog for details. We have to adopt it ASAP to not ship potential exploits.
Comment 1 Alexander Kurtakov CLA 2017-01-10 02:30:34 EST
Sergey, would you please file the CQ . I'll make sure to provide all the needed patches for that.
Comment 2 Sergey Prigogin CLA 2017-01-10 10:44:29 EST
(In reply to Alexander Kurtakov from comment #1)
> Sergey, would you please file the CQ . I'll make sure to provide all the
> needed patches for that.

Hmm... Can't you file the CQ yourself?
Comment 3 Alexander Kurtakov CLA 2017-01-10 10:54:20 EST
No, only committer on the project can do it.
Comment 4 Sergey Prigogin CLA 2017-01-10 11:05:52 EST
Can you provide info for the CQ?
Comment 5 Alexander Kurtakov CLA 2017-01-10 11:40:49 EST
So I was wrong. I was able to open one after the cq opening moved to PMI.
https://dev.eclipse.org/ipzilla/show_bug.cgi?id=12480
Comment 6 Dani Megert CLA 2017-01-10 11:54:48 EST
(In reply to Alexander Kurtakov from comment #5)
> So I was wrong. I was able to open one after the cq opening moved to PMI.

How did you do it? Were you able to choose the project? Because AFAIK the committer tools don't appear if you aren't a committer.
Comment 7 Alexander Kurtakov CLA 2017-01-10 12:21:11 EST
(In reply to Dani Megert from comment #6)
> (In reply to Alexander Kurtakov from comment #5)
> > So I was wrong. I was able to open one after the cq opening moved to PMI.
> 
> How did you do it? Were you able to choose the project? Because AFAIK the
> committer tools don't appear if you aren't a committer.

Committer tools were not appearing in the old UI and they are not showing for projects I have no affiliation with in PMI too (e.g. technology.egit). But when going to https://projects.eclipse.org/projects/eclipse.platform.resources/developer I have the committer tools. Maybe this power was granted to PMC members or smth like that after latest updates but I don't have time to investigate it further.
Comment 8 Dani Megert CLA 2017-01-10 12:29:07 EST
(In reply to Alexander Kurtakov from comment #7)
> (In reply to Dani Megert from comment #6)
> > (In reply to Alexander Kurtakov from comment #5)
> > > So I was wrong. I was able to open one after the cq opening moved to PMI.
> > 
> > How did you do it? Were you able to choose the project? Because AFAIK the
> > committer tools don't appear if you aren't a committer.
> 
> Committer tools were not appearing in the old UI and they are not showing
> for projects I have no affiliation with in PMI too (e.g. technology.egit).
> But when going to
> https://projects.eclipse.org/projects/eclipse.platform.resources/developer I
> have the committer tools. Maybe this power was granted to PMC members or
> smth like that after latest updates but I don't have time to investigate it
> further.

I think so, because even in the old committer tools PMC members can masquerade for any project under the PMC.
Comment 9 Alexander Kurtakov CLA 2017-01-10 12:33:34 EST
(In reply to Dani Megert from comment #8)
> (In reply to Alexander Kurtakov from comment #7)
> > (In reply to Dani Megert from comment #6)
> > > (In reply to Alexander Kurtakov from comment #5)
> > > > So I was wrong. I was able to open one after the cq opening moved to PMI.
> > > 
> > > How did you do it? Were you able to choose the project? Because AFAIK the
> > > committer tools don't appear if you aren't a committer.
> > 
> > Committer tools were not appearing in the old UI and they are not showing
> > for projects I have no affiliation with in PMI too (e.g. technology.egit).
> > But when going to
> > https://projects.eclipse.org/projects/eclipse.platform.resources/developer I
> > have the committer tools. Maybe this power was granted to PMC members or
> > smth like that after latest updates but I don't have time to investigate it
> > further.
> 
> I think so, because even in the old committer tools PMC members can
> masquerade for any project under the PMC.

I know about masquerading but there was nothing like that involved, it was just there for me to use.
Comment 10 Martin Oberhuber CLA 2017-01-17 11:38:17 EST
The CQ as well as the add-to-orbit are now approved:
https://dev.eclipse.org/ipzilla/show_bug.cgi?id=12524
Comment 11 Alexander Kurtakov CLA 2017-01-17 11:41:26 EST
Roland, please let us know when new Orbit I-build with it is ready.
Comment 12 Markus Keller CLA 2017-01-17 12:41:24 EST
FWIW, I can confirm that I don't have a "Committer Tools" link on https://projects.eclipse.org/projects/eclipse.platform.resources/developer , and
https://projects.eclipse.org/projects/eclipse.platform.resources/ipzilla/ajax/add correctly gives a "403 - Access denied" for me (non-committer, non-PMC)
Comment 13 Roland Grunberg CLA 2017-01-17 12:44:58 EST
I've promoted I20170117172928 to the Orbit Downloads page (http://download.eclipse.org/tools/orbit/downloads/) under the Integration builds. This should contain com.jcraft.jsch 0.1.54.

The download page for I20170117172928 : http://download.eclipse.org/tools/orbit/downloads/drops/I20170117172928/

The p2 repository is : http://download.eclipse.org/tools/orbit/downloads/drops/I20170117172928/repository

Note that I will also be creating an S-build by the end of the week as Orbit's contribution to Oxygen M5.
Comment 14 Dani Megert CLA 2017-01-17 12:54:07 EST
We should also put this into 4.6.3.
Comment 15 Eclipse Genie CLA 2017-01-17 14:06:34 EST
New Gerrit change created: https://git.eclipse.org/r/88893
Comment 17 Dani Megert CLA 2017-02-07 04:57:05 EST
(In reply to Dani Megert from comment #14)
> We should also put this into 4.6.3.

Ping!
Comment 18 Alexander Kurtakov CLA 2017-02-07 12:42:55 EST
I would not be able to work on this for 4.6.3. Checked with Roland (Orbit lead) there is no maintenance builds anymore so there are two paths - either move to latest Orbit build if everything needed is there or use two different orbit repos where only latest jsch is referred to from the new one.
It would be nice of platform.team committer takes this further and fix it for 4.6.3.
Comment 19 Dani Megert CLA 2017-02-10 10:23:08 EST
(In reply to Alexander Kurtakov from comment #18)
> I would not be able to work on this for 4.6.3. Checked with Roland (Orbit
> lead) there is no maintenance builds anymore

Do you have a bug report or mailing list where this has been decided? It seems very wrong. This probably needs to be escalated. There will always be bundles that need to be updated in an update release. And up to Neon there were Orbit builds for the maintenance releases, see http://download.eclipse.org/tools/orbit/downloads/
Comment 20 Alexander Kurtakov CLA 2017-02-10 13:26:50 EST
(In reply to Dani Megert from comment #19)
> (In reply to Alexander Kurtakov from comment #18)
> > I would not be able to work on this for 4.6.3. Checked with Roland (Orbit
> > lead) there is no maintenance builds anymore
> 
> Do you have a bug report or mailing list where this has been decided? It
> seems very wrong. This probably needs to be escalated. There will always be
> bundles that need to be updated in an update release. And up to Neon there
> were Orbit builds for the maintenance releases, see
> http://download.eclipse.org/tools/orbit/downloads/

No, I don't have such reference. IMHO, we should move towards single stream of development as there is no manpower to handle multiple and we should deliver faster to users. Anyway, I'm adding Roland on CC for more info.
Comment 21 Sravan Kumar Lakkimsetti CLA 2017-02-13 04:35:04 EST
Bug 512103 has been raised to get new cotribution from Orbit with jsch 0.1.54
Comment 22 Eclipse Genie CLA 2017-02-13 05:02:49 EST
New Gerrit change created: https://git.eclipse.org/r/90925
Comment 24 Sravan Kumar Lakkimsetti CLA 2017-02-14 01:26:29 EST
(In reply to Eclipse Genie from comment #23)
> Gerrit change https://git.eclipse.org/r/90925 was merged to
> [R4_6_maintenance].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/
> commit/?id=45169814110c04e8a836f0a08fc68c65dedf1740

Workaround has been pushed
Comment 25 Dani Megert CLA 2017-02-14 10:32:07 EST
I've tested ssh Git and CVS with M20170214-0330 and it worked.
Comment 26 Dani Megert CLA 2017-02-14 11:45:11 EST
Filed bug 512186 to switch to an R Orbit repo.
Comment 27 Dani Megert CLA 2017-02-16 08:34:43 EST
Verified in M20170215-0400.