508138 – Dangling reference on DNode.outgoingEdges and incomingEdges after undo on Edge creation tool

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 508138 - Dangling reference on DNode.outgoingEdges and incomingEdges after undo on Edge creation tool

Summary: Dangling reference on DNode.outgoingEdges and incomingEdges after undo on Edg...

Status:	CLOSED FIXED

Alias:	None

Product:	Sirius
Classification:	Modeling
Component:	Core (show other bugs)
Version:	2.0.0
Hardware:	PC Linux

Importance:	P3 normal (vote)
Target Milestone:	4.1.2
Assignee:	Project inbox
QA Contact:	Pierre-Charles David

URL:
Whiteboard:
Keywords:

Depends on:	508106 508164
Blocks:	508135
	Show dependency tree

Reported:	2016-11-24 11:28 EST by Florian Barbin
Modified:	2016-12-08 11:13 EST (History)
CC List:	1 user (show)

See Also:	Gerrit Change Git Commit Gerrit Change Git Commit

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Florian Barbin

2016-11-24 11:28:58 EST

+++ This bug was initially created as a clone of Bug #508106 +++

Steps to reproduce:

* Import the attached test case and open the diagram "new Package"
* Create an edge between ClassA and ClassB with the edge creation tool.
* The edge is removed by the refresh => OK
* Perform undo
* With the Model requests interpreter view, select the ClassA Node and test this expression: aql:self.getOutgoingEdges
* A DEdge (detached from its parent) appears => KO

Comment 1 Eclipse Genie

2016-11-24 12:02:16 EST

New Gerrit change created: https://git.eclipse.org/r/85709

Comment 2 Eclipse Genie

2016-11-25 04:00:12 EST

Gerrit change https://git.eclipse.org/r/85709 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=1353d01ae1997a7f814c9f8c464835a47dcf44e2

Comment 3 Eclipse Genie

2016-11-25 10:46:41 EST

New Gerrit change created: https://git.eclipse.org/r/85783

Comment 4 Eclipse Genie

2016-11-28 05:18:24 EST

Gerrit change https://git.eclipse.org/r/85783 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=1d35e75cdcdbd7fe51fbad08c6a5cbdb5ea48453

Comment 5 Pierre-Charles David

2016-12-01 09:43:38 EST

Verified on Sirius 4.1.2rc1. Note that the sample VSM attached to reproduce uses the old legacy query language. File plugins/org.eclipse.sirius.tests.junit/data/unit/tools/undoEdgeCreationToolDangling/dEdgeUndoDangling.odesign in the Sirius sources can be used instead, it's the same modeler remade using core interpreters.

Comment 6 Pierre-Charles David

2016-12-08 11:13:06 EST

Available in Sirius 4.1.2 (see https://wiki.eclipse.org/Sirius/4.1.2 for details).