507681 – Busy (italic) and Changed (bold) notifications in view title missing when theming is disabled

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 507681 - Busy (italic) and Changed (bold) notifications in view title missing when theming is disabled

Summary: Busy (italic) and Changed (bold) notifications in view title missing when the...

Status:	RESOLVED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	4.7
Hardware:	All All

Importance:	P3 major (vote)
Target Milestone:	4.6.3
Assignee:	Andrey Loskutov
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2016-11-17 08:45 EST by Markus Keller
Modified:	2017-01-19 01:58 EST (History)
CC List:	3 users (show)

See Also:	440086 484156 446860 Gerrit Change Git Commit Gerrit Change Git Commit

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Markus Keller

2016-11-17 08:45:51 EST

I20161116-2000

Busy (italic) and Changed (bold) notifications in the view title are missing when theming is disabled. (Bug 440086 and bug 446860 are the same for classic themes).

Steps that don't require installing special tools to reproduce:
- select a few projects that contain a few 100'000 lines of text (e.g. import all org.apache.* bundles as source)
- Search > File... for regex "(a.*){0,10}\R" (slow, but shouldn't take forever)
- activate the Problems view

=> Expected: Search view should first be italic, and when search is done, it should become bold.
=> Was: View titles don't show progress.

Comment 1 Markus Keller

2016-12-21 13:03:55 EST

Another possibly related bug is bug 484156.

Maybe the part title notifications are just implemented in the wrong layer in E4? They should be independent of theming.

Comment 2 Eclipse Genie

2016-12-31 18:04:45 EST

New Gerrit change created: https://git.eclipse.org/r/87851

Comment 3 Eclipse Genie

2017-01-02 13:54:57 EST

Gerrit change https://git.eclipse.org/r/87851 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=a33353c3225622d50a89ab7fb921532d450014be

Comment 4 Eclipse Genie

2017-01-03 14:08:06 EST

New Gerrit change created: https://git.eclipse.org/r/87962

Comment 5 Andrey Loskutov

2017-01-03 14:10:50 EST

(In reply to Eclipse Genie from comment #4)
> New Gerrit change created: https://git.eclipse.org/r/87962

Patch for 4.6.3.

Actually I always use Eclipse without themes, and I wonder why I haven't realized yet that this highlighting was always missing in this mode. Now that I see what I've missed I would like to backport this change to 4.6.3 too.

@Markus, Lars, do you mind to review the patch for 4.6.3? I need approval for backporting too.

Comment 6 Lars Vogel

2017-01-10 15:06:20 EST

(In reply to Andrey Loskutov from comment #5)
> @Markus, Lars, do you mind to review the patch for 4.6.3? I need approval
> for backporting too.

+1 from project lead for downport if Markus or another committer does the technical validation.

Comment 7 Eclipse Genie

2017-01-19 01:57:59 EST

Gerrit change https://git.eclipse.org/r/87962 was merged to [R4_6_maintenance].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=a6cf96f307814c07bd28a8da1d0b3694c8f6d879

Comment 8 Andrey Loskutov

2017-01-19 01:58:49 EST

Thanks Brian for review, merged to 4.6.3.