Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 506938 - NPE on relinking to Web project
Summary: NPE on relinking to Web project
Status: CLOSED FIXED
Alias: None
Product: CFT
Classification: ECD
Component: General (show other bugs)
Version: 1.0.2   Edit
Hardware: PC Windows 7
: P3 normal
Target Milestone: 1.0.2   Edit
Assignee: Jonathan West CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-02 16:35 EDT by Jonathan West CLA
Modified: 2016-11-17 16:20 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan West CLA 2016-11-02 16:35:00 EDT 
When linking an unlinked project, that was previously linked to a local workbench project, an NPE will occur. In this scenario CloudFoundryApplicationModule is returning null in getLocalModule(...), when it should instead return a reference to itself (which is the standard behaviour for an 'external module', that is, one that does not exist in the workspace).

When this issue occurs, the following NPE is seen:

org.eclipse.core.runtime.CoreException: null
	at org.eclipse.wst.server.core.internal.ServerWorkingCopy.modifyModules(ServerWorkingCopy.java:612)
	at org.eclipse.wst.server.core.ServerUtil.modifyModules(ServerUtil.java:398)
	at org.eclipse.cft.server.ui.internal.actions.MapToProjectOperation.doMap(MapToProjectOperation.java:131)
	at org.eclipse.cft.server.ui.internal.actions.MapToProjectOperation.map(MapToProjectOperation.java:105)
	at org.eclipse.cft.server.ui.internal.actions.MapToProjectOperation.run(MapToProjectOperation.java:81)
	at org.eclipse.cft.server.ui.internal.actions.UpdateMappingCommand$1.run(UpdateMappingCommand.java:44)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)
Caused by: java.lang.NullPointerException
	at org.eclipse.wst.server.core.internal.Server.getKey(Server.java:3082)
	at org.eclipse.wst.server.core.internal.Server.setModulePublishState(Server.java:866)
	at org.eclipse.wst.server.core.internal.ServerWorkingCopy.setModulePublishState(ServerWorkingCopy.java:135)
	at org.eclipse.cft.server.core.internal.CloudFoundryServer.updateState(CloudFoundryServer.java:151)
	at org.eclipse.cft.server.core.internal.CloudFoundryServer.replace(CloudFoundryServer.java:726)
	at org.eclipse.cft.server.core.internal.CloudFoundryServer.modifyModules(CloudFoundryServer.java:579)
	at org.eclipse.wst.server.core.internal.ServerWorkingCopy.modifyModules(ServerWorkingCopy.java:553)
	... 6 more
!SUBENTRY 1 org.eclipse.wst.server.core 4 0 2016-11-02 16:29:48.512
!MESSAGE null
!STACK 0
java.lang.NullPointerException
	at org.eclipse.wst.server.core.internal.Server.getKey(Server.java:3082)
	at org.eclipse.wst.server.core.internal.Server.setModulePublishState(Server.java:866)
	at org.eclipse.wst.server.core.internal.ServerWorkingCopy.setModulePublishState(ServerWorkingCopy.java:135)
	at org.eclipse.cft.server.core.internal.CloudFoundryServer.updateState(CloudFoundryServer.java:151)
	at org.eclipse.cft.server.core.internal.CloudFoundryServer.replace(CloudFoundryServer.java:726)
	at org.eclipse.cft.server.core.internal.CloudFoundryServer.modifyModules(CloudFoundryServer.java:579)
	at org.eclipse.wst.server.core.internal.ServerWorkingCopy.modifyModules(ServerWorkingCopy.java:553)
	at org.eclipse.wst.server.core.ServerUtil.modifyModules(ServerUtil.java:398)
	at org.eclipse.cft.server.ui.internal.actions.MapToProjectOperation.doMap(MapToProjectOperation.java:131)
	at org.eclipse.cft.server.ui.internal.actions.MapToProjectOperation.map(MapToProjectOperation.java:105)
	at org.eclipse.cft.server.ui.internal.actions.MapToProjectOperation.run(MapToProjectOperation.java:81)
	at org.eclipse.cft.server.ui.internal.actions.UpdateMappingCommand$1.run(UpdateMappingCommand.java:44)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)
Comment 1 Eclipse Genie CLA 2016-11-02 16:49:36 EDT 
GitHub Pull Request 47 created by [jgwest]
https://github.com/eclipse/cft/pull/47
Comment 2 Jonathan West CLA 2016-11-17 16:20:38 EST 
Verified.