Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 50438 - [RCP] Progress view icon "area" shows even if setShowStatusLine(false) is called
Summary: [RCP] Progress view icon "area" shows even if setShowStatusLine(false) is called
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal with 1 vote (vote)
Target Milestone: 3.0   Edit
Assignee: Stefan Xenos CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-01-22 17:59 EST by Jed Anderson CLA
Modified: 2004-09-14 09:19 EDT (History)
2 users (show)

See Also:


Attachments
Screenshot of the mentioned problem (23.76 KB, image/png)
2004-01-22 18:00 EST, Jed Anderson CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jed Anderson CLA 2004-01-22 17:59:50 EST
Build: M6

If I call IWorkbenchWindowConfigurer.setShowStatusLine(false) in my
WorkbenchAdvisor's preWindowOpen(IWorkbenchConfigurer) method the status line is
hidden.  BUT, the action with a tooltip of "Double click to open Progress View"
which appears in the bottom left of the window still shows.  The action is
missing/can't find its icon so it just shows as empty screen space, but it shows
over views that I put on the left side of the window.
Comment 1 Jed Anderson CLA 2004-01-22 18:00:37 EST
Created attachment 7532 [details]
Screenshot of the mentioned problem

I have circled the problem in red.
Comment 2 Jed Anderson CLA 2004-01-22 18:04:47 EST
Ah, the icon is not missing, it just doesn't show until it has progress to
report.  So the only real bug is that it's there.
Comment 3 Tod Creasey CLA 2004-01-23 16:02:57 EST
This should be addressed in the updated layouts in New Look
Comment 4 Nick Edgar CLA 2004-01-29 15:24:54 EST
Any chance this could be fixed in HEAD for M7?
If needed, we can add get/setShowProgressIndicator(boolean) methods to 
IWorkbenchWindowConfigurer.
Comment 5 Tod Creasey CLA 2004-01-29 16:04:14 EST
See showProgressIndicator() in WorkbenchWindow

It gets this from a preference

return PlatformUI.getWorkbench().getPreferenceStore().getBoolean(
			IWorkbenchConstants.SHOW_PROGRESS_INDICATOR);

You could just set this preference in your method
Comment 6 Nick Edgar CLA 2004-01-29 17:05:45 EST
Added IWorkbenchWindowConfigurer.get/setShowProgressIndicator(boolean), with 
its default state obtained from the 
IWorkbenchPreferences.SHOULD_SHOW_PROGRESS_INDICATOR setting (same as with the 
other bars).
Deleted the internal IWorkbenchConstants.SHOW_PROGRESS_INDICATOR.
Fixed up the window layout so that the status line is not indented when neither 
the progress indicator nor the shortcut bar are showing.
Changed the default for the SHOW_PROGRESS_INDICATOR and SHOW_SHORTCUT_BAR prefs 
to false, so that RCP apps don't get these by default.
Changed IDEWorkbenchAdvisor to show the progress indicator and shortcut bar in 
the SDK.

Comment 7 Nick Edgar CLA 2004-01-29 17:10:17 EST
Fixed in HEAD.  Need to ensure that it's fixed in the new look stream as well 
for the case where both the shortcut bar and progress indicator are hidden.
Comment 8 Tod Creasey CLA 2004-02-11 18:20:44 EST
Moving to stefan to verify that there are no new look trim regressions
Comment 9 Nick Edgar CLA 2004-09-14 09:19:55 EDT
This was fixed in 3.0.