Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 502160 - [All Diagrams] NPE on undo of "line color" appearance attribute
Summary: [All Diagrams] NPE on undo of "line color" appearance attribute
Status: CLOSED FIXED
Alias: None
Product: Papyrus
Classification: Modeling
Component: Table (show other bugs)
Version: 2.0.1   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.0.0   Edit
Assignee: Nicolas FAUVERGUE CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-26 09:36 EDT by Johan Van Noten CLA
Modified: 2017-06-19 06:53 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Johan Van Noten CLA 2016-09-26 09:36:10 EDT 
Environment: Papyrus Nightly 20160923

Scenario:
* Draw Activity Diagram
* Add one OpaqueAction, having one OutputPin
* Select the pin, goto appearance tab
* Change the linecolor, observe the color changing.
* Click on the diagram (so the selection disappears) (*****)
* Press Ctrl-Z to undo the change of color.
--> Error dialog:
Abnormal Workbench Condition
java.lang.NullPointerException


When you leave out the step (*****) above, so remaining within the properties dialog and therefore keeping the selection, the issue does not occur and the undo works fine.
Comment 1 Mickael ADAM CLA 2016-09-27 11:22:29 EDT 
can be reproduce on every uml element and which others properties from appearance tab. Appears to come from a dispose command which can't be undone.
Comment 2 Eclipse Genie CLA 2016-09-28 04:20:44 EDT 
New Gerrit change created: https://git.eclipse.org/r/82051
Comment 4 Vincent Lorenzo CLA 2016-09-29 07:20:54 EDT 
This bug can now be marked as closed fixed.
Comment 5 Klaas Gadeyne CLA 2016-09-29 08:56:21 EDT 
(In reply to vincent lorenzo from comment #4)
> This bug can now be marked as closed fixed.

Is there a reason not to fix this on 2.0?
Comment 6 Eclipse Genie CLA 2016-09-29 10:22:03 EDT 
New Gerrit change created: https://git.eclipse.org/r/82182
Comment 7 Eclipse Genie CLA 2016-09-29 11:04:21 EDT 
Gerrit change https://git.eclipse.org/r/82182 was merged to [streams/2.0-maintenance].
Commit: http://git.eclipse.org/c/papyrus/org.eclipse.papyrus.git/commit/?id=04f448ed73f9e0186b31132b097b45da7f7d7291
Comment 8 Vincent Lorenzo CLA 2016-09-29 11:04:55 EDT 
(In reply to Klaas Gadeyne from comment #5)
> (In reply to vincent lorenzo from comment #4)
> > This bug can now be marked as closed fixed.
> 
> Is there a reason not to fix this on 2.0?

Done on 2.0