Community
Participate
Working Groups
The Junit-icons are still provided in GIF format. SVGs and rendered normal and high resolution PNGs should be provided.
New Gerrit change created: https://git.eclipse.org/r/81213
New Gerrit change created: https://git.eclipse.org/r/81214
Created attachment 264195 [details] Comparison of old ( left ) and new ( right )
Created attachment 264196 [details] Comparison of old ( left ) and new ( right ) wizard banner icons
Thanks, Matthias. I will have a look at the png icons and provide feedback. Please confirm that you have taken bug 465456 into consideration while uploading the patches (for bug 501577 and bug 501592 as well) and done the preliminary testing for the same.
I can confirm that I did not delete the old GIFs for views declared in the plugin.xml. I also did a quick manual test of all my changes.
Created attachment 264300 [details] Comparison of old ( left ) and new ( right )
(In reply to Matthias Becker from comment #4) > Created attachment 264196 [details] > Comparison of old ( left ) and new ( right ) wizard banner icons Looks good. (In reply to Matthias Becker from comment #7) > Created attachment 264300 [details] > Comparison of old ( left ) and new ( right ) In general, all the error, failure and success icons don't look good when used in the IDE i.e. the 'x' and 'tick' marks and their enclosing boxes (red, blue, green). - err_ovr: the 'x' is not easily recognizable, looks like 5 dots. - failed_ovr: should be slightly bigger for 'x' to be clearly visible. - failures: the 'x's and the enclosing boxes should be of the same size in red and blue, like the old icon. - juniterr, juniterrq, testerr, tsuiteerror: the 'x' should be slightly smaller and the surrounding red should be darker, similar to the old icons. The red 'x' in 'relaunchf' and 'faillist' is better and can be used for error icons at other places also. - junitsucc, junitsuccq, success_ovr, testok, tsuiteok: there should be more contrast between white and green in the tick mark so that it is clearly visible. - th_automatic, th_horizontal, th_vertical: old icons had green circles but the new icons seem to have green squares instead. - testfile_obj: the letters should be thicker. - new_testsuite, tsuite: the test icon at the back doesn't have the complete border.
Created attachment 264375 [details] revised: Comparison of old ( left ) and new ( right )
(In reply to Noopur Gupta from comment #8) Thanks for your very detailed feedback. I adapted the icons according to your feedback (see details below). Are they ok now? > - err_ovr: the 'x' is not easily recognizable, looks like 5 dots. Done > > - failed_ovr: should be slightly bigger for 'x' to be clearly visible. Done > > - failures: the 'x's and the enclosing boxes should be of the same size in > red and blue, like the old icon. Done > > - juniterr, juniterrq, testerr, tsuiteerror: the 'x' should be slightly > smaller and the surrounding red should be darker, similar to the old icons. Done > > The red 'x' in 'relaunchf' and 'faillist' is better and can be used for > error icons at other places also. Done > > - junitsucc, junitsuccq, success_ovr, testok, tsuiteok: there should be more > contrast between white and green in the tick mark so that it is clearly > visible. Done > > - th_automatic, th_horizontal, th_vertical: old icons had green circles but > the new icons seem to have green squares instead. These are already existing PNGS (rendered from SVG). I did not change anything here. Actually the SVG does use circles but rendered to 16x16 is looks like a square. In the @2x version is more clear. As these icons are already used in a lot of other projects in eclipse I would propose to leave them as they are. > > - testfile_obj: the letters should be thicker. Done > > - new_testsuite, tsuite: the test icon at the back doesn't have the complete > border. Done.
(In reply to Matthias Becker from comment #9) > Created attachment 264375 [details] > revised: Comparison of old ( left ) and new ( right ) Thanks, this looks good. The Gerrit patch for jdt.ui removes: org.eclipse.jdt.junit/icons/full/obj16/testfile_obj.gif This is used in org.eclipse.ui.editors extension in jdt.junit. So it should not be deleted. See bug 465456. Please upload a new patch set which retains testfile_obj.gif.
(In reply to Noopur Gupta from comment #11) > Please upload a new patch set which retains testfile_obj.gif. Done
Gerrit change https://git.eclipse.org/r/81213 was merged to [master]. Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=046c618e0b7b2668566f3c347ef4d83ed987d176
Gerrit change https://git.eclipse.org/r/81214 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.images.git/commit/?id=808975afed2a50f674c2b103929bdb0301d11cda
*** Bug 468946 has been marked as a duplicate of this bug. ***
