Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 498992 - [releng] Dirty git status after build in eclipse.platform.common
Summary: [releng] Dirty git status after build in eclipse.platform.common
Status: CLOSED DUPLICATE of bug 420078
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 4.6   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-Releng-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 420078
  Show dependency tree
 
Reported: 2016-08-01 09:46 EDT by Andrey Loskutov CLA
Modified: 2017-01-04 04:50 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Loskutov CLA 2016-08-01 09:46:53 EDT 
I'm trying to build SDK and I see that after the (failed) build "git status" reports:

Untracked files:
  (use "git add <file>..." to include in what will be committed)

        bundles/org.eclipse.jdt.doc.isv/index/
        bundles/org.eclipse.jdt.doc.user/index/
        bundles/org.eclipse.platform.doc.isv/index/
        bundles/org.eclipse.platform.doc.isv/samples/org.eclipse.compare.examples.xml/
        bundles/org.eclipse.platform.doc.isv/samples/org.eclipse.compare.examples/
        bundles/org.eclipse.platform.doc.isv/samples/org.eclipse.swt.examples.launcher/
        bundles/org.eclipse.platform.doc.isv/samples/org.eclipse.swt.examples.ole.win32/
        bundles/org.eclipse.platform.doc.isv/samples/org.eclipse.swt.examples.views/
        bundles/org.eclipse.platform.doc.isv/samples/org.eclipse.swt.examples/
        bundles/org.eclipse.platform.doc.isv/samples/org.eclipse.team.examples.filesystem/
        bundles/org.eclipse.platform.doc.isv/samples/org.eclipse.ui.examples.fieldassist/
        bundles/org.eclipse.platform.doc.isv/samples/org.eclipse.ui.examples.javaeditor/
        bundles/org.eclipse.platform.doc.isv/samples/org.eclipse.ui.examples.multipageeditor/
        bundles/org.eclipse.platform.doc.isv/samples/org.eclipse.ui.examples.propertysheet/
        bundles/org.eclipse.platform.doc.isv/samples/org.eclipse.ui.examples.readmetool/
        bundles/org.eclipse.platform.doc.isv/samples/org.eclipse.ui.examples.undo/


Ideally this should not happen, build should not create "untracked" files - they either should be deleted if they are temporary artifacts, or ignored. 
I will post a patch with modified .gitignore file in a moment.
Comment 1 Eclipse Genie CLA 2016-08-01 09:58:21 EDT 
New Gerrit change created: https://git.eclipse.org/r/78263
Comment 2 David Williams CLA 2016-08-01 10:10:49 EDT 
Adding them to .gitignore helps in the sense it makes it easier to clean them with 
git clean -fxd (or, something like that) 

BUT, the ideal fix is that we would not change the source tree at all. That if we create something during the build, that we would create it only in the /target directory. Then Tycho itself could clean it up, and makes it realistic that a Tycho build could be "resumed" after an error. 

This is probably a dup of bug 420078. 

I will leave it to others if they want the "quick and easy" fix of adding to .gitignore, or to wait until a better fix is available.
Comment 3 Alexander Kurtakov CLA 2016-08-01 12:11:20 EDT 
To add to what David said - if files in the source tree (aka outside of target/) are added in .gitignore there should also be a configuration that maven-clean-plugin is configured to clean these files in clean stage. Although I also prefer the proper fix to move the build to target/.
Comment 4 Alexander Kurtakov CLA 2017-01-04 04:50:36 EST 
Mark as duplicate

*** This bug has been marked as a duplicate of bug 420078 ***