Community
Participate
Working Groups
Currently breakpoints are not shown in overview ruler by default. This was done via bug 67620, and by all the respect to the original reporter: he isn't using Eclipse anymore :-). I would like to revert change coming from bug 67620, breakpoints should be used in overview rules by default. The original rationale was that they can be mixed with TODO's. Rationale for reverting: 1) breakpoints are most useful "landmarks" in the code, because they indicate the "hot" places with the most attention from the developer. From the usability point of view it is strange not to show most interesting places in the code by default in the overview. 2) The colors for tasks and breakpoints are significantly different, so only very limited number of users with very strong color blindness will be affected (but they will also have difficulties to distinguish between warnings/errors etc marker annotations anyway). 3) We violated the original request from bug 67620 by showing "INFO" markers in the overview ruler by default. Even worse: "INFO" problems use *exact* same color as tasks. Try to open /org.eclipse.jface.text/src/org/eclipse/jface/text/TextViewer.java and find there a task (there is one). I have a trivial patch.
New Gerrit change created: https://git.eclipse.org/r/77907
New Gerrit change created: https://git.eclipse.org/r/77906
+1, makes sense. I also agree that info markers have a bad color; I'll comment on that in bug 498497.
(In reply to Eclipse Genie from comment #1) > New Gerrit change created: https://git.eclipse.org/r/77907 Not required as we have already increased it for 4.7 (In reply to Eclipse Genie from comment #2) > New Gerrit change created: https://git.eclipse.org/r/77906 Patch looks fine, but a general problem I see for Overview markers is that when editor is not maximized, the markers and the real line lumbers are not at the same location. I have attached a snapshot. Breakpoint marker is placed much before the actual line number. It really looks bad to see a breakpoint at a different location and the marker at a different location.
Created attachment 263325 [details] Breakpoint and Overview Marker line location
(In reply to Sarika Sinha from comment #4) > (In reply to Eclipse Genie from comment #2) > > New Gerrit change created: https://git.eclipse.org/r/77906 > Patch looks fine, but a general problem I see for Overview markers is that > when editor is not maximized, the markers and the real line lumbers are not > at the same location. I have attached a snapshot. Breakpoint marker is > placed much before the actual line number. It really looks bad to see a > breakpoint at a different location and the marker at a different location. I have never heard complains about this - all markers are shown in the same way in the overview ruler, not only breakpoints. The overview ruler is never meant to match 1:1 line position, it is for navigation only. During debugging one see the current debug line highlighted anyway.
The position in the overview ruler is fine. As long as the document height doesn't exceed the height of the editor area, the position in the overview ruler is next to the affected line (like in the left/vertical ruler). When the document is longer, the total scroll bar height and the overview ruler both stand for the total document height. In this state, the location of an annotation in the overview ruler no longer matches the actual document lines, but it matches the position in the whole scroll bar. Scroll bars traditionally show a thumb whose height indicates the percentage of the document that is actually visible. As a consequence, the position of the annotation relative to the thumb shows where in the visible editor viewport the annotation can be found.
Gerrit change https://git.eclipse.org/r/77906 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=9ed73a19c85b0cf7c1f48d0dc5fc370f9d9ced61
Delivered to master. Thanks Andrey.
Verified using Eclipse SDK Version: Oxygen (4.7) Build id: I20160731-2000 OS: Windows 7, v.6.1, x86_64 / win32
