Community
Participate
Working Groups
The content assistant support of the Dot Xtext editor should propose the valid attribute names and the valid attribute values considering the current context.
As a preparation step, I pushed the following changes to origin/master: [498324] Move AttributeContext from DotJavaValidator to DotAttributes. - The dot attribute context information is needed not only for validation but also for the content assistant, so move these information into the DotAttributes class.
I pushed the following changes to origin/master: [498324] Improve the Dot Xtext editor content assistant support. - Extend the GenerateDot.mwe2 workflow to generate content assistant support for the dot sub-grammars: DotArrowTypeProposalProvider, DotPointProposalProvider, DotShapeProposalProvider, DotSplineTypeProposalProvider, DotStyleProposalProvider. - Extend the DotProposalProvider class with the content assistant logic for proposing the valid attribute names and the valid attribute values considering the current context. Add the DotProposalProviderDelegator class to delegate the content assistant logic to the proposal provider of the corresponding sub-grammar. - Implement corresponding test cases within the DotContentAssistTest class (should be executed as JUnit Plug-in Test).
I pushed the following changes to origin/master: [498324] Fix failing Dot xtext editor content assistant test cases. - Avoid the presence of different dot grammar instances provided by different Dot injectors (ensure that the dot grammar instance remains singleton during the content assistant test execution). - Inject the DotJavaValidator static field within the DotAttributes class directly instead of using an additionally created dot injector. - Request the injection of the DotAttributes static fields within the DotRuntimeModule configure() method.
The integration of the DotContentAssistTest test cases into the maven build process (should be executed as JUnit Plug-in Test) still has to be done.
I pushed the following changes to origin/master: [498324] Integrate the Content Assist Test Cases into the build process. - Use the tycho surefire plugin to execute the dot plugin ui test cases. - Use the maven surefire plugin to execute the dot junit test cases. - Add explicit dependency to junit to let the maven surefire plugin pick up the test cases properly. Resolving as fixed in 5.0.0 M1.
Why can we not use Tycho Surefire tests alone? I would rather like to have one test infrastructure only.
The Dot Content Assist test cases have been integrated into the already existing Dot Test Suite (has been renamed from AllTests to AllUiTests). The pom.xml file of the dot test bundle has also been adapted to process the AllUiTests test suite using the tycho-surefire plugin with the right parameters: useUIHarness=true, useUIThread=true.
