Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 497207 - http://download.eclipse.org/eclipse/downloads/ page broken for nightly builds
Summary: http://download.eclipse.org/eclipse/downloads/ page broken for nightly builds
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 4.6   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.7 M1   Edit
Assignee: David Williams CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 497030
Blocks:
  Show dependency tree
 
Reported: 2016-07-04 02:13 EDT by Lars Vogel CLA
Modified: 2016-07-04 10:54 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 David Williams CLA 2016-07-04 10:54:53 EDT 
I think giving a proper fix for bug 497030 will fix this issue. 

To outline the issue, and my "debugging technique": 

To debug I looked in in mb080_publish-eclipse_output.txt which ended with an error that said to see the log at 

/opt/public/eclipse/builds/4N/siteDir/eclipse/downloads/drops4/N20160702-1500/workspace-publish/.metadata/.log

And that is where I saw the message quoted in bug 497030 about needing "eclipseStreamMajor" and "eclipseStreamMinor". This sounded familar, since I had just added that "hard fail" while fixing bug 497030. One possible fix is just to remove the "hard fail" -- those variable are probably not needed to publish "index.php" alone. But, I like "hard failures" since they make debugging easier, and I like the idea of "consistent input" since even if not literally needed now, they might be in future? 

= = = = =

So, to fix (i.e. make consistent) ... 

The publication of unit tests are "kicked off" by a script named genTestIndexes.xml -- which did already have the 'eclipseStreamMajor' and 'eclipseStreamMinor' variables needed -- and then it calls publish.xml to do the actual "publishing" of the site pages. 

But, initially, before tests are ran, the "index.php" page generation is "kicked off" by a "helper.xml" script, which then calls "publish.xml". That "helper.xml" method did NOT already have eclipseStreamMajor and eclipseStreamMinor. 

So, I used the tried-and-true "reuse via copy/paste" to compute those values in helper.xml before calling publish.xml. It is the same code that is in genTestIndexes.xml so presumably it could be "abstracted out", or something so the code only exists in one place, but, thought copy/paste was the best way to make quick progress. 

I will leave it to others if they want to open future enhancement requests to come up with a better solution.