Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 495847 - Remove gif images for which pngs are available
Summary: Remove gif images for which pngs are available
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 4.6   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 4.7 M5   Edit
Assignee: Sarika Sinha CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 465456
Blocks:
  Show dependency tree
 
Reported: 2016-06-10 00:51 EDT by Sarika Sinha CLA
Modified: 2017-01-23 23:26 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sarika Sinha CLA 2016-06-10 00:51:11 EDT
As discussed in Bug 493931 , Will have to remove Gif images which are not cached by ui as mentioned in Bug 465456
Comment 1 Sarika Sinha CLA 2016-09-12 02:16:32 EDT
Moving to M4, as M3 is dedicated for Java 9 work.
Comment 2 Eclipse Genie CLA 2016-12-01 00:15:32 EST
New Gerrit change created: https://git.eclipse.org/r/86113
Comment 3 Sarika Sinha CLA 2016-12-01 00:17:14 EST
Patch is ready but will like to release in the early stage of milestone as it has risks for cached images.
Comment 5 Markus Keller CLA 2016-12-12 09:46:56 EST
org.eclipse.debug.ui/icons/full/eview16/details_view.gif should not have been removed.

Furthermore, bug 465456 affects editor icons as well, so you should retain
icons/full/obj16/stckframe_obj.gif

I've spelt this out in bug 465456 comment 26 (copied from bug 427950 comment 3).
Comment 6 Sarika Sinha CLA 2016-12-13 04:28:06 EST
(In reply to Markus Keller from comment #5)
> org.eclipse.debug.ui/icons/full/eview16/details_view.gif should not have
> been removed.
> 
> Furthermore, bug 465456 affects editor icons as well, so you should retain
> icons/full/obj16/stckframe_obj.gif
> 
> I've spelt this out in bug 465456 comment 26 (copied from bug 427950 comment
> 3).

Added back details_view.gif and stckframe_obj.gif

http://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=eae4d5f123b94a3bb6f6bc7d0257a6192359f254
Comment 7 Sarika Sinha CLA 2017-01-23 23:26:53 EST
Verified by Code inspection

Eclipse SDK

Version: Oxygen (4.7)
Build id: I20170123-2000