495758 – Copy Workbench Layout fails when switching workspaces

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 495758 - Copy Workbench Layout fails when switching workspaces

Summary: Copy Workbench Layout fails when switching workspaces

Status:	VERIFIED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	IDE (show other bugs)
Version:	4.6
Hardware:	PC Windows 7

Importance:	P3 normal with 2 votes (vote)
Target Milestone:	4.6.2
Assignee:	Brian de Alwis
QA Contact:

URL:
Whiteboard:
Keywords:

Duplicates (1):	490805 (view as bug list)
Depends on:
Blocks:

Reported:	2016-06-08 18:10 EDT by Gary D. Gregory
Modified:	2016-11-17 16:20 EST (History)
CC List:	8 users (show)

See Also:	485914 Gerrit Change Git Commit Gerrit Change Git Commit

Flags:	Lars.Vogel: pmc_approved+ Lars.Vogel: review+

Attachments
Problems Transferring Settings (348.66 KB, image/png) 2016-06-08 18:10 EDT, Gary D. Gregory	no flags	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Gary D. Gregory

2016-06-08 18:10:19 EDT

Created attachment 262328 [details]
Problems Transferring Settings

Version: Neon S-4.6RC4a-201606061100
Build id: I20160606-1100

- I created a workspace for Apache CXF as cloned from Git master and imported as existing Maven projects.
- I created another workspace for Apache Commons and imported the Maven projects.
- Then I started Eclipse again and opened on the CXF WS on start up, then I want to pass on my dark them and what nots WS settings to the Commons workspace, so I choose Switch workspace and enabled all of the Copy Settings check boxes, this gave me the problems:

Problems Transferring Settings
  Plug-in org.eclipse.ui was unable to load class org.eclipse.ui.internal.WorkbenchLayoutSettingsTransfer.
  org.eclipse.ui.internal.WorkbenchLayoutSettingsTransfer cannot be found by org.eclipse.ui_3.108.0.v20160518-1929


See screenshot.

Comment 1 Brian de Alwis

2016-06-09 09:30:45 EDT

This class was removed with commit 31ca8167f07b783db972e653c9a07e23cfd4f3a8.

Lars, I think we should restore 'bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/WorkbenchLayoutSettingsTransfer.java' — it looks like it properly handles copying the workbench.xmi.

Comment 2 Andrey Loskutov

2016-06-09 09:33:43 EDT

*** Bug 490805 has been marked as a duplicate of this bug. ***

Comment 3 Lars Vogel

2016-06-09 10:07:33 EDT

(In reply to Brian de Alwis from comment #1)
> This class was removed with commit 31ca8167f07b783db972e653c9a07e23cfd4f3a8.
> 
> Lars, I think we should restore 'bundles/org.eclipse.ui.workbench/Eclipse
> UI/org/eclipse/ui/internal/WorkbenchLayoutSettingsTransfer.java' — it looks
> like it properly handles copying the workbench.xmi.

+1

Comment 4 Brian de Alwis

2016-06-09 10:50:18 EDT

Retitled and re-assigned.

Comment 5 Eclipse Genie

2016-06-09 10:50:34 EDT

New Gerrit change created: https://git.eclipse.org/r/74985

Comment 6 Lars Vogel

2016-06-09 10:51:22 EDT

Thanks for as solving this bug, Brian

Comment 7 Eclipse Genie

2016-06-14 23:06:45 EDT

Gerrit change https://git.eclipse.org/r/74985 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=5de88eb88bfb2cd7bd055a83d9d30a2e1fd5a597

Comment 8 Brian de Alwis

2016-06-14 23:31:10 EDT

Leaving open for backport to Neon.1

Comment 9 Eclipse Genie

2016-08-18 11:53:18 EDT

New Gerrit change created: https://git.eclipse.org/r/79280

Comment 10 Lars Vogel

2016-09-23 09:42:34 EDT

OK to downport from project lead and committer.

Comment 11 Miroslav Zaťko

2016-10-16 05:26:46 EDT

same problem here with eclipse.neon.1 on linux

Comment 12 Eclipse Genie

2016-10-26 10:35:32 EDT

Gerrit change https://git.eclipse.org/r/79280 was merged to [R4_6_maintenance].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=0a88e4a7fe65a3456d60234d7a3608178f6686da

Comment 13 Brian de Alwis

2016-10-26 10:40:26 EDT

I don't know why I missed PMC/Lars' approval, and I hope I haven't committed this out of turn.

Comment 14 Brian de Alwis

2016-11-17 16:20:19 EST

Verified in M20161116-1100 (at least, it works for me).