Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 494534 - StringVariableSelectionDialog#showVariablesPage() uses wrong parent shell
Summary: StringVariableSelectionDialog#showVariablesPage() uses wrong parent shell
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 4.6   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-Debug-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-25 09:02 EDT by Markus Keller CLA
Modified: 2020-07-02 13:04 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2016-05-25 09:02:16 EDT
(From bug 478975's review comments on https://git.eclipse.org/r/#/c/73419/ ;
 Bug 494533 is the JDT/Debug counterpart)

DebugUIPlugin#getShell() has attracted wrong callers that missed that modal dialogs may be open.

Fix the Javadocs to warn about this problem and advise callers to consider getting the proper shell from their context.

Make a pass over all callers and fix wrong invocations like StringVariableSelectionDialog#showVariablesPage().

E.g. on Mac OS X 10.11 in full-screen mode, these steps open a dialog that is hidden behind other dialogs: Run > Debug Configurations... > select a Java Application config. > Arguments tab > click Variables... button > click Edit Variables... .
Comment 1 Eclipse Genie CLA 2020-07-02 13:04:44 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.