This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 494208 - Add Java 8 facet version to JavaFacetUtil
Summary: Add Java 8 facet version to JavaFacetUtil
Status: RESOLVED FIXED
Alias: None
Product: WTP Webservices
Classification: WebTools
Component: jst.ws (show other bugs)
Version: 3.7.2   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 3.8 RC2   Edit
Assignee: Keith Chong CLA
QA Contact: Keith Chong CLA
URL:
Whiteboard: PMC
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-20 15:12 EDT by Keith Chong CLA
Modified: 2016-05-24 11:08 EDT (History)
8 users (show)

See Also:
keith.chong.ca: pmc_approved? (david_williams)
raghunathan.srinivasan: pmc_approved+
keith.chong.ca: pmc_approved? (naci.dai)
keith.chong.ca: pmc_approved? (neil.hauge)
keith.chong.ca: pmc_approved? (cbridgha)
keith.chong.ca: pmc_approved? (ccc)
keith.chong.ca: pmc_approved? (vrubezhny)

Attachments
Apply to org.eclipse.jst.ws.consumption (1.86 KB, patch)
2016-05-20 15:47 EDT, Keith Chong CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Chong CLA 2016-05-20 15:12:11 EDT 
This prevents 1.8 Java Projects from appearing in the Web Services Client Wizard
Comment 1 Keith Chong CLA 2016-05-20 15:47:48 EDT 
Created attachment 261911 [details]
Apply to org.eclipse.jst.ws.consumption
Comment 2 Jonathan West CLA 2016-05-20 17:17:49 EDT 
I have reviewed and tested the patch and can confirm Java 8 projects now appear as expected in Client wizard.
Comment 3 Keith Chong CLA 2016-05-20 17:34:10 EDT 
1.    Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such.

Requested by adopter.

2.    Is there a work-around? If so, why do you believe the work-around is insufficient?
None.

3.    How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added?

I tested it.  Jonathan tested it.  See his comment.   An automated test will be added and that is in progress.

4.    Give a brief technical overview. Who has reviewed this fix?
Simple if statement change.

5.    What is the risk associated with this fix?
Very low risk.  See patch.
Comment 4 Keith Chong CLA 2016-05-20 17:36:00 EDT 
Hi PMC members, please review/approve. Thanks in advance.
Comment 6 Keith Chong CLA 2016-05-24 11:08:16 EDT 
Fix pushed to master