This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 493364 - JSON Editor icons
Summary: JSON Editor icons
Status: RESOLVED FIXED
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: wst.json (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.8 RC3   Edit
Assignee: Project Inbox CLA
QA Contact: Nick Sandonato CLA
URL:
Whiteboard: RHT PMC_Approved
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-10 11:59 EDT by Victor Rubezhny CLA
Modified: 2016-05-26 17:07 EDT (History)
10 users (show)

See Also:
vrubezhny: pmc_approved? (david_williams)
vrubezhny: pmc_approved? (raghunathan.srinivasan)
vrubezhny: pmc_approved? (naci.dai)
vrubezhny: pmc_approved? (neil.hauge)
cbridgha: pmc_approved+
vrubezhny: pmc_approved? (ccc)
vrubezhny: pmc_approved+
nsand.dev: review+

Attachments
new set of png icons including xcf source and png result (86.46 KB, application/x-zip)
2016-05-10 11:59 EDT, Victor Rubezhny CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Victor Rubezhny CLA 2016-05-10 11:59:33 EDT 
Created attachment 261611 [details]
new set of png icons including xcf source and png result

The set of icons proposed for JSON Editor's elements.

XCF Source for new images - editable with GIMP, the source for the new iconset, so it will be easy to make minor changes.
Comment 1 Victor Rubezhny CLA 2016-05-25 10:53:43 EDT 
Eclipse IPTeam has approved the proposed icons: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=11355
Comment 2 Eclipse Genie CLA 2016-05-25 13:57:06 EDT 
New Gerrit change created: https://git.eclipse.org/r/73641
Comment 3 Victor Rubezhny CLA 2016-05-25 14:05:03 EDT 
* Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug"
(requested by an adopter) please document it as such.

The fix adds the required check for null

* Is there a work-around? If so, why do you believe the work-around is
insufficient?

The Icons replacement discussed on RH + IBM JSDT/Sourceediting meetings is set instead of the old exiting ones for JSON Objects/Properties shown in JSON Editor Outline 

* How has the fix been tested? Is there a test case attached to the bugzilla
record? Has a JUnit Test been added?

Tested manually. 

* Give a brief technical overview. Who has reviewed this fix?

The icons replacement if tested by Victor Rubezhny

* What is the risk associated with this fix?

There is no risk.
Comment 4 Victor Rubezhny CLA 2016-05-25 14:06:09 EDT 
Nick, could you please approve this change for RC3 as the project lead?
Comment 5 Chuck Bridgham CLA 2016-05-25 14:16:55 EDT 
These icons were actually discussed an agreed upon weeks ago, but were just legally cleared today...

+1 for me
Comment 6 Nick Sandonato CLA 2016-05-26 14:17:13 EDT 
+1 from me as well.