Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 492916 - Add eclipse.uuid to Marketplace REST calls
Summary: Add eclipse.uuid to Marketplace REST calls
Status: RESOLVED FIXED
Alias: None
Product: MPC
Classification: Technology
Component: wizard (show other bugs)
Version: 1.2   Edit
Hardware: All All
: P3 critical (vote)
Target Milestone: 1.5   Edit
Assignee: Carsten Reckord CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-03 13:41 EDT by Ian Skerrett CLA
Modified: 2016-06-05 13:11 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Skerrett CLA 2016-05-03 13:41:31 EDT 
I would like to have the MPC add the eclipse.uuid property to the user agent of the REST calls.  Similar to what was done for p2 https://git.eclipse.org/r/#/c/71555/1/bundles/org.eclipse.equinox.p2.transport.ecf/src/org/eclipse/equinox/internal/p2/transport/ecf/FileReader.java
Comment 1 Carsten Reckord CLA 2016-05-17 11:32:09 EDT 
This was fixed for Neon M7. The UUID is added to all "regular" Marketplace REST calls.

I don't have any influence on the calls happening through USS, which don't include the UUID. Also, the requests for importing another user's favorites mimic the USS calls 1:1, so they currently don't add the UUID either. 

Please reopen if we should add the UUID to the favorites import. In that case, we'll need to decide where it should be added. Options are
- in the user agent (this is what p2 does)
- as a query parameter to the url (this is what the MPC REST client does)
- as a custom HTTP header
If the UUID will be included in USS, we should use the same strategy here as in USS i think.
Comment 2 Mykola Nikishov CLA 2016-05-30 11:57:51 EDT 
(In reply to Carsten Reckord from comment #1)

> This was fixed for Neon M7. The UUID is added to all "regular" Marketplace
> REST calls.

Carsten, could you provide link to commit/Gerrit change that implemented this?
Comment 3 Mykola Nikishov CLA 2016-05-30 14:25:58 EDT 
(In reply to Mykola Nikishov from comment #2)

> (In reply to Carsten Reckord from comment #1)
> 
> > This was fixed for Neon M7. The UUID is added to all "regular" Marketplace
> > REST calls.
> 
> Carsten, could you provide link to commit/Gerrit change that implemented
> this?

Nevermind, I've found it.
Comment 4 Markus Knauer CLA 2016-06-05 11:39:30 EDT 
After a long discussion on the cross-project mailing list [1] we decided to remove the UUID in Platform (see bug 495484). Therefore I'm asking to revert the relevant changes in MPC.


[1] https://dev.eclipse.org/mhonarc/lists/cross-project-issues-dev/msg13204.html
Comment 5 Carsten Reckord CLA 2016-06-05 12:56:55 EDT 
Done in commit 553c5d7e4f41493427d1f2d744d9bfe5d05934f5 and 6e00255818931f8a8692524e9eec0d674b1fd231. I'll push a new MPC build to simrel shortly.

Thank you for the great cross-project discussion and sorry for missing it.
Comment 6 Carsten Reckord CLA 2016-06-05 13:11:32 EDT 
New build is pushed to Simrel. See https://git.eclipse.org/r/#/c/74586/