Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 492842 - Drag-and-drop of views and editors is badly broken on GTK
Summary: Drag-and-drop of views and editors is badly broken on GTK
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.6   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.6 RC1   Edit
Assignee: Stefan Xenos CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 404684 434524 463582 484179 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-05-02 13:58 EDT by Stefan Xenos CLA
Modified: 2016-06-08 01:18 EDT (History)
6 users (show)

See Also:
Lars.Vogel: review+


Attachments
Project Explorer corruption (14.10 KB, image/png)
2016-05-23 11:01 EDT, Sascha Konrad CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Xenos CLA 2016-05-02 13:58:15 EDT
To reproduce:

Running on Ubuntu, click an editor or view tab and drag it around the workbench. 

Observed:
- The eclipse title bar flashes while dragging.
- Occasionally a window seems to appear and disappear, with its upper-left corner in the upper-left of the Eclipse window and its lower-right corner matching the lower-right corner of the current view.
- Frequently the UI will stop responding to mouse events entirely during the drag and the drag operation must be stopped and restarted.
Comment 1 Eclipse Genie CLA 2016-05-02 14:02:45 EDT
New Gerrit change created: https://git.eclipse.org/r/71811
Comment 3 Stefan Xenos CLA 2016-05-02 15:37:10 EDT
I believe this also fixed bug 434524, but I'd like to hear confirmation before closing that one.
Comment 4 Lars Vogel CLA 2016-05-03 02:33:42 EDT
(In reply to Stefan Xenos from comment #0)
> To reproduce:
> 
> Running on Ubuntu, click an editor or view tab and drag it around the
> workbench. 
> 
> Observed:
> - The eclipse title bar flashes while dragging.
> - Occasionally a window seems to appear and disappear, with its upper-left
> corner in the upper-left of the Eclipse window and its lower-right corner
> matching the lower-right corner of the current view.
> - Frequently the UI will stop responding to mouse events entirely during the
> drag and the drag operation must be stopped and restarted.

Very nice. Finally drag and drop works again under Linux. I verified the patch in  a runtime Eclipse.
Comment 5 Sergey Prigogin CLA 2016-05-03 17:08:04 EDT
I've noticed an intermittent problem. Sometimes, when dragging an editor tab to the right, there is no target feedback in the position after the rightmost tab and, in more rare cases, before the rightmost tab. It looks like the problem is more likely to be reproducible right after Eclipse startup when there is chevron on the right end of the tab raw.
Comment 6 Stefan Xenos CLA 2016-05-03 19:02:41 EDT
Sergey, we should add that to the list of remaining D&D issues I'm tracking in bug 492861.
Comment 7 Lars Vogel CLA 2016-05-05 04:20:10 EDT
*** Bug 484179 has been marked as a duplicate of this bug. ***
Comment 8 Stefan Xenos CLA 2016-05-10 10:03:06 EDT
*** Bug 463582 has been marked as a duplicate of this bug. ***
Comment 9 Stefan Xenos CLA 2016-05-10 12:08:02 EDT
*** Bug 434524 has been marked as a duplicate of this bug. ***
Comment 10 Sascha Konrad CLA 2016-05-23 11:01:38 EDT
Created attachment 261955 [details]
Project Explorer corruption

Happens after dragging an editor to create a split
Comment 11 Sascha Konrad CLA 2016-05-23 11:02:46 EDT
Just tested RC1. Drag and Drop works again, but I noticed something pretty bad: It seems to corrupt the project explorer view for me. I have attached a screenshot of what that looks like. This only happens after I drap and drop an editor to create a a split, it I don't drag and drop it's okay. I have to restart Eclipse for Project Explorer to return to normal.
Comment 12 Sascha Konrad CLA 2016-05-23 11:08:08 EDT
Actually, this is really bad. It also happens for me now when I drag an editor from one side of the split to the other side. This is definitely a new issue in RC1, and I didn't have this before. I really hope this doesn't make it into the final release, as it would make Eclipse pretty much unusable for me. I much prefer the previous behavior, where drag and drop for split wouldn't work, but I had some keyboard shortcuts setup to do the split (via Vrapper). Then I could drag editors back and forth and it wouldn't corrupt the project explorer.
Comment 13 Sascha Konrad CLA 2016-05-24 08:27:07 EDT
I opened a new bug report for the issue: https://bugs.eclipse.org/bugs/show_bug.cgi?id=494406
Comment 14 Sergey Prigogin CLA 2016-06-08 01:18:11 EDT
*** Bug 404684 has been marked as a duplicate of this bug. ***